Re: [pacman-dev] [PATCH] Remove old TODO lists

2011-07-03 Thread Xavier Chantry
On Wed, Jun 22, 2011 at 10:54 AM, Allan McRae al...@archlinux.org wrote: These had not been touched since 2007 and had lost most of their relevance.  The bug tracker is a better place for the filing of ideas. Agreed, but if some items are not completely obsolete and don't appear anywhere in

Re: [pacman-dev] [PATCH] Remove old TODO lists

2011-07-03 Thread Dan McGee
On Sun, Jul 3, 2011 at 4:57 AM, Xavier Chantry chantry.xav...@gmail.com wrote: On Wed, Jun 22, 2011 at 10:54 AM, Allan McRae al...@archlinux.org wrote: These had not been touched since 2007 and had lost most of their relevance.  The bug tracker is a better place for the filing of ideas.

[pacman-dev] [PATCH 1/2] be_sync: make READ_NEXT() a no-arg macro

2011-07-03 Thread Dan McGee
We passed in 'line', but not 'buf.line'. In addition, the macros building off of READ_NEXT() assume variable names anyway. Since we only use these macros in one function, might as well simplify them. Signed-off-by: Dan McGee d...@archlinux.org --- lib/libalpm/be_sync.c | 24

[pacman-dev] [PATCH 2/2] be_local: use macros in database loading similar to be_sync

2011-07-03 Thread Dan McGee
This removes some of the repetition in the code for reading and parsing database file lines. Signed-off-by: Dan McGee d...@archlinux.org --- lib/libalpm/be_local.c | 120 +--- 1 files changed, 43 insertions(+), 77 deletions(-) diff --git

Re: [pacman-dev] [PATCH 1/4] dload: handle irregular URLs

2011-07-03 Thread Dan McGee
On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: From: Dave Reisner d...@falconindy.com URLs might end with a slash and follow redirects, or could be a generated by a script such as /getpkg.php?id=12345. In both cases, we may have a better filename that we can write to,

Re: [pacman-dev] [PATCH 2/4] lib/dload: prevent large file attacks

2011-07-03 Thread Dan McGee
On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: From: Dave Reisner d...@falconindy.com This means creating a new struct which can pass more descriptive data from the back end sync functions to the downloader. In particular, we're interested in the download size read

Re: [pacman-dev] [PATCH 3/4] absorb some _alpm_download params into payload struct

2011-07-03 Thread Dan McGee
On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: Restore some sanity to the number of arguments passed to _alpm_download and curl_download_internal. Signed-off-by: Dave Reisner dreis...@archlinux.org ---  lib/libalpm/be_sync.c |   12 +++--  lib/libalpm/dload.c   |  

Re: [pacman-dev] [PATCH 4/4] absorb fileinfo struct into dload_payload

2011-07-03 Thread Dan McGee
On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: This transitional struct becomes delicious noms for dload_payload. Ignore me on the previous patch; merging the two is better done in a separate patch, so keep it like this. Signed-off-by: Dave Reisner

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.5.3-423-g1ce7f39

2011-07-03 Thread Dan McGee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project The official pacman repository. The branch, master has been updated via 1ce7f39ad73c5c96870c6036014afad3d49a8edf (commit) via

[pacman-dev] [PATCH 1/4] signing: move to new signing verification and return scheme

2011-07-03 Thread Dan McGee
This gives us more granularity than the former Never/Optional/Always trifecta. The frontend still uses these values temporarily but that will be changed in a future patch. * Use 'siglevel' consistenly in method names, 'level' as variable name * The level becomes an enum bitmask value for

[pacman-dev] [PATCH 2/4] Correctly check the GPG error codes

2011-07-03 Thread Dan McGee
The error code is in fact a bitmask value of an error code and an error source, so use the proper function to get only the relevant bits. For the no error case, this shouldn't ever matter, but it bit me when I was trying to compare the error code to other values and wondered why it wasn't working,

[pacman-dev] [PATCH 3/4] Allow frontend access to signature verification information

2011-07-03 Thread Dan McGee
Show output in -Qip for each package signature, which includes the UID string from the key (Joe User j...@example.com) and the validity of said key. Example output: Signatures : Valid signature from Dan McGee dpmc...@gmail.com Unknown signature from Key Unknown

[pacman-dev] [PATCH 4/4] Allow invalid sync DBs to be returned by the library

2011-07-03 Thread Dan McGee
They are placeholders, but important for things like trying to re-sync a database missing a signature. By using the alpm_db_validity() method at the right time, a client can take the appropriate action with these invalid databases as necessary. In pacman's case, we disallow just about anything

Re: [pacman-dev] [PATCH 1/4] dload: handle irregular URLs

2011-07-03 Thread Dave Reisner
On Sun, Jul 03, 2011 at 01:56:05PM -0500, Dan McGee wrote: On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: From: Dave Reisner d...@falconindy.com URLs might end with a slash and follow redirects, or could be a generated by a script such as /getpkg.php?id=12345. In

Re: [pacman-dev] [PATCH 2/4] lib/dload: prevent large file attacks

2011-07-03 Thread Dave Reisner
On Sun, Jul 03, 2011 at 02:13:30PM -0500, Dan McGee wrote: On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: From: Dave Reisner d...@falconindy.com This means creating a new struct which can pass more descriptive data from the back end sync functions to the

Re: [pacman-dev] [PATCH 3/4] absorb some _alpm_download params into payload struct

2011-07-03 Thread Dave Reisner
On Sun, Jul 03, 2011 at 02:20:13PM -0500, Dan McGee wrote: On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: Restore some sanity to the number of arguments passed to _alpm_download and curl_download_internal. Signed-off-by: Dave Reisner dreis...@archlinux.org ---

Re: [pacman-dev] [PATCH 4/4] absorb fileinfo struct into dload_payload

2011-07-03 Thread Dave Reisner
On Sun, Jul 03, 2011 at 02:26:10PM -0500, Dan McGee wrote: On Fri, Jul 1, 2011 at 7:59 AM, Dave Reisner d...@falconindy.com wrote: This transitional struct becomes delicious noms for dload_payload. Ignore me on the previous patch; merging the two is better done in a separate patch, so keep it

[pacman-dev] [PATCH] Remove alpm_list_first

2011-07-03 Thread Allan McRae
The only thing this accessor did was remove the const qualifier given our entire list implementation requires passing around the head anyway. Signed-off-by: Allan McRae al...@archlinux.org --- lib/libalpm/alpm_list.c | 16 lib/libalpm/alpm_list.h |1 - src/pacman/util.c

[pacman-dev] [PATCH] Simplify alpm_list_previous

2011-07-03 Thread Allan McRae
We can readily detect the first node in a list by checking if node-prev-next is NULL. So there is no need to pass the head of the list to this function and its prototype now looks like all the other item accessors. Signed-off-by: Allan McRae al...@archlinux.org --- lib/libalpm/alpm_list.c |7