Re: [pacman-dev] [PATCH] Remove SyncFirst option

2012-02-14 Thread Pierre Schmitz
Am 14.02.2012 23:08, schrieb Dave Reisner: > On Tue, Feb 14, 2012 at 02:30:06PM -0600, Dan McGee wrote: >> This has outlived its usefulness and causes more problems than it >> solves. >> >> Signed-off-by: Dan McGee >> --- >> >> This is an RFC first of all, so please feel free to comment. >> >> Pro

Re: [pacman-dev] [PATCH] Remove SyncFirst option

2012-02-14 Thread Dave Reisner
On Tue, Feb 14, 2012 at 02:30:06PM -0600, Dan McGee wrote: > This has outlived its usefulness and causes more problems than it > solves. > > Signed-off-by: Dan McGee > --- > > This is an RFC first of all, so please feel free to comment. > > Pros: > 1. Removes complexity and a fair amount of cod

Re: [pacman-dev] [PATCH] scripts: unset CDPATH if cd is used

2012-02-14 Thread Dave Reisner
On Tue, Feb 14, 2012 at 10:14:08AM -0600, Dan McGee wrote: > This wonderful/awful little bash shell variable wrecks havoc on `cd` > calls in shell scripts. Unset CDPATH in makepkg where we use `cd` quite > heavily. In pacman-optimize, we can move the change directory logic into > the bsdtar call so

[pacman-dev] [PATCH] makepkg: fix syntax error in remove_deps

2012-02-14 Thread Christoph Vigano
This fixes a problem that occurs if you tell makepkg to remove installed dependencies (just to be sure) but there are none. As the $ was missing in front of deplist, the check never happened and 'pacman -Rn' was called which obviously failed. Greetings, Christoph Signed-off-by: Christoph Vigano

[pacman-dev] [PATCH] Remove SyncFirst option

2012-02-14 Thread Dan McGee
This has outlived its usefulness and causes more problems than it solves. Signed-off-by: Dan McGee --- This is an RFC first of all, so please feel free to comment. Pros: 1. Removes complexity and a fair amount of code. 2. Removes the hack necesary for download-only and print operations. 3. Clos

[pacman-dev] [PATCH 3/3] makepkg: complain when the buildfile isn't writeable

2012-02-14 Thread Dave Reisner
If the PKGBUILD isn't writeable for devel_update, throw a warning instead of silently ignoring it. Some logical reordering is present in this patch to reduce the number of nested if's. Signed-off-by: Dave Reisner --- scripts/makepkg.sh.in | 14 +++--- 1 files changed, 7 insertions(+),

[pacman-dev] [PATCH 2/3] makepkg: catch errors sourcing files

2012-02-14 Thread Dave Reisner
create source_safe() function which temporarily disables extglob and exits on error. Signed-off-by: Dave Reisner --- scripts/makepkg.sh.in | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 61c95af..

[pacman-dev] [PATCH 1/3] makepkg: restrict usage of errexit to user functions

2012-02-14 Thread Dave Reisner
It's expected that this will lead to unwanted behavior, and needs widespread testing. It's desirable to commit this for a few reasons: - there's no reason we can't do our own error checking for code that we write. - it avoids the need for ||true hacks scattered about in the code. - it makes us i

[pacman-dev] [PATCH] scripts: unset CDPATH if cd is used

2012-02-14 Thread Dan McGee
This wonderful/awful little bash shell variable wrecks havoc on `cd` calls in shell scripts. Unset CDPATH in makepkg where we use `cd` quite heavily. In pacman-optimize, we can move the change directory logic into the bsdtar call so we are left with no usages of `cd` in the script. Signed-off-by: