[pacman-dev] [PATCH] makepkg: remove subshelling from check_option and friends

2012-04-25 Thread Dave Reisner
Instead of creating a subshell for each of these checks (of which there are many), pass in an expected value and make the check_* function do the comparison for us, returning 0 (match), 1, (mismatch), or 127 (not found). For a measureable benefit: I tested this on a fairly simple package (perl-ter

[pacman-dev] Manual rankmirrors.

2012-04-25 Thread Kevin Chadwick
I use rankmirrors and I notice on timeouts pacman automatically switches. Today, though most packages downloaded quickly from the mirror just selected by rankmirrors, one or two went very very slow. I guess differing routes by different package requests. Would it be easy to add a ^S (Ctrl-S) to te

Re: [pacman-dev] Manual rankmirrors.

2012-04-25 Thread Dan McGee
On Wed, Apr 25, 2012 at 2:49 PM, Kevin Chadwick wrote: > On a side note should pacman be using /proc/mounts for Checkspace > rather than /etc/mtab. 1) We don't reference a filename at all in the code, we use "standardized" functions to access this 2) On your Arch machine, /etc/mtab is a symlink t

Re: [pacman-dev] Manual rankmirrors.

2012-04-25 Thread Daniel Wallace
/etc/mtab is symlinked to /proc/self/mount └─╼ ls -l /etc/mtab lrwxrwxrwx 1 root root 17 Apr 1 19:41 /etc/mtab -> /proc/self/mounts On Wed, Apr 25, 2012 at 08:49:48PM +0100, Kevin Chadwick wrote: > I use rankmirrors and I notice on timeouts pacman automatically > switches. Today, though most pa

Re: [pacman-dev] Manual rankmirrors.

2012-04-25 Thread DJ Mills
On Wed, Apr 25, 2012 at 3:49 PM, Kevin Chadwick wrote: > Would it be easy to add a ^S (Ctrl-S) to tell pacman to stop and retry > at the next mirror. The mirrors may not necessarily be in sync, the next mirror could have a completely different version of the package. Could cause difficulties...

Re: [pacman-dev] Manual rankmirrors.

2012-04-25 Thread Dave Reisner
On Wed, Apr 25, 2012 at 08:49:48PM +0100, Kevin Chadwick wrote: > I use rankmirrors and I notice on timeouts pacman automatically > switches. Today, though most packages downloaded quickly from the > mirror just selected by rankmirrors, one or two went very very slow. I > guess differing routes by