Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Allan McRae
On 09/02/14 19:54, Jerome Leclanche wrote: On Sun, Feb 9, 2014 at 1:02 AM, Allan McRae al...@archlinux.org wrote: In conclusion, we have the same support for ChangeLog that every other package manager has. And I am convinced that the changelog for the package is the changelog a package

Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Jerome Leclanche
On Sun, Feb 9, 2014 at 10:06 AM, Allan McRae al...@archlinux.org wrote: Sure it does. Taking the Debian approach: install -Dm644 ChangeLog $pkgdir/usr/share/doc/$pkgname/ChangeLog In that case, we need to officialise it in the wiki imo. I'm still strongly in favour of adding a

Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Allan McRae
On 09/02/14 20:19, Jerome Leclanche wrote: On Sun, Feb 9, 2014 at 10:06 AM, Allan McRae al...@archlinux.org wrote: Sure it does. Taking the Debian approach: install -Dm644 ChangeLog $pkgdir/usr/share/doc/$pkgname/ChangeLog In that case, we need to officialise it in the wiki imo. I'm

Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Jerome Leclanche
On Sun, Feb 9, 2014 at 10:27 AM, Allan McRae al...@archlinux.org wrote: Pacman does not have a wiki... so I guess you are talking about Arch policy, in which case I believe the answer would be no. If upstream wanted their ChangeLog installed to your system, they would do that on make

Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Allan McRae
On 09/02/14 20:37, Jerome Leclanche wrote: On Sun, Feb 9, 2014 at 10:27 AM, Allan McRae al...@archlinux.org wrote: Pacman does not have a wiki... so I guess you are talking about Arch policy, in which case I believe the answer would be no. If upstream wanted their ChangeLog installed to your

Re: [pacman-dev] Discussion on changelogs

2014-02-09 Thread Jerome Leclanche
On Sun, Feb 9, 2014 at 10:46 AM, Allan McRae al...@archlinux.org wrote: It is not the package managers job to maintain information about upstream development. The job for a package manager is to maintain information about the actual package file. Hence the only changelog that is appropriate

Re: [pacman-dev] [PATCH v2 2/6] pacsearch: indexing by 'name version' instead of 'name'

2014-02-09 Thread Pierre Neidhardt
On 14-02-09 11:22:03, Allan McRae wrote: On 07/02/14 12:07, Andrew Gregory wrote: On 02/05/14 at 04:15pm, Pierre Neidhardt wrote: On 14-02-05 09:15:28, Andrew Gregory wrote: On 02/04/14 at 12:16am, Pierre Neidhardt wrote: Signed-off-by: Pierre Neidhardt ambre...@gmail.com ---

Re: [pacman-dev] [PATCH v2 3/6] pacsearch: removed redundant sorting

2014-02-09 Thread Pierre Neidhardt
On 14-02-09 11:17:06, Allan McRae wrote: On 06/02/14 01:16, Pierre Neidhardt wrote: On 14-02-05 09:18:48, Andrew Gregory wrote: On 02/04/14 at 12:16am, Pierre Neidhardt wrote: Package are processed in the same order as pacman output, so there is no real need to sort, we can print

Re: [pacman-dev] [PATCH v2 4/6] pacsearch: fixed regular expression for local searches

2014-02-09 Thread Pierre Neidhardt
On 14-02-06 21:43:58, Andrew Gregory wrote: These part were always ~ 50% different. It's less thant 10 lines of code anyway, no big deal. Trying to make a common function out of this would result in longer and more complex code I believe. The sync search code is 21 lines. Only 1

[pacman-dev] [PATCHv3 2/7] pacsearch: indexing by 'name version' instead of 'name'

2014-02-09 Thread Pierre Neidhardt
In the old pacsearch, packages were identified uniquely by pkgfields[1], which contained pkgname+pkgver. Since commit 4d13558 pkgver is stored in pkgfields[2], and packages have been identified with pkgfields[1] only. Because of that packages with a different version would appear once only. This

[pacman-dev] [PATCHv3 6/7] pacsearch: pattern arguments work as for pacman

2014-02-09 Thread Pierre Neidhardt
Previously only one pattern was allowed. $ pacsearch foo bar Search for packages containing 'foo bar'. $ pacman -Ss foo bar Search for packages containing both 'foo' and 'bar'. Note that removing the quotes from the call was not enough since $ pacsearch 'foo|bar' would then fail.

[pacman-dev] [PATCHv3 5/7] pacsearch: skip any non-matching line instead of printing them

2014-02-09 Thread Pierre Neidhardt
If input cannot be parsed, it is not desirable to output it along other valid entries. This would make pacsearch output unpredictable. Signed-off-by: Pierre Neidhardt ambre...@gmail.com --- contrib/pacsearch.in | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCHv3 4/7] pacsearch: fields are treated uniformly when printing

2014-02-09 Thread Pierre Neidhardt
We include the leading space in the match for 'group' and 'installed'. This allows us to remove the conditions when printing. Signed-off-by: Pierre Neidhardt ambre...@gmail.com --- contrib/pacsearch.in | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[pacman-dev] [PATCHv3 7/7] pacsearch: factored -Ss and -Qs parts into one single function

2014-02-09 Thread Pierre Neidhardt
Signed-off-by: Pierre Neidhardt ambre...@gmail.com --- contrib/pacsearch.in | 65 +++- 1 file changed, 29 insertions(+), 36 deletions(-) diff --git a/contrib/pacsearch.in b/contrib/pacsearch.in index 0dad366..bcfedf0 100644 ---

[pacman-dev] [PATCHv3 1/7] pacsearch: removed useless comment

2014-02-09 Thread Pierre Neidhardt
Signed-off-by: Pierre Neidhardt ambre...@gmail.com --- contrib/pacsearch.in | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/pacsearch.in b/contrib/pacsearch.in index 21043d4..71e0107 100644 --- a/contrib/pacsearch.in +++ b/contrib/pacsearch.in @@ -138,7 +138,6 @@ if ($#querypkgs = 0) {

[pacman-dev] [PATCHv3 3/7] pacsearch: removed redundant sorting

2014-02-09 Thread Pierre Neidhardt
Package are processed in the same order as pacman output, so there is no real need to sort. This makes the code simpler and faster. The only difference is that local packages will always be printed at the end. Previously, they were printed before multilib for instance. Signed-off-by: Pierre

[pacman-dev] Mtree parsing v5

2014-02-09 Thread Florian Pritz
I hope I incorporated all suggestions. Most patches didn't change, but I'm submitting them anyway for an easier (hopefully final) review.

[pacman-dev] [PATCH v5 6/6] be_local: Use alpm_greedy_grow

2014-02-09 Thread Florian Pritz
Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_local.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 0b5b266..d2b0fe3 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c

[pacman-dev] [PATCH v5 5/6] be_package: Build the file list from MTREE if possible

2014-02-09 Thread Florian Pritz
This greatly speeds up file list generation times by avoiding uncompressing the whole package. pacman -S base with a deliberate file conflict: before: 9.1 seconds after: 2.2 seconds Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_package.c | 149

[pacman-dev] [PATCH v5 4/6] be_package: Refactor code adding a file to the files list

2014-02-09 Thread Florian Pritz
Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_package.c | 56 +--- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 5980784..e276f53 100644 ---

[pacman-dev] [PATCH v5 3/6] be_package: Refactor handling of simple path checks

2014-02-09 Thread Florian Pritz
This is used to deduplicate code when using the mtree as the file list source. Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_package.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/lib/libalpm/be_package.c

[pacman-dev] [PATCH v5 1/6] Check if a file is in the package's file list before extracting

2014-02-09 Thread Florian Pritz
Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/add.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index f38afef..1199d30 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -178,6 +178,11 @@ static int

[pacman-dev] [PATCH v5 2/6] util: Add _alpm_realloc() and _alpm_greedy_grow()

2014-02-09 Thread Florian Pritz
These will be used in the following patches. Signed-off-by: Florian Pritz bluew...@xinu.at --- v5: Split automatic growing into _alpm_greedy_grow. lib/libalpm/util.c | 62 ++ lib/libalpm/util.h | 2 ++ 2 files changed, 64 insertions(+) diff

[pacman-dev] [PATCH] makepkg: implement support for stripping kernel modules

2014-02-09 Thread Steven Noonan
I noticed when I built a kernel package with options 'strip' and 'debug' that the debug package was missing the debug information for the kernel modules. This patch adds kernel modules to the targets for 'strip' and is compatible with the split-out debug information packages. Signed-off-by:

[pacman-dev] [PATCH v2] makepkg: implement support for stripping kernel modules

2014-02-09 Thread Steven Noonan
I noticed when I built a kernel package with options 'strip' and 'debug' that the debug package was missing the debug information for the kernel modules. This patch adds kernel modules to the targets for 'strip' and is compatible with the split-out debug information packages. v2: Correct logic

[pacman-dev] [PATCH v3] makepkg: implement support for stripping kernel modules

2014-02-09 Thread Steven Noonan
I noticed when I built a kernel package with options 'strip' and 'debug' that the debug package was missing the debug information for the kernel modules. This patch adds kernel modules to the targets for 'strip' and is compatible with the split-out debug information packages. v2: Correct logic

Re: [pacman-dev] [PATCH] makepkg: implement support for stripping kernel modules

2014-02-09 Thread Dave Reisner
On Sun, Feb 09, 2014 at 03:15:42PM -0800, Steven Noonan wrote: I noticed when I built a kernel package with options 'strip' and 'debug' that the debug package was missing the debug information for the kernel modules. This patch adds kernel modules to the targets for 'strip' and is compatible

Re: [pacman-dev] [PATCH v3] makepkg: implement support for stripping kernel modules

2014-02-09 Thread Allan McRae
On 10/02/14 09:26, Steven Noonan wrote: I noticed when I built a kernel package with options 'strip' and 'debug' that the debug package was missing the debug information for the kernel modules. This patch adds kernel modules to the targets for 'strip' and is compatible with the split-out debug

Re: [pacman-dev] [PATCH] alpm_logaction: Unopenable logfile is an error only when not using syslog

2014-02-09 Thread Zachary Cook
See https://bugs.archlinux.org/task/38584 for more detail and a new patch, but this bug turns out to not prevent standalone syslog. The current logging just does not fallback to syslog if LogFile is invalid / unopenable, which is somewhat expected behavior, and is a lot less important. This patch

Re: [pacman-dev] [PATCH v5 6/6] be_local: Use alpm_greedy_grow

2014-02-09 Thread Allan McRae
On 10/02/14 05:24, Florian Pritz wrote: Signed-off-by: Florian Pritz bluew...@xinu.at --- lib/libalpm/be_local.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 0b5b266..d2b0fe3 100644 ---

Re: [pacman-dev] Mtree parsing v5

2014-02-09 Thread Allan McRae
On 10/02/14 05:24, Florian Pritz wrote: I hope I incorporated all suggestions. Most patches didn't change, but I'm submitting them anyway for an easier (hopefully final) review. Looks good from a quick read to me, apart from that comment I made on the final patch. I'm low on time this week, so