Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
Please find below a revised patch, now including alpm_options_set/get functions, documentation updates, and repaired indentation. I tested this the same way as the previous patch: by building it with makepkg and installing it on my system and using it. This means I haven't tested the

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
On 3/26/14, 2:07 PM, Dave Reisner wrote: What do you plan to set these values to in your environment? Why shouldn't we just adjust these to be more lax? I set the low speed limit to zero and disable the check completely, because of the ridiculous firewall. I don't really understand the reason

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Dave Reisner
On Wed, Mar 26, 2014 at 03:27:34PM -0400, Andrew Hills wrote: On 3/26/14, 2:07 PM, Dave Reisner wrote: What do you plan to set these values to in your environment? Why shouldn't we just adjust these to be more lax? I set the low speed limit to zero and disable the check completely,

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
On 3/26/14, 3:31 PM, Dave Reisner wrote: The low speed limit exists as a way of cancelling a download when the network goes away. Do you have an alternate suggestion? Ah, that makes sense. Yes, my suggestion is to make it configurable, so I can adapt the network disappearance detection fit my

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
Please find below the third iteration of the patch, now using the new alpm_option_set methods, and with more descriptive documenting comments. From 9272595b5207e07799dfd49bac9d27b699253297 Mon Sep 17 00:00:00 2001 From: Andrew Hills ahi...@ednos.net Date: Wed, 19 Mar 2014 14:03:30 -0400 Subject:

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Florian Pritz
On 26.03.2014 21:14, Andrew Hills wrote: Please find below the third iteration of the patch, now using the new alpm_option_set methods, and with more descriptive documenting comments. From 9272595b5207e07799dfd49bac9d27b699253297 Mon Sep 17 00:00:00 2001 From: Andrew Hills ahi...@ednos.net

Re: [pacman-dev] [PATCH] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
On 3/26/14, 5:07 PM, Florian Pritz wrote: Please try to keep subjects for git commits around the 50 char mark (or shorter). The threads subject would be fine. Also try to add some explanatory text like why this change is needed and if applicable why it isn't done differently (in this case

[pacman-dev] [PATCH v4] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Andrew Hills
Add LowSpeedLimit and LowSpeedTime configuration options to correspond to libcurl's CURLOPT_LOW_SPEED_LIMIT and CURLOPT_LOW_SPEED_TIME options. This allows, e.g., transfers behind corporate virus-scanning firewalls to survive the delays. Increasing the timeout may not be desirable in all

Re: [pacman-dev] [PATCH v4] Add configuration options for libcurl's low speed timeout

2014-03-26 Thread Dave Reisner
On Wed, Mar 26, 2014 at 07:48:57PM -0400, Andrew Hills wrote: Add LowSpeedLimit and LowSpeedTime configuration options to correspond to libcurl's CURLOPT_LOW_SPEED_LIMIT and CURLOPT_LOW_SPEED_TIME options. This allows, e.g., transfers behind corporate virus-scanning firewalls to survive the