[pacman-dev] [PATCH 1/3] makepkg: use bash 4.4 to localize `set` without explicitly saving/restoring

2018-08-13 Thread Eli Schwartz
Signed-off-by: Eli Schwartz --- scripts/makepkg.sh.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 4024f477..bb8332c6 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -418,13 +418,14 @@ prepare_build

[pacman-dev] [PATCH 2/3] makepkg: don't save the same shopts twice

2018-08-13 Thread Eli Schwartz
Both run_function and run_function_safe will save and restore `shopt -p` but the former is only called from the latter. It makes sense to save this as part of a "safe" runner, so let's just do it in one place, there where we save and restore everything else too. Signed-off-by: Eli Schwartz --- s

[pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Eli Schwartz
`run_function_safe pkgver` is evaluated in a subshell and therefore does not abort when it should. Explicitly check the return outside of the subshell and abort if necessary. Signed-off-by: Eli Schwartz --- scripts/makepkg.sh.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/make

Re: [pacman-dev] [PATCH 1/3] makepkg: send messages to stdout rather than stderr

2018-08-13 Thread Eli Schwartz
On 6/28/18 1:19 PM, Eli Schwartz wrote: > This behavior is confusing, since it means absolutely everything goes to > stderr and makepkg itself is a quiet program that produces no expected > output??? > > The only situation where messages should go to stderr rather than > stdout, is with --geninteg

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Luke Shumaker
On Mon, 13 Aug 2018 21:20:58 -0400, Eli Schwartz wrote: > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in > index bb24c633..1ab2ea3c 100644 > --- a/scripts/makepkg.sh.in > +++ b/scripts/makepkg.sh.in > @@ -188,6 +188,9 @@ enter_fakeroot() { > # Re-sources the PKGBUILD afterwards to allo

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Eli Schwartz
On 8/13/18 10:13 PM, Luke Shumaker wrote: > On Mon, 13 Aug 2018 21:20:58 -0400, > Eli Schwartz wrote: >> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in >> index bb24c633..1ab2ea3c 100644 >> --- a/scripts/makepkg.sh.in >> +++ b/scripts/makepkg.sh.in >> @@ -188,6 +188,9 @@ enter_fakeroot(