Re: [pacman-dev] [PATCH v2] pacman: fix possible buffer overflow

2018-10-16 Thread Andrew Gregory
On 09/22/18 at 11:30pm, morganamilo wrote: > in the function query_fileowner, if the user enters a string longer > than PATH_MAX then rpath will buffer overflow when lrealpath tries to > strcat everything together. > > So make sure to bail early if the generated path is going to be bigger > than

[pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-16 Thread morganamilo
[[ ${array[@]} ]] will resolve to false if array only contains empty strings. This means that values such as "depends=('')" can be inserted into a pkgbuild and bypass the linting. This causes makepkg to successfully build the package while pacman refuses to install it because of the unmet