Re: [pacman-dev] [PATCH] pacman/pacman-conf: -i/--is-set switch, returns 0 if option set

2019-09-10 Thread Eli Schwartz
On 9/10/19 2:32 PM, Matthew Sexton wrote: > Returns 1 if option not set. Returns 1 with error to stderr if > flag does not exist. Case insensitive. As discussed on IRC, it seems like this may be easier and more reliable to achieve by using exit statuses. Instead of exiting 1 on a missing flag,

Re: [pacman-dev] [PATCH] pacman/pacman-conf: -i/--is-set switch, returns 0 if option set

2019-09-10 Thread Matthew Sexton
On Tuesday, September 10, 2019 2:32:03 PM EDT you wrote: > Returns 1 if option not set. Returns 1 with error to stderr if > flag does not exist. Case insensitive. > > Signed-off-by: Matthew Sexton > --- > src/pacman/pacman-conf.c | 44 ++-- > 1 file changed,

[pacman-dev] [PATCH] pacman/pacman-conf: -i/--is-set switch, returns 0 if option set

2019-09-10 Thread Matthew Sexton
Returns 1 if option not set. Returns 1 with error to stderr if flag does not exist. Case insensitive. Signed-off-by: Matthew Sexton --- src/pacman/pacman-conf.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/src/pacman/pacman-conf.c

Re: [pacman-dev] [PATCH 2/4] libalpm: resolvedep(): don't compare names twice

2019-09-10 Thread Andrew Gregory
On 09/08/19 at 10:45pm, morganamilo wrote: > If we failed to get the pkg from pkgcache then we know no satisfying > package exists by name. So only compare provides. > --- > lib/libalpm/deps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/libalpm/deps.c

Re: [pacman-dev] [PATCH] pacman: better handle -F when file is not found

2019-09-10 Thread Andrew Gregory
On 09/09/19 at 05:49pm, morganamilo wrote: > Error messages are now printed. > Pacman now returns 1 if any of the files queried are not found. > --- > src/pacman/files.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/pacman/files.c

Re: [pacman-dev] [PATCH v2 1/2] pacman/pacman-conf: removed hputs macro for usage display

2019-09-10 Thread Matthew Sexton
On Tuesday, September 10, 2019 7:32:46 AM EDT you wrote: > On 10/9/19 7:33 pm, Matthew Sexton wrote: > > Signed-off-by: Matthew Sexton > > --- > > What changed in v2 apart from the disappearing commit message? > Nothing. My apologies. I wasn't thinking and just re-sent both patches when I

Re: [pacman-dev] [PATCH v2 1/2] pacman/pacman-conf: removed hputs macro for usage display

2019-09-10 Thread Allan McRae
On 10/9/19 7:33 pm, Matthew Sexton wrote: > Signed-off-by: Matthew Sexton > --- What changed in v2 apart from the disappearing commit message? > src/pacman/pacman-conf.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Matthew Sexton
On Tuesday, September 10, 2019 6:42:01 AM EDT Jan Alexander Steffens wrote: > On Tue, Sep 10, 2019, 12:17 Morten Linderud wrote: > > If you turn it around and add a list instead? > > > > HilightRepositories = testing community-testing > > You could give each [repo] a Color= setting. That seems

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Jan Alexander Steffens
On Tue, Sep 10, 2019, 12:17 Morten Linderud wrote: > If you turn it around and add a list instead? > > HilightRepositories = testing community-testing > You could give each [repo] a Color= setting. >

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Morten Linderud
On Tue, Sep 10, 2019 at 06:04:54AM -0400, Matthew Sexton wrote: > On Tuesday, September 10, 2019 5:57:19 AM EDT Morgan Adamiec wrote: > > Pacman is a general Linux package manager and not specific to Arch > > Linux. testing and community-testing are specific to Arch Linux. > > I struggled with

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Matthew Sexton
On Tuesday, September 10, 2019 5:57:19 AM EDT Morgan Adamiec wrote: > Pacman is a general Linux package manager and not specific to Arch > Linux. testing and community-testing are specific to Arch Linux. I struggled with whether to share this patch or not, because my motivation was pure

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Morgan Adamiec
On Tue, 10 Sep 2019 at 10:54, Matthew Sexton wrote: > > Only during Install/Upgrade, and not to verbosepkglist > > Signed-off-by: Matthew Sexton > --- > src/pacman/conf.c| 2 ++ > src/pacman/conf.h| 2 ++ > src/pacman/pacman-conf.c | 1 + > src/pacman/util.c| 20

[pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-09-10 Thread Matthew Sexton
Only during Install/Upgrade, and not to verbosepkglist Signed-off-by: Matthew Sexton --- src/pacman/conf.c| 2 ++ src/pacman/conf.h| 2 ++ src/pacman/pacman-conf.c | 1 + src/pacman/util.c| 20 4 files changed, 21 insertions(+), 4 deletions(-)

[pacman-dev] [PATCH v2 2/2] pacman/pacman-conf, testpkg: Added translatable strings

2019-09-10 Thread Matthew Sexton
From: Matthew Sexton Added gettext macro to warnings, helps, and errors for translation. Signed-off-by: Matthew Sexton --- Changes in v2: - Moved "Include" outside of gettext macro so it doesn't get localised src/pacman/pacman-conf.c | 44 +++-

[pacman-dev] [PATCH v2 1/2] pacman/pacman-conf: removed hputs macro for usage display

2019-09-10 Thread Matthew Sexton
Signed-off-by: Matthew Sexton --- src/pacman/pacman-conf.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index df874029..d9e596b8 100644 --- a/src/pacman/pacman-conf.c +++