Re: [pacman-dev] [PATCH 2/2] remove: Don't follow symlinks in checking if a file can be removed

2019-12-01 Thread Allan McRae
On 28/11/19 6:40 am, Ryan Gonzalez wrote: > Otherwise, symlinks to non-removable files will be logged as unable to > be removed. > > Signed-off-by: Ryan Gonzalez > --- > lib/libalpm/remove.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/libalpm/remove.c b/lib/liba

Re: [pacman-dev] [PATCH 1/3] libmakepkg: use extraction commands instead of file to find archive type

2019-12-01 Thread Allan McRae
On 27/11/19 7:29 am, Ethan Sommer wrote: > Previously, to determine which command we should use to extract an > archive, we would run file and match the output against our list of > possible extraction commands > > Instead, run the archive through each extraction command's -t (--test) > flag, if t

Re: [pacman-dev] [PATCH v2] pacman: print error when -Fx is given invalid regex

2019-12-01 Thread Allan McRae
On 28/11/19 3:45 am, morganamilo wrote: > When processing the targets for -Fx, compile all the regex ahead of > time, printing an error for each that failed to compile. Then, if they all > compiled successfully, continue with printing files. > > Signed-off-by: morganamilo > >