[pacman-dev] [PATCH 1/2] libalpm: const annotate struct pkg_operations

2020-12-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- lib/libalpm/be_local.c | 2 +- lib/libalpm/be_package.c | 2 +- lib/libalpm/be_sync.c| 20 ++-- lib/libalpm/package.c| 2 +- lib/libalpm/package.h| 4 ++-- 5 files changed, 23 insertions(+), 7 deletions(-) diff --git a/lib

[pacman-dev] [PATCH 2/2] libalpm: const annotate struct db_operations

2020-12-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- lib/libalpm/be_local.c | 2 +- lib/libalpm/db.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 9c3c8bb3..1d7748d5 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c

[pacman-dev] [PATCH 1/3] meson: replace objects with link_whole

2020-12-23 Thread Emil Velikov
Instead extracting/listing objects from existing static libraries, simply add those to the link list. Note that link_whole is needed otherwise, unused code will be pruned. Signed-off-by: Emil Velikov --- meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

[pacman-dev] [PATCH 2/3] meson: pacman-conf add missing libcommon link

2020-12-23 Thread Emil Velikov
Currently, we are erroneously exporting all the symbols via the libalpm.so. As such, the libcommon dependency is resolved. The libalpm.so exports are about to be resolved shortly, yet that exposed that pacman-conf is missing a link against libcommon. Signed-off-by: Emil Velikov --- meson.build

[pacman-dev] [PATCH 3/3] meson: use hidden symbol visiblity by default

2020-12-23 Thread Emil Velikov
All the required public API is annotated with SYMEXPORT, so we can just add the meson notation, to hide all the symbols by default. Thus we no longer spill all the internal API into the global namespace. Signed-off-by: Emil Velikov --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff

[pacman-dev] [PATCH 1/3] Remove pre libarchive 3.0 code

2020-12-23 Thread Emil Velikov
Pacman has required libarchive 3.0 or later for quite some time mow. Signed-off-by: Emil Velikov --- lib/libalpm/libarchive-compat.h | 20 1 file changed, 20 deletions(-) diff --git a/lib/libalpm/libarchive-compat.h b/lib/libalpm/libarchive-compat.h index 0ff005ae

[pacman-dev] [PATCH 2/3] Move hex_representation() to src/common

2020-12-23 Thread Emil Velikov
We'll reuse the function in pacman with a later commit. Signed-off-by: Emil Velikov --- lib/libalpm/util.c | 24 src/common/util-common.c | 26 ++ src/common/util-common.h | 1 + 3 files changed, 27 insertions(+), 24 deletions(-)

[pacman-dev] [PATCH 3/3] pacman: add file checksum validation against mtree

2020-12-23 Thread Emil Velikov
: indentation is likely all over the place - first time I see ts=2 Signed-off-by: Emil Velikov --- src/pacman/check.c | 66 +- 1 file changed, 59 insertions(+), 7 deletions(-) diff --git a/src/pacman/check.c b/src/pacman/check.c index 02217d0f..083c547d

Re: [pacman-dev] [PATCH 1/3] meson: replace objects with link_whole

2020-12-24 Thread Emil Velikov
On Thu, 24 Dec 2020 at 00:57, Eli Schwartz wrote: > > On 12/23/20 5:42 PM, Emil Velikov wrote: > > Instead extracting/listing objects from existing static libraries, > > simply add those to the link list. Note that link_whole is needed > > otherwise, unused code w

Re: [pacman-dev] [PATCH 3/3] meson: use hidden symbol visiblity by default

2020-12-24 Thread Emil Velikov
On Thu, 24 Dec 2020 at 01:38, Eli Schwartz wrote: > > On 12/23/20 5:42 PM, Emil Velikov wrote: > > All the required public API is annotated with SYMEXPORT, so we can just > > add the meson notation, to hide all the symbols by default. > > > > Thus we no longer spill