[pacman-dev] [PATCH] makepkg: Pass --stream to `hg clone` when creating the working copy

2018-09-08 Thread Luke Shumaker
From: Luke Shumaker Without --stream, `hg clone` reencodes+recompresses the entire repository, to the storage settings of the host. But download_hg() already did that on the initial network clone, and it is 100% pointless duplicated work for the local clone. The work that this saves is CPU

Re: [pacman-dev] [PATCH] makepkg: Fix whirlpoolsums support

2018-08-27 Thread Luke Shumaker
ook like nettle supports whirlpool any more than base64. It should only need the openssl command-line tool if it's actually going to use whirlpool for a given PKGBUILD (i.e., and optdepend at best). -- Happy hacking, ~ Luke Shumaker

[pacman-dev] [PATCH] makepkg: Fix whirlpoolsums support

2018-08-27 Thread Luke Shumaker
From: Luke Shumaker Commit 9cdfd187 introduced support for whirlpool checksums in v5.0.0. However, it was sloppy and missed several places where the list of checksums is used. So fix that. In several places, we can take advantage of the 'known_hash_algos' variable to simplify things a bit

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Luke Shumaker
pkgver); then error_function pkgver fi -- Happy hacking, ~ Luke Shumaker

[pacman-dev] [PATCH] makepkg: Handle errors when canonicalizing paths

2018-08-09 Thread Luke Shumaker
From: Luke Shumaker If you don't have adequate permission to `cd` to one of the DEST directories, it's clear that that something's not doing error handling right: $ install -d -m srcdest $ SRCDEST=$PWD/srcdest makepkg /usr/share/makepkg/util/util.sh: line 75: cd: /.../srcdest

[pacman-dev] [PATCH v2 2/3] makepkg: check_pkgrel: Don't say "decimal" in the error message

2018-08-09 Thread Luke Shumaker
From: Luke Shumaker If you have a malformed pkgrel, the error message says that it must be a "decimal". That isn't quite true, as that would mean that `1.1 == 1.10`. --- scripts/libmakepkg/lint_pkgbuild/pkgrel.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pacman-dev] [PATCH v2 3/3] makepkg: check_pkgver: Report what the bad pkgver is

2018-08-09 Thread Luke Shumaker
From: Luke Shumaker For consistency with check_epoch and check_pkgrel. I think that this is important because if there are multiple provides/depends/whatever that include a version, and one of them is malformed, including the bad version in the error message identified which one is the problem

[pacman-dev] [PATCH v2 1/3] makepkg: Better error messages for versions in (check, make, opt)depends/provides/conflicts

2018-08-09 Thread Luke Shumaker
From: Luke Shumaker Given the depends depends=('foo>=1.2-1.par2') and the error message ==> ERROR: pkgver in depends is not allowed to contain colons, forward slashes, hyphens or whitespace. One would be lead to believe that the problem is that they gave a pkgrel in depends

[pacman-dev] [PATCH v2 0/3] makepkg: Improve lint_pkgbuild error messages for epoch/ver/rel

2018-08-09 Thread Luke Shumaker
From: Luke Shumaker The error messages that makepkg prints when encountering a bad epoch/pkgver/pkgrel are often somewhat misleading. These patchset tries to improve that. The behavior is intended to be unchanged, other than what the messages say. v2: - Don't skip lint_pkgrel

Re: [pacman-dev] [PATCH 1/3] makepkg: Better error messages for versions in (check, make, opt)depends/provides/conflicts

2018-08-07 Thread Luke Shumaker
On Wed, 08 Aug 2018 00:05:25 -0400, Eli Schwartz wrote: > > On 08/07/2018 11:16 PM, Luke Shumaker wrote: > > +check_fullpkgver() { > > + local fullver=$1 type=$2 > > + local ret=0 > > + > > + # If there are multiple colons or multiple hyphens, there's

[pacman-dev] [PATCH 1/3] makepkg: Better error messages for versions in (check, make, opt)depends/provides/conflicts

2018-08-07 Thread Luke Shumaker
From: Luke Shumaker Given the depends depends=('foo>=1.2-1.par2') and the error message ==> ERROR: pkgver in depends is not allowed to contain colons, forward slashes, hyphens or whitespace. One would be lead to believe that the problem is that they gave a pkgrel in depends

[pacman-dev] [PATCH 3/3] makepkg: check_pkgver: Report what the bad pkgver is

2018-08-07 Thread Luke Shumaker
From: Luke Shumaker For consistency with check_epoch and check_pkgrel. I think that this is important because if there are multiple provides/depends/whatever that include a version, and one of them is malformed, including the bad version in the error message identified which one is the problem

[pacman-dev] [PATCH 0/3] makepkg: Improve lint_pkgbuild error messages for epoch/ver/rel

2018-08-07 Thread Luke Shumaker
From: Luke Shumaker The error messages that makepkg prints when encountering a bad epoch/pkgver/pkgrel are often somewhat misleading. These patchset tries to improve that. The behavior is intended to be unchanged, other than what the messages say. Luke Shumaker (3): makepkg: Better error

[pacman-dev] [PATCH 2/3] makepkg: check_pkgrel: Don't say "decimal" in the error message

2018-08-07 Thread Luke Shumaker
From: Luke Shumaker If you have a malformed pkgrel, the error message says that it must be a "decimal". That isn't quite true, as that would mean that `1.1 == 1.10`. --- scripts/libmakepkg/lint_pkgbuild/pkgrel.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [pacman-dev] [PATCH v2 1/3] configure: bump the minimum version of bash to 4.4

2018-07-11 Thread Luke Shumaker
On Tue, 19 Jun 2018 16:26:33 -0400, Eli Schwartz wrote: > This is required in order to use declare -g and ${var@a} Huh? It's needed for @a, but wasn't `declare -g` in Bash 4.2? -- Happy hacking, ~ Luke Shumaker

[pacman-dev] [PATCH] pacman.conf: Fixup the XferCommand example for curl

2018-06-03 Thread Luke Shumaker
From: Luke Shumaker 1. Without `-L`, curl doesn't follow redirects. This is different than both the default behavior of pacman, and from the wget example. So add `-L`. 2. It uses `-C -` to supposedly allow resuming partial downloads; but that doesn't work if we use `>

[pacman-dev] [PATCH] makepkg: Treat pkgrel more similarly to pkgver

2018-06-03 Thread Luke Shumaker
From: Luke Shumaker This is perfectly fine with libalpm; it was only makepkg that was more strict with pkgrel than pkgver. Further, the former error message about invalid pkgrel formats claimed that pkgrel was a "decimal", which would mean that `1.1 == 1.10`. This is not the case; a

[pacman-dev] [PATCH] makepkg: treat pkgrel more similarly to pkgver

2014-08-29 Thread Luke Shumaker
This is perfectly fine with libalpm; it was only makepkg that was more strict with pkgrel than pkgver. Further, the former error message about invalid pkgrel formats claimed that pkgrel was a decimal, which would mean that `1.1 == 1.10`. This was not the case; alpm parsed pkgrel as a version,

Re: [pacman-dev] [PATCH] makepkg: treat pkgrel more similarly to pkgver

2014-08-29 Thread Luke Shumaker
At Fri, 29 Aug 2014 17:16:11 -0500, Dan McGee wrote: On Fri, Aug 29, 2014 at 1:07 PM, Luke Shumaker luke...@sbcglobal.net wrote: This is perfectly fine with libalpm; it was only makepkg that was more strict with pkgrel than pkgver. Correct. However, did you look at the NEWS file

[pacman-dev] [PATCH 0/3] makepkg: Alternate implementation of VCS URLs in sources array.

2012-08-25 Thread Luke Shumaker
is that it does allow for integrity checks of VCS packages, rather than inserting 'SKIP' into the md5sums array. This is very important to the derivative distribution Parabola. (However, the 'SKIP' option is still valuable for URLs that track a branch) Happy hacking, ~ Luke Shumaker Luke Shumaker (3): Add

[pacman-dev] [PATCH 1/3] Add a `vcsget` tool to download source from VCS repositories.

2012-08-25 Thread Luke Shumaker
It would support * cvs * git * svn * bzr * hg But cvs support is yet to be written, and bzr support is half-way written. Git is the only mode that I'm thoroughly confident in, the others need testing. Signed-off-by: Luke Shumaker luke...@sbcglobal.net --- scripts/.gitignore | 1

[pacman-dev] [PATCH 2/3] makepkg: do glob expansion in DLAGENTS maps

2012-08-25 Thread Luke Shumaker
This allows vcs-* schemes to be used for vcsget. Signed-off-by: Luke Shumaker luke...@sbcglobal.net --- scripts/makepkg.sh.in | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index b30e9d0..f2a5008 100644

[pacman-dev] [PATCH 2/3] makepkg: do glob expansion in DLAGENTS maps

2012-08-25 Thread Luke Shumaker
This allows vcs-* schemes to be used for vcsget. Signed-off-by: Luke Shumaker luke...@sbcglobal.net --- scripts/makepkg.sh.in | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index b30e9d0..f2a5008 100644

[pacman-dev] [PATCH 3/3] makepkg.conf: add vcsget DLAGENTS

2012-08-25 Thread Luke Shumaker
Signed-off-by: Luke Shumaker luke...@sbcglobal.net --- etc/makepkg.conf.in | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index dcec6f5..7d19dfb 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -12,7 +12,13