Re: [pacman-dev] [PATCH 01/13] Simplify sync_cleandb

2015-06-20 Thread brainpower
erything in dbpath/ except local/, sync/ and db.lck, > and > - * only the unused sync dbs in dbpath/sync/ */ > - ret += sync_cleandb(dbpath, 0); > > - if(asprintf(&newdbpath, "%s%s", dbpath, "sync/") < 0) { > + if(asprintf(&syncdbpath, "%s%s", dbpath, "sync/") < 0) { > ret += 1; > return ret; > } > - ret += sync_cleandb(newdbpath, 1); > - free(newdbpath); > + ret += sync_cleandb(syncdbpath); > + free(syncdbpath); > > return ret; > } > -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH] Update NEWS for pacman-5.0.1

2016-02-23 Thread brainpower
+ - contrib: > +- zsh_completion: updated makepkg options > 5.0.0 - pacman can run hooks pre- and post-transaction. See the > alpm-hooks(5) man page for details and an example hook > (FS#2985) > - pacman can now sync and

Re: [pacman-dev] [PATCH 1/1] add command line options for libcurl's "low speed" timeout

2016-11-13 Thread brainpower
{"ignoregroup", required_argument, 0, OP_IGNOREGROUP}, > {"needed", no_argument, 0, OP_NEEDED}, > + {"lowspeedlimit", required_argument, 0, OP_LOWSPEEDLIMIT}, > + {"lowspeedtime", required_argument, 0, OP_LOWSPEEDTIME}, > {"asexplicit", no_argument, 0, OP_ASEXPLICIT}, > {"arch", required_argument, 0, OP_ARCH}, > {"print-format", required_argument, 0, OP_PRINTFORMAT}, > -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH 1/1] add command line options for libcurl's "low speed" timeout

2016-11-13 Thread brainpower
On 14.11.2016 00:33, brainpower wrote: > Hi, > > On 30.08.2016 15:16, Christian Hesse wrote: Ah, sorry didn'T notice this was quite old, sorry for the noise. My mail client sorted it between all the new messages. -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH 4/4] add basic makepkg test

2017-02-25 Thread brainpower
; +TMPDIR="$(mktemp -d --tmpdir "${0##*/}.XX")" > +trap "rm -rf '${TMPDIR}'" EXIT TERM > + > +tap_note "basic package building test" > +tap_note "testing '%s'" "$script" > +tap_note "using test dir '%s'" "$TMPDIR" > + > +( > + set -e > + cd "$TMPDIR" > + cat >PKGBUILD <<-'PKGBUILD' > + pkgname=foo > + pkgver=1 > + pkgrel=1 > + arch=(any) > + package() { > + touch "$pkgdir/!first" > + touch "$pkgdir/target" > + ln -s target "$pkgdir/link" > + mkdir "$pkgdir/dir" > + touch "$pkgdir/dir/.dotfile" > + } > + PKGBUILD > + MAKEPKG_CONF="/dev/null" PKGEXT=".pkg.tar" $script > +) |& tap_filter > +[[ $? -eq 0 ]] || tap_xbail "test setup failed" > + > +pkgfile="$TMPDIR/foo-1-1-any.pkg.tar" > + > +tap_plan 10 > +tap_ar_is_file "$pkgfile" "!first" "pkg contains !first" > +tap_ar_is_file "$pkgfile" "target" "pkg contains target" > +tap_ar_is_file "$pkgfile" "dir/.dotfile" "pkg contains dir/.dotfile" > +tap_ar_is_link "$pkgfile" "link" "target" "pkg contains link to target" > +tap_ar_is_owner "$pkgfile" "target" "0" "target owner is root" > +tap_ar_is_group "$pkgfile" "target" "0" "target group is root" > + > +tap_eval "! bsdtar -tf '$pkgfile' | grep -qE '^\\.?\\.?/'" \ > + "package paths are relative without leading dot dirs" > +tap_eval "bsdtar -tf '$pkgfile' | grep -v '^\\.' | LANG=C sort -Cu" \ > + "package files are sorted" > +tap_eval "bsdtar -tf '$pkgfile' | LANG=C sort | LANG=C sort -Cu" \ > + "package files are unique" > +tap_eval "bsdtar -tf '$pkgfile' | head -n1 | grep -q '^\\.'" \ > + "db files are placed at the beginning of the package" > + > +tap_finish > diff --git a/test/makepkg/tests/util-pkgbuild.sh > b/test/makepkg/tests/util-pkgbuild.sh > new file mode 100755 > index ..3fd970c8 > --- /dev/null > +++ b/test/makepkg/tests/util-pkgbuild.sh > @@ -0,0 +1,35 @@ > +#!/bin/bash > + > +source "$(dirname "$0")"/../test_functions.sh || exit 1 > + > +tap_note "testing libmakepkg/util/pkgbuild.sh" > + > +source_libmakepkg_file 'util/pkgbuild.sh' > + > +test_foo() { > + myarray=(foo bar) > + myarray+=(baz) > + #myarray+=(this should be ignored) > + myscalar=baz > + myscalar=quux > + #myscalar=ignored > +} > + > +declare -a oarray > +declare oscalar > + > +tap_plan 9 > + > +tap_eval 'have_function test_foo' 'detected existing function test_foo' > +tap_eval '! have_function test_bar' 'detected missing function test_bar' > + > +tap_eval 'extract_function_variable test_foo myarray 1 oarray' 'extract > array variable' > +tap_is_int "${#oarray[@]}" 3 'extracted array length' > +tap_is_str "${oarray[0]}" 'foo' 'extracted array contents' > +tap_is_str "${oarray[1]}" 'bar' 'extracted array contents' > +tap_is_str "${oarray[2]}" 'baz' 'extracted array contents' > + > +tap_eval 'extract_function_variable test_foo myscalar 0 oscalar' 'extract > scalar variable' > +tap_is_str "$oscalar" 'quux' 'extracted scalar value' > + > +tap_finish > -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] pacman sorting incompatible with 'sort' command

2017-05-05 Thread brainpower
regardless of the systems locale... But I don't mind... PoC: $ pacman -Slq | grep '^i3' i3-wm i3blocks i3lock i3status $ pacman -Slq | grep '^i3' | LC_COLLATE=C sort i3-wm i3blocks i3lock i3status -- regards, brainpower

Re: [pacman-dev] Breaking change in pacman from 5.0.1 -> 5.0.2 with regards to user account resolution

2017-06-20 Thread brainpower
d the messages of that thread referenced in the commit linked in your message, especially that one: https://lists.archlinux.org/pipermail/pacman-dev/2017-March/021922.html , you'd know: Yes, this is expected behavior. -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH v2 1/2] makepkg: implement error codes

2017-09-20 Thread brainpower
uot;)" "$BUILDFILE" > - exit 1 > + exit $E_BUILD_FAILED=5 Small thing everyone seems to have overlooked: This line looks wrong to me. bash probably won't like it either. ;) -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] Alternatives system

2019-04-04 Thread brainpower
ndled by pacman alone, instead of needing a helper like archlinux-java? (Or does that helper do anything, alternatives couldn't handle?) -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] Alternatives system brainstorm

2019-10-18 Thread brainpower
as pacman informs me about any change it makes and not silently changes an alternative, I'll be happy. The only thing I'd feel strongly about some automatic choosing is, that I think a manual selection should not be changed automagically. For example, if I have python2 and python3 installed, then manually set python to python2 and after that install python4 at some point, python should stay at python2 no matter how high python4's priority is because python2 was selected manually. -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] Alternatives system brainstorm

2019-10-24 Thread brainpower
then adding all the alternatives to the repo's db... though this could be done separately like the files.db? Then a `pacman -Ays python` could print all providers of python, like python3, python2, python4, python-from-third-party-repo So at this point I'd prefer the original proposal over Daan's latest, after we've bikeshedded the '->' of course. ;) > Allan > -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH 2/2] Use c99 struct initialization to avoid memset calls

2019-12-27 Thread brainpower
7 @@ static int sync_db_read(alpm_db_t *db, struct archive > *archive, -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH 1/2] Add config option to specify amount of concurrent download streams

2020-03-04 Thread brainpower
ts to 3. Check errno for ERANGE, it gets set if the integer given does not fit into a long 4. Now use the number. Check range again, if you want to downcast the long to int. [1]: https://en.cppreference.com/w/c/string/byte/strtol -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] [PATCH 1/2] Add config option to specify amount of concurrent download streams

2020-03-04 Thread brainpower
Am 04.03.20 um 23:32 schrieb brainpower: > Hi! > > Am 04.03.20 um 22:29 schrieb Anatol Pomozov: >> On Wed, Mar 4, 2020 at 12:39 PM Anatol Pomozov >> wrote: >>> + } else if(strcmp(key, "ConcurrentDownloadStreams") == 0) { >>> +

Re: [pacman-dev] [PATCH 1/2] Add config option to specify amount of concurrent download streams

2020-03-04 Thread brainpower
Am 04.03.20 um 23:40 schrieb brainpower: > Am 04.03.20 um 23:32 schrieb brainpower: >> Hi! >> >> Am 04.03.20 um 22:29 schrieb Anatol Pomozov: >>> On Wed, Mar 4, 2020 at 12:39 PM Anatol Pomozov >>> wrote: >>>> + } el

[pacman-dev] Setting HOME in build() breaks package signing

2020-05-05 Thread brainpower
UILD?h=intel-opencl-sdk&id=a426e7bc370edea770037b6ed61e22701e8a0397#n38 -- regards, brainpower signature.asc Description: OpenPGP digital signature

Re: [pacman-dev] Setting HOME in build() breaks package signing

2020-05-07 Thread brainpower
Am 05.05.20 um 22:40 schrieb Eli Schwartz: > On 5/5/20 4:11 PM, brainpower wrote: > [...] > >> This made me wonder: >> Is this something makepkg should take care of (e.g.by restoring $HOME after >> build() or ensuring gpg will use $OLDHOME/.gnupg) >> or sho