[pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-02 Thread jhuntwork
From: Jeremy Huntwork Allow makepkg to work correctly when used with find from busybox. The switches -empty, -samefile and -lname are not available. It is easy to work around -empty with rmdir, and -lname with readlink. However, -samefile functionality requires tracking and storing inodes to ensu

[pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread jhuntwork
From: Jeremy Huntwork This is an updated version to the previous patch which had a misplaced -o option and a misformatted line. Allow makepkg to work correctly when used with find from busybox. The switches -empty, -samefile and -lname are not available. It is easy to work around -empty with rmd

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Dave Reisner
On Thu, May 03, 2012 at 03:29:08AM -0400, jhuntw...@lightcubesolutions.com wrote: > From: Jeremy Huntwork > > This is an updated version to the previous patch which had a misplaced -o > option and a misformatted line. > > Allow makepkg to work correctly when used with find from busybox. The swi

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Jeremy Huntwork
On 5/3/12 6:16 AM, Dave Reisner wrote: I'm hard pressed to believe that this is the only place we choke on busybox's "coreutils". We have other, more complete and more sane userspaces which we need to support, and this patch does not honor that. There may very well be other places that choke, b

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Jeremy Huntwork
On 5/3/12 6:16 AM, Dave Reisner wrote: if check_option "emptydirs" "n"; then msg2 "$(gettext "Removing empty directories...")" - find . -depth -type d -empty -delete + find . -depth -mindepth 1 -type d -exec rmdir --ignore-fail-on-non-empty '{}

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Allan McRae
On 04/05/12 09:12, Jeremy Huntwork wrote: > On 5/3/12 6:16 AM, Dave Reisner wrote: >>> if check_option "emptydirs" "n"; then >>> msg2 "$(gettext "Removing empty directories...")" >>> -find . -depth -type d -empty -delete >>> +find . -depth -mindepth 1 -type d -exec r

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Jeremy Huntwork
On 5/3/12 7:34 PM, Allan McRae wrote: On 04/05/12 09:12, Jeremy Huntwork wrote: find . -mindepth 1 -depth -type d -exec rmdir "{}" + 2>/dev/null || true Anything else is a lot more code and more cumbersome. If the || true in this instance is unacceptable, then I will probably just submit the ch

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Dave Reisner
On Thu, May 03, 2012 at 07:40:03PM -0400, Jeremy Huntwork wrote: > On 5/3/12 7:34 PM, Allan McRae wrote: > >On 04/05/12 09:12, Jeremy Huntwork wrote: > >>find . -mindepth 1 -depth -type d -exec rmdir "{}" + 2>/dev/null || true > >> > >>Anything else is a lot more code and more cumbersome. If the ||

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Allan McRae
On 04/05/12 09:40, Jeremy Huntwork wrote: > On 5/3/12 7:34 PM, Allan McRae wrote: >> On 04/05/12 09:12, Jeremy Huntwork wrote: >>> find . -mindepth 1 -depth -type d -exec rmdir "{}" + 2>/dev/null || true >>> >>> Anything else is a lot more code and more cumbersome. If the || true in >>> this instan

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Jeremy Huntwork
On 5/3/12 7:44 PM, Allan McRae wrote: Please work from the master branch where "-e" does not exist anymore... Ah, thanks - I was working on master but didn't notice that change, nor realize what Dave meant regarding it being 'not wanted'. I'll submit the full patch shortly. Thanks, JH