[pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-20 Thread andrew . gregory . 8
From: Andrew Gregory Not allowing fileowner queries for directories was an unnecessary limitation. Queries for directories have poor performance due to having to call real_path on every directory listed in every package's file list. Because more than one package will likely own a given director

[pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-20 Thread andrew . gregory . 8
From: Andrew Gregory Not allowing fileowner queries for directories was an unnecessary limitation. Queries for directories have poor performance due to having to call real_path on every directory listed in every package's file list. Because more than one package will likely own a given director

[pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-22 Thread andrew . gregory . 8
From: Andrew Gregory Removed restriction on querying the owner of a directory. Replaced mbasename and mdirname with pbasename and pdirname, similar to their POSIX namesakes except that they do not modify path, subsequent calls do not modify previous return values, and the returned values need to

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-20 Thread Dave Reisner
On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com wrote: > From: Andrew Gregory > > Not allowing fileowner queries for directories was an unnecessary > limitation. Queries for directories have poor performance due to > having to call real_path on every directory listed in ever

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-20 Thread Andrew Gregory
On Sun, 20 Nov 2011 12:39:11 -0500 Dave Reisner wrote: > On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com > wrote: > > From: Andrew Gregory > > > > Not allowing fileowner queries for directories was an unnecessary > > limitation. Queries for directories have poor performa

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-20 Thread Dave Reisner
On Sun, Nov 20, 2011 at 01:07:14PM -0500, Andrew Gregory wrote: > On Sun, 20 Nov 2011 12:39:11 -0500 > Dave Reisner wrote: > > > On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com > > wrote: > > > From: Andrew Gregory > > > > > > Not allowing fileowner queries for directorie

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-21 Thread Dan McGee
On Sun, Nov 20, 2011 at 3:03 PM, wrote: > From: Andrew Gregory > > Not allowing fileowner queries for directories was an unnecessary > limitation.  Queries for directories have poor performance due to > having to call real_path on every directory listed in every package's > file list.  Because m

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-22 Thread Andrew Gregory
Think I've got it all worked out now. Replaced mdirname and mbasename with posix equivalent (but safer) functions. Directories no longer need to be treated any differently than files other than setting searchall. I'd like to suggest one more time that we go ahead and search all packages for file

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-11-22 Thread Dan McGee
On Tue, Nov 22, 2011 at 10:57 AM, Andrew Gregory wrote: > Think I've got it all worked out now.  Replaced mdirname and mbasename > with posix equivalent (but safer) functions.  Directories no longer > need to be treated any differently than files other than setting > searchall.  I'd like to sugges

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

2011-12-22 Thread Andrew Gregory
On Tue, Nov 22, 2011 at 8:12 PM, wrote: > From: Andrew Gregory > > Removed restriction on querying the owner of a directory. > Replaced mbasename and mdirname with pbasename and pdirname, > similar to their POSIX namesakes except that they do not > modify path, subsequent calls do not modify pre