[pacman-dev] [PATCH] makepkg: guard against undefined git pinned sources

2020-05-25 Thread Eli Schwartz
If something like source=(..."#commit=") is used, e.g. due to failed variable expansion, we try to check out an empty refspec as nothing at all, and end up just running "git checkout". This happens because we fail at variable expansion too -- so let's quote our variables properly and make sure git

Re: [pacman-dev] [PATCH] makepkg: guard against undefined git pinned sources

2020-06-10 Thread Allan McRae
On 26/5/20 1:52 pm, Eli Schwartz wrote: > If something like source=(..."#commit=") is used, e.g. due to failed > variable expansion, we try to check out an empty refspec as nothing at > all, and end up just running "git checkout". This happens because we > fail at variable expansion too -- so let's

Re: [pacman-dev] [PATCH] makepkg: guard against undefined git pinned sources

2020-06-10 Thread Eli Schwartz
On 6/10/20 8:51 PM, Allan McRae wrote: > On 26/5/20 1:52 pm, Eli Schwartz wrote: >> If something like source=(..."#commit=") is used, e.g. due to failed >> variable expansion, we try to check out an empty refspec as nothing at >> all, and end up just running "git checkout". This happens because we