[pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false positives with binary files (in particular with debugging symbols kept). Restrict the search for $srcdir to non-binary files as this should still catch the majority of configuration is

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Marc - A. Dahlhaus
Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: > The checking of the package for $srcdir references was overly > sensitive and gave a lot of what appear to be false positives with > binary files (in particular with debugging symbols kept). > > Restrict the search for $srcdir to non-

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false positives with binary files (in particular with debugging symbols kept). R

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Nathan Wayde
On 29/09/10 13:35, Allan McRae wrote: On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false positives with binary files (in part

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
On 29/09/10 22:41, Nathan Wayde wrote: On 29/09/10 13:35, Allan McRae wrote: On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be fa

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Dan McGee
On Wed, Sep 29, 2010 at 7:51 AM, Allan McRae wrote: > On 29/09/10 22:41, Nathan Wayde wrote: >> >> On 29/09/10 13:35, Allan McRae wrote: >>> >>> On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: > > The checking of the pack

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Nathan Wayde
On 29/09/10 13:51, Allan McRae wrote: [...] just pipe it through xargs, something like `find "${pkgdir}" -type f -print0 | xargs -0 grep -m 1 -q "${pkgdir}"` Doesn't that suffer from the same issue with potentially exceeding the maximum number of parameters? no, the list is passed in via t

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Jonathan Conder
On 30/09/10 01:35, Allan McRae wrote: On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false positives with binary files (in par

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
On 29/09/10 23:31, Jonathan Conder wrote: On 30/09/10 01:35, Allan McRae wrote: On 29/09/10 22:06, Marc - A. Dahlhaus wrote: Am Mittwoch, den 29.09.2010, 21:59 +1000 schrieb Allan McRae: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Loui Chang
On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: > The checking of the package for $srcdir references was overly > sensitive and gave a lot of what appear to be false positives with > binary files (in particular with debugging symbols kept). > > Restrict the search for $srcdir to non-binary file

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
On 30/09/10 11:56, Loui Chang wrote: On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false positives with binary files (in particular with debugging symbols kept). Restrict the search

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Loui Chang
On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote: > On 30/09/10 11:56, Loui Chang wrote: > >On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: > >>The checking of the package for $srcdir references was overly > >>sensitive and gave a lot of what appear to be false positives with > >>binary files (

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Allan McRae
On 30/09/10 12:26, Loui Chang wrote: On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote: On 30/09/10 11:56, Loui Chang wrote: On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: The checking of the package for $srcdir references was overly sensitive and gave a lot of what appear to be false posi

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-09-29 Thread Dan McGee
On Wed, Sep 29, 2010 at 9:26 PM, Loui Chang wrote: > On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote: >> On 30/09/10 11:56, Loui Chang wrote: >> >On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: >> >>The checking of the package for $srcdir references was overly >> >>sensitive and gave a lot of

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-10-01 Thread Loui Chang
On Thu 30 Sep 2010 12:38 +1000, Allan McRae wrote: > On 30/09/10 12:26, Loui Chang wrote: > >On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote: > >>On 30/09/10 11:56, Loui Chang wrote: > >>>On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: > The checking of the package for $srcdir references w

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-10-01 Thread Dan McGee
On Fri, Oct 1, 2010 at 7:27 PM, Loui Chang wrote: > On Thu 30 Sep 2010 12:38 +1000, Allan McRae wrote: >> On 30/09/10 12:26, Loui Chang wrote: >> >On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote: >> >>On 30/09/10 11:56, Loui Chang wrote: >> >>>On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote: >

Re: [pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

2010-10-02 Thread Nathan Wayde
On 02/10/10 02:08, Dan McGee wrote: [...] One thought I did have, and this is just a thought, is to store $pkgdir and $srcdir in the built package in PKGINFO as a way to use these values later. -Dan I would advise against storing it in the PKGINFO if it means that it ends up in the final bu