[pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Eli Schwartz
`run_function_safe pkgver` is evaluated in a subshell and therefore does not abort when it should. Explicitly check the return outside of the subshell and abort if necessary. Signed-off-by: Eli Schwartz --- scripts/makepkg.sh.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/make

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Luke Shumaker
On Mon, 13 Aug 2018 21:20:58 -0400, Eli Schwartz wrote: > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in > index bb24c633..1ab2ea3c 100644 > --- a/scripts/makepkg.sh.in > +++ b/scripts/makepkg.sh.in > @@ -188,6 +188,9 @@ enter_fakeroot() { > # Re-sources the PKGBUILD afterwards to allo

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-13 Thread Eli Schwartz
On 8/13/18 10:13 PM, Luke Shumaker wrote: > On Mon, 13 Aug 2018 21:20:58 -0400, > Eli Schwartz wrote: >> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in >> index bb24c633..1ab2ea3c 100644 >> --- a/scripts/makepkg.sh.in >> +++ b/scripts/makepkg.sh.in >> @@ -188,6 +188,9 @@ enter_fakeroot(

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-28 Thread Allan McRae
On 14/08/18 11:20, Eli Schwartz wrote: > `run_function_safe pkgver` is evaluated in a subshell and therefore does > not abort when it should. Explicitly check the return outside of the > subshell and abort if necessary. > > Signed-off-by: Eli Schwartz > --- > scripts/makepkg.sh.in | 3 +++ > 1 f