Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Dan McGee
On Fri, Mar 9, 2012 at 9:01 AM, Dave Reisner d...@falconindy.com wrote: On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: Most places in makepkg deal with full file paths, but a few use the file name only.  Protect from potential issues when a file name starts with a hyphen. How

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Thomas Bächler
Am 09.03.2012 15:01, schrieb Dave Reisner: @@ -974,7 +974,7 @@ tidy_install() { if [[ $(check_option docs) = n -n ${DOC_DIRS[*]} ]]; then msg2 $(gettext Removing doc files...) -rm -rf ${DOC_DIRS[@]} +rm -rf -- ${DOC_DIRS[@]} i hate that we

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 04:40:38PM +0100, Thomas Bächler wrote: Am 09.03.2012 15:01, schrieb Dave Reisner: @@ -974,7 +974,7 @@ tidy_install() { if [[ $(check_option docs) = n -n ${DOC_DIRS[*]} ]]; then msg2 $(gettext Removing doc files...) - rm -rf

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Allan McRae
On 13/03/12 01:24, Dan McGee wrote: On Fri, Mar 9, 2012 at 9:01 AM, Dave Reisner d...@falconindy.com wrote: On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a file name starts with a hyphen. How sure are we that these will always be relative paths and never ever

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-09 Thread Allan McRae
On 10/03/12 00:01, Dave Reisner wrote: On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a file name starts with a hyphen. How sure are we that these will

[pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-08 Thread Allan McRae
Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a file name starts with a hyphen. Signed-off-by: Allan McRae al...@archlinux.org --- scripts/makepkg.sh.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)