Re: [pacman-dev] Mtree parsing v5

2014-02-13 Thread Allan McRae
On 14/02/14 13:29, Allan McRae wrote: > On 14/02/14 10:47, Allan McRae wrote: >> On 10/02/14 16:04, Allan McRae wrote: >>> On 10/02/14 05:24, Florian Pritz wrote: I hope I incorporated all suggestions. Most patches didn't change, but I'm submitting them anyway for an easier (hopefully fin

Re: [pacman-dev] Mtree parsing v5

2014-02-13 Thread Allan McRae
On 14/02/14 10:47, Allan McRae wrote: > On 10/02/14 16:04, Allan McRae wrote: >> On 10/02/14 05:24, Florian Pritz wrote: >>> I hope I incorporated all suggestions. Most patches didn't change, >>> but I'm submitting them anyway for an easier (hopefully final) review. >> >> Looks good from a quick re

Re: [pacman-dev] Mtree parsing v5

2014-02-13 Thread Allan McRae
On 10/02/14 16:04, Allan McRae wrote: > On 10/02/14 05:24, Florian Pritz wrote: >> I hope I incorporated all suggestions. Most patches didn't change, >> but I'm submitting them anyway for an easier (hopefully final) review. > > Looks good from a quick read to me, apart from that comment I made on

Re: [pacman-dev] Mtree parsing v5

2014-02-09 Thread Allan McRae
On 10/02/14 05:24, Florian Pritz wrote: > I hope I incorporated all suggestions. Most patches didn't change, > but I'm submitting them anyway for an easier (hopefully final) review. Looks good from a quick read to me, apart from that comment I made on the final patch. I'm low on time this week, s

[pacman-dev] Mtree parsing v5

2014-02-09 Thread Florian Pritz
I hope I incorporated all suggestions. Most patches didn't change, but I'm submitting them anyway for an easier (hopefully final) review.