[pacman-dev] alpm_list_remove_dups: was - [PATCH] Sort and avoid duplicates in -Sii output

2010-03-23 Thread Allan McRae
On 24/03/10 16:00, Allan McRae wrote: Signed-off-by: Allan McRae --- lib/libalpm/package.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index f1682cb..ed6d71d 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/pack

Re: [pacman-dev] alpm_list_remove_dups: was - [PATCH] Sort and avoid duplicates in -Sii output

2010-03-24 Thread Dan McGee
On Wed, Mar 24, 2010 at 1:09 AM, Allan McRae wrote: > On 24/03/10 16:00, Allan McRae wrote: >> >> Signed-off-by: Allan McRae >> --- >>  lib/libalpm/package.c |    5 - >>  1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c >> index

Re: [pacman-dev] alpm_list_remove_dups: was - [PATCH] Sort and avoid duplicates in -Sii output

2010-03-24 Thread Xavier Chantry
On Wed, Mar 24, 2010 at 3:32 PM, Dan McGee wrote: > > I'd rather have it not touch the original list. Even if it does modify > the list, freeing items from the list could be disastrous in the case > of packages or something, so that is a no-no. I could see it being a > more useful function if it t

Re: [pacman-dev] alpm_list_remove_dups: was - [PATCH] Sort and avoid duplicates in -Sii output

2010-03-24 Thread Nagy Gabor
I was going to use alpm_list_remove_dups instead of testing for a strings presence before adding it but I find that function quite impractical... I wonder if any other frontend is using it and whether we could change it to actually removing the duplicates from a list. i.e. return the same list w

Re: [pacman-dev] alpm_list_remove_dups: was - [PATCH] Sort and avoid duplicates in -Sii output

2010-03-24 Thread Xavier Chantry
On Wed, Mar 24, 2010 at 7:43 PM, Nagy Gabor wrote: >> I was going to use alpm_list_remove_dups instead of testing for a >> strings presence before adding it but I find that function quite >> impractical... >> >> I wonder if any other frontend is using it and whether we could change >> it to actual