On Mon, Jun 6, 2011 at 11:36 AM, Nagy Gabor ng...@bibl.u-szeged.hu wrote:
Patch looks fine to me but some minor comments :
1) just a matter of taste, I would reduce the number of levels with
if (prompt download)
install = 1
else if prompt
...
else
...
2) can we have downloadonly
Allan McRae wrote:
diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c
index c5fb92e..b03cd48 100644
--- a/lib/libalpm/deps.c
+++ b/lib/libalpm/deps.c
@@ -570,8 +570,12 @@ static pmpkg_t *resolvedep(pmdepend_t *dep, alpm_list_t
*dbs,
if(_alpm_pkg_should_ignore(pkg))
Patch looks fine to me but some minor comments :
1) just a matter of taste, I would reduce the number of levels with
if (prompt download)
install = 1
else if prompt
...
else
...
2) can we have downloadonly and prompt=0 ? do we want to print the warning in
that case ?
3) that patch
