Re: sort order lost when updating patches

On 16 May 16:03, Bjorn Helgaas wrote: > On Sat, May 14, 2016 at 7:21 AM, Len Brown wrote: > > On Wed, May 11, 2016 at 2:36 PM, Bjorn Helgaas wrote: > >> On Tue, Apr 5, 2016 at 11:27 AM, Bjorn Helgaas wrote: > >>> This is on

Re: [PATCHv2 09/10] REST: Add query parameters to filter patches by

On 10 May 17:39, Andy Doan wrote: > This adds generic filtering support to the PatchworkViewSet as well as > useful filtering options for listing patches. > > DRF has some filter capabilities, but they can really slow down the web > interface for large data sets and are a little complex. This

Re: [RFC 00/11] REST API support

On 10 May 17:30, Andy Doan wrote: > On 05/09/2016 09:16 AM, Finucane, Stephen wrote: > >On 15 Apr 13:23, Andy Doan wrote: > >>This patchset is inspired by the work done by Damien Lespiau. It creates > >>a REST API based on the original spec RFC'd by Stephen Finucane. The > >>only thing I know of

Re: [RFC 07/11] REST: Add Patch Checks to the API

On 12 May 14:04, Andy Doan wrote: > On 05/11/2016 03:57 AM, Finucane, Stephen wrote: > >On 10 May 17:30, Andy Doan wrote: > >>On 05/09/2016 08:58 AM, Finucane, Stephen wrote: > >>>On 15 Apr 13:24, Andy Doan wrote: > > +patches_router = NestedSimpleRouter(router, r'patches', lookup='patch') >

Re: [PATCHv2 10/10] REST: Allow projects to be retrieved by linkname

On 10 May 17:39, Andy Doan wrote: > Building a user-friendly CLI becomes difficult when project-ids are > required. It also makes it almost impossible to work with the current > format of the .pwclientrc file. > > Signed-off-by: Andy Doan Some comments below but nothing

Re: [PATCHv2 06/10] REST: Add Patch Checks to the API

On 17 May 14:14, Finucane, Stephen wrote: > On 10 May 17:39, Andy Doan wrote: > > This exports patch checks via the REST API. > > > > The drf-nested-routers package is used to handle the fact Checks are > > nested under a Patch. > > > > Security Constraints: > > * Anyone (logged in or not) can

Re: [PATCHv2 05/10] REST: Add Patches to the API

On 17 May 14:08, Finucane, Stephen wrote: > On 10 May 17:39, Andy Doan wrote: > > This exports patches via the REST API. > > supernit: s/exports/exposes :) > > > Security Constraints: > > * Anyone (logged in or not) can read all objects. > > * No one can create/delete objects. > > * Project

Re: [PATCHv2 08/10] REST API: make patch.state a string rather than int

On 10 May 17:39, Andy Doan wrote: > The int value isn't very useful and the goal is to move this to an enum > over time. > > Signed-off-by: Andy Doan Some questions over performance below. Stephen > --- > patchwork/rest_serializers.py| 21 - >

Re: [PATCHv2 07/10] REST: Add Patch.mbox_url

On 10 May 17:39, Andy Doan wrote: > Provide a URL to the raw patch. This removes previous functionality > added to create_model_serializer thats no longer needed. What functionality is removed? Are you referencing the previous patch? If so, don't bother :) > Signed-off-by: Andy Doan

Re: [PATCHv2 06/10] REST: Add Patch Checks to the API

On 10 May 17:39, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects.

Re: [PATCHv2 04/10] REST: Add Persons to the API

On 10 May 17:39, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Still unsure about including 'person.user.id'. See comment below. Stephen > --- >

Re: [PATCHv2 03/10] REST: Add Projects to the API

On 10 May 17:39, Andy Doan wrote: > This exports projects via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > Signed-off-by: Andy

Re: [PATCHv2 02/10] REST: Add base configuration hooks for a REST API

On 10 May 17:39, Andy Doan wrote: > This adds the ability to expose a REST API based on the Django REST > framework project. Since this project isn't packaged in most current > distributions, we ensure that its both installed and enabled before > trying to use it. > > Signed-off-by: Andy Doan