Re: [PATCH v2 5/6] Allow use of Docker for development

On 04/08/16 16:10, Daniel Axtens wrote: This makes it possible to use Docker and docker-compose for development as an alternative to Vagrant. I quite liked vagrant a couple of years ago, but currently: * Trying to install VirtualBox on Ubuntu wants me to disable Secure Boot, and I don't wan

Re: [PATCH v2 2/6] Fix test_login in test_user_browser.py

On 04/08/16 16:10, Daniel Axtens wrote: It tried to use the pbkdf2 hash as the password. Use the username instead, as that is what create_user sets. Then it compared the test user username to testuser, rather than the username, which is dynamically generated. Compare to the generated username.

Re: [PATCH v2 4/6] Put test db host and port into env variables.

On 04/08/16 16:10, Daniel Axtens wrote: This is preparation for a Docker-based dev environment. Signed-off-by: Daniel Axtens A good move generally. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited _

Re: [PATCH v2 3/6] Ignore *~ files.

On 04/08/16 16:10, Daniel Axtens wrote: Signed-off-by: Daniel Axtens Reviewed-by: Andrew Donnellan Maybe chuck "\#*#" in there as well? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___

[PATCH v2 6/6] Add .travis.yml file

This automatically runs the tests (except the browser ones) via tox. Only the following tests are run: py{27,35} and django {1.8,1.9}. Tested on my github account. This will require some setup on the GitHub end: Travis will need to be turned on for the project, and ideally a badge added to the rea

[PATCH v2 5/6] Allow use of Docker for development

This makes it possible to use Docker and docker-compose for development as an alternative to Vagrant. I quite liked vagrant a couple of years ago, but currently: * Trying to install VirtualBox on Ubuntu wants me to disable Secure Boot, and I don't want to do that. * Trying to use the libvir

[PATCH v2 4/6] Put test db host and port into env variables.

This is preparation for a Docker-based dev environment. Signed-off-by: Daniel Axtens --- patchwork/settings/dev.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py index e5c88d28dad4..127e15d9ebcd 100644 --- a/patchwork

[PATCH v2 2/6] Fix test_login in test_user_browser.py

It tried to use the pbkdf2 hash as the password. Use the username instead, as that is what create_user sets. Then it compared the test user username to testuser, rather than the username, which is dynamically generated. Compare to the generated username. Signed-off-by: Daniel Axtens --- patch

[PATCH v2 3/6] Ignore *~ files.

Signed-off-by: Daniel Axtens --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index ea1af7006e39..25ed66b875d4 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ .* *.pyc *.patch +*~ # # Top-level generic files -- 2.7.4

[PATCH v2 0/6] Starting out with Patchwork

Hi all, I have been attempting to pick up some patchwork development. I had a pretty rocky start. Patch 1 fixes an issue I had where attempting to install Patchwork failed: an __init__ method tried to query the database, which doesn't work when the database isn't initialised. I have put this in

[PATCH v2 1/6] Fix failure to start with uninitalised database

An OptionalModelChoiceField will attempt to query the database to get choices in its __init__ method. This fails if the database hasn't been initialised yet. So, put that in a try/catch block. This lets things work through the migration and loading of data from fixtures. Signed-off-by: Daniel Axte

Re: [PATCH 5/7] Allow use of Docker for development

>> I considered reverting to Chromium, but that will still require >> chromedriver which (AFAICT) is a closed source blob. > > https://sites.google.com/a/chromium.org/chromedriver/contributing would > seem to disagree - it appears it's compiled from within the main > chromium git repo. Derp. Th

Re: [PATCH 5/7] Allow use of Docker for development

On 04/08/16 14:55, Daniel Axtens wrote: I considered reverting to Chromium, but that will still require chromedriver which (AFAICT) is a closed source blob. https://sites.google.com/a/chromium.org/chromedriver/contributing would seem to disagree - it appears it's compiled from within the main

Re: [PATCH 5/7] Allow use of Docker for development

Russell Currey writes: > On Tue, 2016-08-02 at 13:44 +1000, Daniel Axtens wrote: >> > >> > Would it be possible to use chromium instead?  It's probably included in >> > distributions and wouldn't require adding a third-party repo, and worse, >> > proprietary software. >> > >> That's a fair poin