Re: [PATCH v2 5/6] Allow use of Docker for development

On 04/08/16 16:10, Daniel Axtens wrote: This makes it possible to use Docker and docker-compose for development as an alternative to Vagrant. I quite liked vagrant a couple of years ago, but currently: * Trying to install VirtualBox on Ubuntu wants me to disable Secure Boot, and I don't

Re: [PATCH v2 2/6] Fix test_login in test_user_browser.py

On 04/08/16 16:10, Daniel Axtens wrote: It tried to use the pbkdf2 hash as the password. Use the username instead, as that is what create_user sets. Then it compared the test user username to testuser, rather than the username, which is dynamically generated. Compare to the generated

Re: [PATCH v2 4/6] Put test db host and port into env variables.

On 04/08/16 16:10, Daniel Axtens wrote: This is preparation for a Docker-based dev environment. Signed-off-by: Daniel Axtens A good move generally. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra

[PATCH v2 6/6] Add .travis.yml file

This automatically runs the tests (except the browser ones) via tox. Only the following tests are run: py{27,35} and django {1.8,1.9}. Tested on my github account. This will require some setup on the GitHub end: Travis will need to be turned on for the project, and ideally a badge added to the

[PATCH v2 4/6] Put test db host and port into env variables.

This is preparation for a Docker-based dev environment. Signed-off-by: Daniel Axtens --- patchwork/settings/dev.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py index e5c88d28dad4..127e15d9ebcd

[PATCH v2 2/6] Fix test_login in test_user_browser.py

It tried to use the pbkdf2 hash as the password. Use the username instead, as that is what create_user sets. Then it compared the test user username to testuser, rather than the username, which is dynamically generated. Compare to the generated username. Signed-off-by: Daniel Axtens

[PATCH v2 1/6] Fix failure to start with uninitalised database

An OptionalModelChoiceField will attempt to query the database to get choices in its __init__ method. This fails if the database hasn't been initialised yet. So, put that in a try/catch block. This lets things work through the migration and loading of data from fixtures. Signed-off-by: Daniel