Re: [PATCH v5 0/7] Add series support

2016-10-10 Thread Daniel Axtens
> I don't think all of this stuff would need to be included in the initial > implementation, and I think one of us would be able to work on it.  Are you > aware of anything here that would be backwards incompatible that might need to > go in now?  The only thing I can think of would be the series n

Re: [PATCH v5 0/7] Add series support

2016-10-10 Thread Andrew Donnellan
On 11/10/16 11:51, Russell Currey wrote: - no series in the patch API at all. This could probably be implemented a few different ways, but having no series at all is limiting I'm looking at this currently. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM

Re: [PATCH v5 0/7] Add series support

2016-10-10 Thread Russell Currey
On Sun, 2016-10-09 at 23:25 +0100, Stephen Finucane wrote: > Add support for series. Series are groups of patches sent as one > bundle. For example: > > [PATCH 0/3] A cover letter >   [PATCH 1/3] The first patch >   [PATCH 2/3] The second patch >   [PATCH 3/3] The third patch > >

[PATCH 2/5] models: Remove Bundle.n_patches

2016-10-10 Thread Stephen Finucane
It doesn't really do much for us. Less LOC = win. Signed-off-by: Stephen Finucane --- patchwork/models.py| 3 --- patchwork/templates/patchwork/bundles.html | 2 +- patchwork/views/xmlrpc.py | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff -

[PATCH 5/5] models: Trivial cleanup

2016-10-10 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- patchwork/models.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 3abae3c..229b701 100644 --- a/patchwork/models.py +++ b/patchwork/models.py @@ -20,7 +20,8 @@ from __future__ import

[PATCH 1/5] models: Make use of aggregates

2016-10-10 Thread Stephen Finucane
We're well past Django 1.1 now, so resolve a TODO to use aggregate support introduced in this version. As part of this change, replace the use of 'count' to check for presence of matching objects with 'exists'. Signed-off-by: Stephen Finucane --- patchwork/models.py | 22 --

[PATCH 3/5] models: Remove UserProfile.sync_person

2016-10-10 Thread Stephen Finucane
This doesn't seem to do anything, and hasn't for a very long time (pre-0.9.0, at least). Signed-off-by: Stephen Finucane --- patchwork/models.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 3c554af..608b70c 100644 --- a/patchwork/models.py

[PATCH 4/5] models: Remove 'refresh_tag_counts' from Submission

2016-10-10 Thread Stephen Finucane
Turns out 'Submission' has a 'patch' field when it's subclassed as 'Patch'. Use this field to call 'refresh_tag_counts' on the subclass only. Signed-off-by: Stephen Finucane --- patchwork/models.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/patchwork/models.py b

Re: [PATCH] models: Remove 'UserProfile.primary_project'

2016-10-10 Thread Stephen Finucane
On 10 Oct 12:34, Andrew Donnellan wrote: > On 10/10/16 09:36, Stephen Finucane wrote: > > This field was unused and has been for a long time (pre-0.9.0). > > > > Signed-off-by: Stephen Finucane > > LGTM! > > Reviewed-by: Andrew Donnellan ...and it's merged. ___

Re: [PATCH 0/5] Add Django 1.10 support

2016-10-10 Thread Stephen Finucane
On 10 Oct 12:39, Daniel Axtens wrote: > I have a similar series I was going to post - it looks basically > identical to yours. So, this series is: > > Reviewed-by: Daniel Axtens Excellent. Applied. ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH v2 3/7] Test for header preservation

2016-10-10 Thread Stephen Finucane
On 2016-10-10 07:06, Johannes Berg wrote: On Wed, 2016-09-28 at 18:02 +0100, Stephen Finucane wrote: On 28 Sep 15:22, Daniel Axtens wrote: > > We're about to rework header parsing. Try to ensure the changes > preserve functionality. > > Signed-off-by: Daniel Axtens I like the idea, but I don't

Re: [PATCH v5 0/7] Add series support

2016-10-10 Thread Stephen Finucane
On 2016-10-10 01:41, Andrew Donnellan wrote: On 10/10/16 09:25, Stephen Finucane wrote: Add support for series. Series are groups of patches sent as one bundle. For example: [PATCH 0/3] A cover letter [PATCH 1/3] The first patch [PATCH 2/3] The second patch [PATCH 3/3] The

Re: [PATCH v2 3/7] Test for header preservation

2016-10-10 Thread Johannes Berg
On Wed, 2016-09-28 at 18:02 +0100, Stephen Finucane wrote: > On 28 Sep 15:22, Daniel Axtens wrote: > > > > We're about to rework header parsing. Try to ensure the changes > > preserve functionality. > > > > Signed-off-by: Daniel Axtens > > I like the idea, but I don't know if there is any advan