Re: [PATCH v6 1/8] models: Convert functions to properties

2016-10-17 Thread Andrew Donnellan
On 16/10/16 23:50, Stephen Finucane wrote: A number of models contain functions that are, semantically speaking, actually properties. Mark them as such. Signed-off-by: Stephen Finucane Reviewed-by: Andy Doan Same comment as Daniel re moving stuff around, but otherwise as per last time: Re

Re: [PATCH v6 1/8] models: Convert functions to properties

2016-10-17 Thread Daniel Axtens
Stephen Finucane writes: > -def sync_person(self): > -pass > - > +def sync_person(self): > +pass > + Not sure why you're moving sync_person here. Doesn't really matter or need a respin but it might be worth trying to drop these hunks when merging. I haven't checked al

Re: [PATCH v5 2/7] models: Add 'Series' model and related models

2016-10-17 Thread Stephen Finucane
On 11 Oct 12:35, Andy Doan wrote: > On 10/09/2016 05:25 PM, Stephen Finucane wrote: > > Add a series model. This model is intentionally very minimal to allow > > as much dynaminism as possible. It is expected that patches will be > > migrated between series as new data is provided. > > > > Signed-

Re: [PATCH v6 0/8] Add series support

2016-10-17 Thread Stephen Finucane
On 17 Oct 11:08, Russell Currey wrote: > Patch 4 again didn't make it to the list and it doesn't look like your branch > on > GitHub was updated for v6, could you push it there? > > assuming I'm looking in the right place:  > https://github.com/stephenfin/patchwork/tree/feat/series-support Oops