[PATCH 2/2] views: Include 'List-Id' in mbox

2016-11-19 Thread Stephen Finucane
Signed-off-by: Stephen Finucane Closes-bug: #53 --- patchwork/tests/test_mboxviews.py | 5 + patchwork/views/__init__.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py index

[PATCH 1/2] views: Don't munge the 'From' field of patches

2016-11-19 Thread Stephen Finucane
From: Doug Anderson At the moment patchwork always uses the official submitter name (as patchwork understands it) as the "From" for patches that you receive. This isn't quite what users expect and has some unfortunate consequences. The biggest problem is that patchwork

Re: [PATCH] Add support for comment permalink

2016-11-19 Thread Stephen Finucane
On 25 Sep 21:59, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > Closes-bug: #39 Applied. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] forms: Tighten validation on BundleForm

2016-11-19 Thread Stephen Finucane
On 25 Mar 13:40, Stephen Finucane wrote: > The 'name' field of 'Bundle' cannot be blank, so update the form to > reflect this. > > Signed-off-by: Stephen Finucane This still applied cleanly. Merged. ___ Patchwork mailing

Re: [PATCH] admin: Integrate UserProfile fields into admin

2016-11-19 Thread Stephen Finucane
On 29 Oct 14:18, Stephen Finucane wrote: > The 'User' model is extended by means of a 'UserProfile' model. These > fields are not correctly displayed in the admin UI, but they should be. > Let's fix this per the recommendations of the Django docs [1]. > > [1] >

[PATCH v2 3/3] templates: Add Patchwork version

2016-11-19 Thread Stephen Finucane
This is managed using a combination of hardcoded string, for installations from tarball, and 'git describe', for installations from a Git repo. This includes installing Git in the Docker environment, to enable this in the development environment. Signed-off-by: Stephen Finucane

[PATCH v2 1/3] urls: Move 'help/about' to 'about'

2016-11-19 Thread Stephen Finucane
This is the standard URL for such pages. This involves removing the pwclient help page, but this is migrated to the project summary page and detailed in the documentation. Permanent redirects are included to prevent dead links. Signed-off-by: Stephen Finucane ---

[PATCH v2 12/13] REST: Add '/series' endpoint

2016-11-19 Thread Stephen Finucane
Adopt a hybrid approach, by adding an additional series endpoint to the existing patch endpoint: /series/${series_id}/ /patches/${patch_id}/ This is based on the approach described here: http://softwareengineering.stackexchange.com/a/275007/106804 This is necessary due to the N:N

[PATCH v2 10/13] REST: Add id field to all endpoints

2016-11-19 Thread Stephen Finucane
Signed-off-by: Stephen Finucane Cc: Andy Doan --- patchwork/api/check.py | 2 +- patchwork/api/patch.py | 6 +++--- patchwork/api/person.py | 2 +- patchwork/api/project.py | 2 +- patchwork/api/user.py| 2 +- 5 files changed, 7 insertions(+), 7

[PATCH v2 08/13] REST: Make 'User.first_name', 'last_name' editable

2016-11-19 Thread Stephen Finucane
These would be valuable to change via the API. Signed-off-by: Stephen Finucane Cc: Andy Doan --- patchwork/api/user.py| 20 patchwork/tests/test_rest_api.py | 16 +++- 2 files changed, 27 insertions(+), 9

[PATCH v2 07/13] REST: Make 'Patch.state' editable

2016-11-19 Thread Stephen Finucane
This is one of the most useful fields to allow editing of via the API. Make it so. Signed-off-by: Stephen Finucane Cc: Andy Doan --- patchwork/api/__init__.py| 5 + patchwork/api/patch.py | 30 +-

[PATCH v2 06/13] REST: Stop using ViewSets

2016-11-19 Thread Stephen Finucane
These are hacked a lot of to get them to work as we want. Use a more verbose, but ultimately easier to parse, version. This lets us remove the dependency of drf-nested-routers, bringing us back down to two main dependencies. It also lets us remove the AuthenticedReadOnly permission class, as the

[PATCH v2 05/13] REST: Resolve performance issues with tags

2016-11-19 Thread Stephen Finucane
The list comprehension used to generate a list of tags resulted in a significant number of duplicated queries. Resolve this by copying the approach taken to minimize patch queries in the UI. This changes the output of the response in two ways. First, counts for all tag patches are now shown, even

[PATCH v2 01/13] requirements: Test older versions of DRF

2016-11-19 Thread Stephen Finucane
We still care about Django 1.6 and 1.7, at least until 2.0 is released. Start testing REST functionality on these versions by using older versions. Signed-off-by: Stephen Finucane --- v2: - Rebase onto master --- patchwork/api/__init__.py | 92 ++

[PATCH v2 00/13] Implement series REST API

2016-11-19 Thread Stephen Finucane
Time to expose series via the REST API. As you can tell, this series actually covers a lot more work than pure series work. Most of this is based off of discussions I had with Andy Doan regarding making the REST API code a little easier to maintain. This does result in some changes to the API, but

[PATCH 1/5] tests: Add rudimentary pagination tests

2016-11-19 Thread Stephen Finucane
This should improve coverage and prevent regressions. The 'ppp' header is removed as this is a non-standard header and not accessible from a browser. Signed-off-by: Stephen Finucane --- patchwork/paginator.py| 7 ---

[PATCH 0/5] Cleanup of forms

2016-11-19 Thread Stephen Finucane
Improve test coverage and reduce duplications in forms.py Stephen Finucane (5): tests: Add rudimentary pagination tests forms: Remove unused args in forms forms: Remove duplication forms: Use TypedChoiceField forms: Trivial reshuffling of file patchwork/forms.py

[PATCH 3/5] forms: Remove duplication

2016-11-19 Thread Stephen Finucane
DelegateField and OptionalDelegateField were basically duplicates of other fields. Make use of parameters and remove them. Signed-off-by: Stephen Finucane --- patchwork/forms.py | 58 +++--- 1 file changed, 16 insertions(+), 42

[PATCH 4/5] forms: Use TypedChoiceField

2016-11-19 Thread Stephen Finucane
This resolves a TODO. Signed-off-by: Stephen Finucane --- patchwork/forms.py | 33 ++--- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/patchwork/forms.py b/patchwork/forms.py index ad69ea6..3ccf754 100644 --- a/patchwork/forms.py

[PATCH 2/5] forms: Remove unused args in forms

2016-11-19 Thread Stephen Finucane
There were a couple of forms that offered configurabilty, but this configurability wasn't used anywhere. Simplify things and remove any related code. Signed-off-by: Stephen Finucane --- patchwork/forms.py | 18 ++ 1 file changed, 6 insertions(+), 12