Re: [PATCH 4/6] views: Add 'series' parameter to '/mbox' endpoint

On 03/02/17 08:42, Daniel Axtens wrote: In this case, the first link will download patch 5 plus any dependencies from series 1 (ignoring patch 6+), while the latter will download the entirety of series 1. We could expose both in the UI, or we could expose just the full series link. OK, between

Re: [PATCH 3/3] docs: fix links to installation pages

Hi Denis, Thanks! Reviewed-by: Daniel Axtens Regards, Daniel Denis Laxalde writes: > Signed-off-by: Denis Laxalde > --- > docs/deployment/installation.md | 2 +- > docs/development/contributing.md | 2 +- >

Re: [PATCH 2/3] docs: fix links to "contributing" page

Hi Denis, Thanks! Reviewed-by: Daniel Axtens Regards, Daniel > Signed-off-by: Denis Laxalde > --- > docs/deployment/installation.md | 2 +- > docs/deployment/upgrading.md | 2 +- > docs/development/installation.md | 2 +- > 3 files changed, 3

Re: [PATCH 1/3] docs: link to deployment/development installation page in index

Hi Denis, Thanks, that looks good to me. Reviewed-by: Daniel Axtens Regards, Daniel Denis Laxalde writes: > Previous links are broken. > > Signed-off-by: Denis Laxalde > --- > docs/index.md | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH 5/6] templates: Use buttons for patch download links

I've fat-fingered the initial response to this message and accidentally omitted the list - here's the info for posterity. Stephen, I'm going to actually apply the series and have a look - hopefully today otherwise probably Monday. Thanks for the comments. Stephen Finucane

Re: [PATCH 3/6] views: Add 'bundle_to_mbox' views

I've fat-fingered the initial response to this message and accidentally omitted the list - here's the info for posterity. Stephen Finucane writes: > On Thu, 2017-02-02 at 17:07 +1100, Daniel Axtens wrote: >> Hi Stephen, >> >> I'm not much of a fan of: >> >>  - mixing

Re: [PATCH 4/4] tox: Add 'bashate' target

On Wed, 2017-02-01 at 23:35 +1100, Daniel Axtens wrote: > Hi Stephen, > > I'm quite happy with this series! > > Reviewed-by: Daniel Axtens > > A minor thought: > > > +[testenv:bashate] > > +deps = bashate>=0.5,<0.6 > > +whitelist_externals = bash > > +commands = > > +bash

Re: Patchwork displays incorrect submitter name

On Tue, 2017-01-31 at 09:53 +, Stephen Finucane wrote: > On Sat, 2017-01-28 at 12:24 +0100, John Paul Adrian Glaubitz wrote: > > Hi Stephen! > > > > On 01/22/2017 11:28 PM, John Paul Adrian Glaubitz wrote: > > > On 01/22/2017 11:10 PM, Stephen Finucane wrote: > > > > This looks like an

Re: [PATCH 2/6] views: Make 'patch_to_mbox' return a string

On Thu, 2017-02-02 at 13:58 +1100, Daniel Axtens wrote: > Hi, > > > The 'patch_to_mbox' function returns an object which is coverted to > > a > > string in all places where this call occurs. The string conversion > > differs between Python 2 and 3 and while one it has been updated in > > one > >

Re: [PATCH 4/6] views: Add 'series' parameter to '/mbox' endpoint

On Thu, 2017-02-02 at 17:47 +1100, Daniel Axtens wrote: > Hi Stephen, > > > This allows a user to download dependencies for a patch without > > having > > to do it manually. > > I'm not sold on the idea of calling these dependencies and allowing > downloads of partial series. It just seems to