Re: [PATCH] Implement list filtering

2018-01-24 Thread Daniel Axtens
vkaba...@redhat.com writes: > From: Veronika Kabatova > > Sometimes, multiple projects reside at the same mailing list. So far, > Patchwork only allowed a single project per mailing list, which made it > impossible for these projects to use Patchwork (unless they did some > dirty hacks). > > Add

Re: [RFC 1/4] Automatically remove old events

2018-01-24 Thread Daniel Axtens
Hi Stephen, This is a good idea and I'm happy for it to go in as-is, before the rest of the series. Reviewed-by: Daniel Axtens Regards, Daniel > Events are created for most state changes in Patchwork which means > they're fairly numerous. Start removing them after a (configurable) > interval.

[PATCH 7/7] Fix Python3.6 depreciation warnings

2018-01-24 Thread Daniel Axtens
We see on Travis and on tox: /home/travis/build/daxtens/patchwork/patchwork/tests/test_list.py:79: DeprecationWarning: invalid escape sequence \d id_re = re.compile(']*action="%(url)s"[^>]*>' /home/travis/build/daxtens/patchwork/patchwork/tests/test_parser.py:616: DeprecationWarning: invalid es

[PATCH 6/7] docker: add Python3.6 to image

2018-01-24 Thread Daniel Axtens
This is needed to support py3.6-django111 in tox - otherwise tox fails. Python3.6 is not in Xenial, so this - irritatingly - requires pulling in either a PPA, or the package from Artful. PPAs are icky, so pull it in from Artful. We can either add an Artful repo (like we do for Trusty to pull in p

[PATCH 4/7] travis: run pep8/flake8 tests

2018-01-24 Thread Daniel Axtens
Add the test at the end of each run. This is inefficient but simpler than adding a matrix entry. It's also very fast so there's no slowdown. While there, remove the 'codecov' package: tox will bring it in automatically. Signed-off-by: Daniel Axtens --- .travis.yml | 2 +- 1 file changed, 1 inse

[PATCH 5/7] travis: test Python 3.6

2018-01-24 Thread Daniel Axtens
We have a tox entry for py36-django111. We should test that in Travis CI. Signed-off-by: Daniel Axtens --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index f43baa11e887..7589fc7f288a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,7 @@ python:

[PATCH 2/7] Fix sy -> sys in pwclient error path

2018-01-24 Thread Daniel Axtens
While running docker-compose run web --quick-tox, I got this flake8/pep8 error for pwclient: patchwork/bin/pwclient:713:9: F821 undefined name 'sy' Fix by converting to 'sys' instead, which was intended. Fixes: 58160097f957 ("pwclient: Resolve pycode warnings") Signed-off-by: Daniel Axtens --

[PATCH 3/7] tags: be a bit more permissive in what we render to a message

2018-01-24 Thread Daniel Axtens
Currently we render a tag from a comment into a message if it is '^(whatever)-by: .*' We found a patch that had a UTF-8 non-breaking space after the colon, and this was breaking the regex. So just remove the requirement for a space entirely. Add the test from the original bug. Closes: #124 Sign

[PATCH 1/7] pagination: Fix quirks

2018-01-24 Thread Daniel Axtens
There are a couple of pages where the clickable list of pages would include missing or duplicate pages. Write a test that ensures: - you always have a link to the next/prev numbered page - there are no duplicate page numbers Fiddle with the pagination algorithm to get it to pass - required twea

[PATCH 0/7] Various fixes

2018-01-24 Thread Daniel Axtens
This series: - fixes a few bugs: - pagination from github - misspelling of sys in pwclient picked up by pep8 - tag issue from github - enables more testing - pep8 and Python3.6 in travis - Python3.6 in docker - fixes some python3.6 depreciation warnings They're all reasonably

[PATCH] Implement list filtering

2018-01-24 Thread vkabatov
From: Veronika Kabatova Sometimes, multiple projects reside at the same mailing list. So far, Patchwork only allowed a single project per mailing list, which made it impossible for these projects to use Patchwork (unless they did some dirty hacks). Add a new property `subject_match` to projects