Re: [PATCH 1/7] pagination: Fix quirks

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > There are a couple of pages where the clickable list of pages > would include missing or duplicate pages. > > Write a test that ensures: > - you always have a link to the next/prev numbered page > - there are no duplicate page numbers >

Re: [PATCH 2/7] Fix sy -> sys in pwclient error path

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > While running docker-compose run web --quick-tox, I got this > flake8/pep8 error for pwclient: > > patchwork/bin/pwclient:713:9: F821 undefined name 'sy' > > Fix by converting to 'sys' instead, which was intended. > > Fixes: 58160097f957

Re: [PATCH 5/7] travis: test Python 3.6

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > We have a tox entry for py36-django111. We should test that in > Travis CI. > > Signed-off-by: Daniel Axtens Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH 6/7] docker: add Python3.6 to image

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > This is needed to support py3.6-django111 in tox - otherwise tox > fails. > > Python3.6 is not in Xenial, so this - irritatingly - requires pulling > in either a PPA, or the package from Artful. PPAs are icky, so pull > it in from Artful. >

Re: [PATCH 7/7] Fix Python3.6 depreciation warnings

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > We see on Travis and on tox: > /home/travis/build/daxtens/patchwork/patchwork/tests/test_list.py:79: > DeprecationWarning: invalid escape sequence \d > id_re = re.compile(' /home/travis/build/daxtens/patchwork/patchwork/tests/test_mail_set

Re: [PATCH 4/7] travis: run pep8/flake8 tests

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > Add the test at the end of each run. This is inefficient but simpler > than adding a matrix entry. It's also very fast so there's no > slowdown. > > While there, remove the 'codecov' package: tox will bring it in > automatically. > > Signe

Re: [PATCH 3/7] tags: be a bit more permissive in what we render to a message

On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > Currently we render a tag from a comment into a message if it is > > '^(whatever)-by: .*' > > We found a patch that had a UTF-8 non-breaking space after the colon, > and this was breaking the regex. So just remove the requirement for > a

Re: [PATCH 3/7] tags: be a bit more permissive in what we render to a message

On Fri, 2018-01-26 at 21:24 +, Stephen Finucane wrote: > On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: > > Currently we render a tag from a comment into a message if it is > > > > '^(whatever)-by: .*' > > > > We found a patch that had a UTF-8 non-breaking space after the > > colon,

[PATCH] travis: Run pep8 for py27 only

Keep run times to a minimum. Signed-off-by: Stephen Finucane --- .travis.yml | 1 - tox.ini | 4 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 7589fc7f..7e871da8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,7 +33,6 @@ install: scri

Re: [PATCH] travis: Run pep8 for py27 only

Stephen Finucane writes: > Keep run times to a minimum. > > Signed-off-by: Stephen Finucane > --- > .travis.yml | 1 - > tox.ini | 4 > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 7589fc7f..7e871da8 100644 > --- a/.travis.yml > +++

Re: [PATCH 3/7] tags: be a bit more permissive in what we render to a message

Stephen Finucane writes: > On Fri, 2018-01-26 at 21:24 +, Stephen Finucane wrote: >> On Thu, 2018-01-25 at 13:43 +1100, Daniel Axtens wrote: >> > Currently we render a tag from a comment into a message if it is >> > >> > '^(whatever)-by: .*' >> > >> > We found a patch that had a UTF-8 non-