Re: [PATCH 4/6] Begin live migration of diff and pull_url to Submission

2019-09-26 Thread Daniel Axtens
Daniel Axtens writes: > This patch contains 2 migrations: > > 0037_prepare_old_diff_pull_url: > - renames Patch's 'diff' to 'old_diff', while not affecting the db > - likewise 'pull_url' to 'old_pull_url' > This does no SQL changes, which you can verify with > python manage.py sqlmigrate

Re: [PATCH 2/2] Integrate 'pre-commit'

2019-09-26 Thread Daniel Axtens
Hi Stephen, I love automated tools, but I have no idea what pre-commit is - would you be able to clarify it in the commit message? Kind regards, Daniel > Helps me avoid simple style issues. We explicitly disable newline checks > for some files where the "fix" would be harmful (e.g. mboxes and >

Re: [PATCH 1/2] trivial: Style fixes

2019-09-26 Thread Daniel Axtens
Stephen Finucane writes: > An assortment of fixes identified through the integration of pre-commit. > > Signed-off-by: Stephen Finucane > --- > .dockerignore | 1 - > htdocs/css/style.css | 382 +- >

git-pw startup issues

2019-09-26 Thread Bjorn Helgaas
Hello, I'm trying to get started with git-pw (or pwclient, but I have the impression that's the old stuff, and I don't think it supports things like delegating patches), but I feel like I'm banging my head against the wall. Maybe something isn't installed or configured right; I'd appreciate any

Re: [PATCH] Fix issue with delegation of patch via REST API

2019-09-26 Thread Michael Ellerman
On 24 September 2019 6:51:53 pm AEST, Stephen Finucane wrote: >On Mon, 2019-09-23 at 15:23 -0500, Bjorn Helgaas wrote: >> [+cc Jeremy, Michael] >> >> On Sat, Sep 21, 2019 at 07:30:46PM +0100, Stephen Finucane wrote: >> > There have been reports of people being unable to delegate patches >to

Re: git-pw startup issues

2019-09-26 Thread Bjorn Helgaas
On Sat, Sep 21, 2019 at 1:37 PM Stephen Finucane wrote: > > On Sat, 2019-09-21 at 10:32 -0500, Bjorn Helgaas wrote: > > Hello, > > > > I'm trying to get started with git-pw (or pwclient, but I have the > > impression that's the old stuff, and I don't think it supports things > > like delegating

pwclient list issues

2019-09-26 Thread Bjorn Helgaas
No doubt this is user or installation error, but I haven't a clue. My ~/.pwclientrc: [options] default = linux-pci [linux-pci] url = https://patchwork.ozlabs.org/xmlrpc/ On pwclient HEAD (dc50416ff1b5 ("trivial: noqa duplicate import")), some things work: $ ~/.local/bin/pwclient