[PATCH v2] docker: Specify GID for docker-compose-pg.yml too

2019-10-23 Thread Daniel Axtens
We just need to mirror the change in the MySQL/default docker-compose.yml file. Fixes: b4f4c8554c11 ("docker: Require GID also") Signed-off-by: Daniel Axtens --- v2: an object lesson in why you should test before emailing --- docker-compose-pg.yml | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH] docker: Specify GID for docker-compose-pg.yml too

2019-10-23 Thread Daniel Axtens
We just need to mirror the change in the MySQL/default docker-compose.yml file. Fixes: b4f4c8554c11 ("docker: Require GID also") Signed-off-by: Daniel Axtens --- docker-compose-pg.yml | 1 + 1 file changed, 1 insertion(+) diff --git docker-compose-pg.yml docker-compose-pg.yml index 7bb579c3279f

Re: [PATCH v2] Python 3.8 support

2019-10-23 Thread Daniel Axtens
Applied to master, thanks. Andrew Donnellan writes: > Enable Python 3.8 in our tests and list it as a supported version. > > Signed-off-by: Andrew Donnellan > > --- > > v1->v2: > - Add release note that I forgot to git add > --- > README.rst | 2

[PATCH v2 1/2] [PW3] tests: Fix escaping in bundle tests on Django 3.0

2019-10-23 Thread Andrew Donnellan
Django 3.0 switches to using Python 3's built-in HTML escaper, which prefers to escape entities using hex rather than decimal. Some of our tests check rendered HTML output against pre-escaped strings, and fail because ''' is now '''. Fix this by using the escape function so we get consistent esca

[PATCH v2 2/2] [PW3] Add Django 3.0 support

2019-10-23 Thread Andrew Donnellan
Now that we've dropped Python 2, we can get ready for Django 3.0, which is still in beta. Add Django 3.0b1 as a tox environment. Add a release note for Django 3.0 support, as it will be released by the time Patchwork 3.0 is out. Closes: #311 ("Django 3.0 support") Signed-off-by: Andrew Donnellan

[PATCH] travis, tox: only do coverage testing in py27

2019-10-23 Thread Daniel Axtens
Currently Travis calls `tox -e coverage` unconditionally. However, the environment has py27 basepython, so all the runs only generate py27 coverage! Rather than try to untangle that, just run the coverage when run in a py27 travis environment. This makes things faster for no loss of coverage. It m

[PATCH v2] Python 3.8 support

2019-10-23 Thread Andrew Donnellan
Enable Python 3.8 in our tests and list it as a supported version. Signed-off-by: Andrew Donnellan --- v1->v2: - Add release note that I forgot to git add --- README.rst | 2 +- releasenotes/notes/python-3-8-support-59150fb6391f9b73.yaml | 5 +++

[PATCH] Python 3.8 support

2019-10-23 Thread Andrew Donnellan
Enable Python 3.8 in our tests and list it as a supported version. Signed-off-by: Andrew Donnellan --- README.rst | 2 +- tools/docker/Dockerfile | 3 ++- tox.ini | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.rst b/README.rst index 01d

Re: Deduplication of patchwork mail content?

2019-10-23 Thread Daniel Axtens
Konstantin Ryabitsev writes: > On Wed, Oct 09, 2019 at 05:35:03PM +1100, Daniel Axtens wrote: >> Hi sfr, jk, Konstantin and any other admins lurking, >> >> I'm in the process of reworking the patchwork db schema to avoid one of >> our very big and very annoying (and slow) JOINs. >> >> While I'm

Re: [PATCH 2/2] [PW3] tox: Add Django 3.0b1

2019-10-23 Thread Daniel Axtens
Andrew Donnellan writes: > Now that we've dropped Python 2, we can get ready for Django 3.0. > > Add Django 3.0b1 as a tox environment. > > Closes: #311 ("Django 3.0 support") > Signed-off-by: Andrew Donnellan > > --- > > Not adding upper bounds on the version numbers until 3.0 actually drops. >

[PATCH] README: remove dead landscape.io badge

2019-10-23 Thread Daniel Axtens
landsape.io is down and seems to have been for some time. The issue tracker [1] doesn't seem to have anything since April. Pull out the broken badge. If landscape.io returns we can add it back later. [1] https://github.com/landscapeio/landscape-issues/issues?q=is%3Aopen+is%3Aissue Signed-off-by

[PATCH] travis: fix codecov

2019-10-23 Thread Daniel Axtens
In e017f69376da ("travis: run pep8/flake8 tests"), codecov was removed from the install step, on the basis that tox-travis would pull it in automatically. This, it turns out, isn't entirely true: it is pulled in to the tox environment, but the data is actually sent in an after_success step. That i

Re: Deduplication of patchwork mail content?

2019-10-23 Thread Konstantin Ryabitsev
On Wed, Oct 09, 2019 at 05:35:03PM +1100, Daniel Axtens wrote: > Hi sfr, jk, Konstantin and any other admins lurking, > > I'm in the process of reworking the patchwork db schema to avoid one of > our very big and very annoying (and slow) JOINs. > > While I'm at it, it occurred to me that for both

Re: [PATCH] api: support filtering patches by hash

2019-10-23 Thread Konstantin Ryabitsev
On Thu, Oct 24, 2019 at 01:33:42AM +1100, Daniel Axtens wrote: > This is a feature that the XML-RPC API has, and which is used in > the wild [1], so support it in the REST API. Nice! Thank you for this. > I tried to version the new filter field, but it's not at all clear > how to do this with dja

[PATCH] api: support filtering patches by hash

2019-10-23 Thread Daniel Axtens
This is a feature that the XML-RPC API has, and which is used in the wild [1], so support it in the REST API. I tried to version the new filter field, but it's not at all clear how to do this with django-filters. The best way I could find requires manually manipulating request.GET, which seems to