Re: [PATCH v3 4/5] docs: Add missing series index schema

2019-10-31 Thread Daniel Axtens
Huh. Do I understand correctly that this fixes a bug in the schema description yaml/j2 files? I think, if that's the case, that you need a Fixes tag, just above your Signed-off. I generate them by putting the following snippet in my ~/.gitconfig file: [core] abbrev = 12 [pretty]

Re: [PATCH v3 2/5] ui, templates: Combine series and related row

2019-10-31 Thread Daniel Axtens
Mete Polat writes: > Move the series patch list from 'Related' to 'Series' and display the > series name, its patches and a detailed link in the same row. This > allows to use the 'Related' row for actually showing submission > relations instead. I get what you're trying to do here, and it makes

Re: [PATCH v3 1/5] ui: Retain table header position on size changes

2019-10-31 Thread Daniel Axtens
Hi Mete, Apologies for the delay in getting back to you. I'm kicking the tyres of this, so I'll have a few comments across the series. Maybe hold off on doing a new version until I get through the whole series - I don't want to waste your effort on doing lots of respins on trivial bits. > Prevent

Re: [PATCH] [stable/2.1] sql: Fix table lists

2019-10-31 Thread Daniel Axtens
Applied, thank you. Ali Alnubani writes: > [ backported from master commit 1a36ed51a8e1 ] > > The patch adds missing commas in the table lists where missing, and > removes where unnecessary. This fixes errors such as the following when > feeding the script to psql: > > psql:lib/sql/grant-all.p

[PATCH 1/2] templates: Get rid of type attribute in script tags

2019-10-31 Thread Andrew Donnellan
In HTML5, the type attribute of a script tag is optional if it's JavaScript. Remove all occurrences. The only real gain is slightly smaller page output, but it also shuts up validators that like to be noisy about this. Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/bundle.htm

[PATCH 2/2] templates: Specify language

2019-10-31 Thread Andrew Donnellan
Specifying language in the tag is recommended in HTML5. Signed-off-by: Andrew Donnellan --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index 01b0d6b5e598..40b6cda65350 100644 --- a/templates/base.html +++ b/t