Re: [PATCH v2] models: Validate Project.linkname does not contain forward slash

2020-09-26 Thread Thomas Bracht Laumann Jespersen
> Thanks! This is one of those things you just assume people are doing so > you never bother enforcing it :) In hindsight, the 'Project.linkname' > field is supposed to be a slug - that is, restricted to letters, > numbers, underscores and hyphens. You'd use 'Project.name' if you > wanted more

Re: Regression in the patches API

2020-09-26 Thread Stephen Finucane
On Wed, 2020-06-03 at 18:00 +0200, Ralf Ramsauer wrote: > Hi, > > it seems that the /patches-API is broken under certain conditions. The > API call throws an exception if the following conditions are met: > - The user is logged in a browser > - In the browser, the user requests /api/patches//

Re: [PATCH] pwclient: Add check-get subcommand

2020-09-26 Thread Stephen Finucane
On Thu, 2020-09-10 at 17:11 -0700, Olof Johansson wrote: > Provide a subcommand to query the checks ran against a specific patch_id. > > Also allows formatting of the output, to make it easier to query whether > a specific patch has seen any tests (and what their status is). > > Signed-off-by:

Re: [PATCH 3/5] settings: Add context processor django.template.context_processors.request

2020-09-26 Thread Stephen Finucane
On Fri, 2020-08-28 at 00:14 +1000, Andrew Donnellan wrote: > Django 3.1 adds a new admin sidebar feature that requires the > django.template.context_processors.request context processor to be enabled > in the settings. > > Signed-off-by: Andrew Donnellan Compatible with Django 3.0 also. LGTM.

Re: [PATCH 5/5] Add support for Django 3.1

2020-09-26 Thread Stephen Finucane
On Fri, 2020-08-28 at 00:14 +1000, Andrew Donnellan wrote: > Signed-off-by: Andrew Donnellan Reviewed-by: Stephen Finucane And that wraps up the series. Thanks (!), and apologies for not getting to it sooner. Stephen ___ Patchwork mailing list

Re: [PATCH 4/5] requirements: Update django-filter

2020-09-26 Thread Stephen Finucane
On Fri, 2020-08-28 at 00:14 +1000, Andrew Donnellan wrote: > Update django-filter dependency to a version that's compatible with Django > 3.1. > > Signed-off-by: Andrew Donnellan Reviewed-by: Stephen Finucane ___ Patchwork mailing list

Re: [PATCH 2/5] urls: Update url pattern functions

2020-09-26 Thread Stephen Finucane
On Fri, 2020-08-28 at 00:14 +1000, Andrew Donnellan wrote: > Django 3.1 deprecates django.conf.urls.url() as an alias for > django.urls.re_path(). Also switch to using django.urls.include() rather > than django.conf.urls.include(). > > Signed-off-by: Andrew Donnellan Reviewed-by: Stephen

Re: [PATCH 1/5] templates: Replace ifequal and ifnotequal with if

2020-09-26 Thread Stephen Finucane
On Fri, 2020-08-28 at 00:14 +1000, Andrew Donnellan wrote: > Django 3.1 deprecates the ifequal and ifnotequal tags, for removal in 4.0. > Replace all occurrences of ifequal and ifnotequal with if. > > Signed-off-by: Andrew Donnellan Looks sensible. Reviewed-by: Stephen Finucane and applied.

Re: [PATCH] models: Validate Project.linkname does not contain forward slash

2020-09-26 Thread Stephen Finucane
On Tue, 2020-09-08 at 21:31 +1000, Andrew Donnellan wrote: > On 6/9/20 10:55 pm, Thomas Bracht Laumann Jespersen wrote: > > I started by creating a project that contained a forward slash > > (importing patches from https://lists.sr.ht/~sircmpwn/sr.ht-dev/) and > > it fails to render the "projects"

Re: [PATCH v2] models: Validate Project.linkname does not contain forward slash

2020-09-26 Thread Stephen Finucane
On Tue, 2020-09-08 at 16:06 +0200, Thomas Bracht Laumann Jespersen wrote: > I started by creating a project that contained a forward slash > (importing patches from https://lists.sr.ht/~sircmpwn/sr.ht-dev/) and > it fails to render the "projects" main page. > > The specific error reads: > >