While reviewing feedback it is helpful to see the review comments on the
command line to check that each has been addressed. Add an option to
support that.
Update the workflow documentation to describe the new features.
Signed-off-by: Simon Glass
---
Changes in v2:
- Many changes to the whole s
Add support for parsing the contents of a patchwork 'patch' web page
containing comments received from reviewers. This allows patman to show
these comments in a simple 'snippets' format.
A snippet is some quoted code plus some unquoted comments below it. Each
review is from a unique person/email a
At present if we fail to find the upstream then the error output is piped
to wc, resulting in bogus results. Avoid the pipe and check the output
directly.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 19 +++
tools/patman/gitutil.py | 10 +++
Before sending out a new version of a series for review, it is important
to add any review tags (e.g. Reviewed-by, Acked-by) collected by
patchwork. Otherwise people waste time reviewing the same patch
repeatedly, become frustrated and stop reviewing your patches.
To help with this, add a new 'sta
It is tedious to add review tags into the local branch and errors can
sometimes be made. Add an option to create a new branch with the review
tags obtained from patchwork.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 17 ++-
tools/patman/control.py |
Use the subject of the Commit object when printing it out.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/commit.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/patman/commit.py b/tools/patman/commit.py
index e49bf87dfc8..5bf2b940299 100644
--- a/tools/patman
These lines can indicate a continuation of an error and should not be
ignored. Fix this.
Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code")
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 7 +--
1 file changed, 5 insertions(+), 2
Sometimes warnings are associated with a file and sometimes with the
patch as a whole. Update the regular expression to handle both cases,
even in emacs mode. Also add support for detecting new files.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/checkpatch.py | 11
Tidy up the extra 's' when there is only a single warning. Fix the empty
print statement also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 5 +++--
tools/patman/patchstream.py | 9 +
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/t
At present it is possible to put sign-off tags before the change log. This
works but then it is hard for patman to add its own tags to a commit. Also
if the commit has a Change-Id (e.g. for Gerrit) the commit becomes invalid
if there is anything after it.
Report a warning if patman tags are in the
Add tests that check that warnings are generated when expected.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 111 +---
tools/patman/main.py| 16 +-
tools/patman/patchstream.py | 2 +-
3 files changed, 116 inse
On balance it is easier to use an iterator here, particularly if we need
to insert lines due to new functionality. The only niggle is the need to
keep the previous iterator value around in one case.
Convert this test to use iter().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/pa
The current functional tests run most of patman. Add a smaller test that
just checks tag handling with the PatchStream class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 26 +-
tools/patman/patchstream.py | 23 +
This is not used. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 1 +
tools/patman/patchstream.py | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py
index bdeccafda0b..2290ba95e9
At present warnings are produced across the whole set of patches when
parsing them. It is more useful to associate each warning with the patch
(or commit) that generated it.
Attach warnings to the Commit object and move them out of PatchStream.
Also avoid generating duplicate warnings for the same
If the Series-xxx tag is not recognised patman currently reports a fatal
error. This is inconvenient if a new feature is later added to patman that
an earlier version does not support.
Report a warning instead, to allow the user to take action if needed, but
still allow operation to proceed.
Sign
Add a new function in PatchStream to collect the warnings generated while
parsing the stream. This will allow us to adjust the logic, such as
dealing with per-commit warnings.
Two of the warnings are in fact internal errors, so change them to raise
and exception.
Signed-off-by: Simon Glass
---
Drop a few arguments that are not used in functions.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 3a057fbd6c4..c5402dd
Add missing documentation and type information. Fix up some missing docs
on exceptions also.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 82 ++---
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/tools/patman
Rename these functions to lower case as per PEP8.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 6 +--
tools/patman/control.py | 6 +--
tools/patman/func_test.py | 6 +--
tools/patman/patchstream.py | 88
Some variables are too short or shadow other variables or types. Fix these
to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 52 ++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/tools/p
Update the indenting to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index ba0a1
Add a new Series-links tag to tell patman how to find the series in
patchwork. Each item is the series ID optionally preceded by the series
version that the link refers to. An empty version indicates this is the
latest series.
For example:
Series-links: 209816 1:203302
Documentation is added
These constants should use upper case. Update them to keep pylint3 happy.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/patchstream.py | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/tools/patman/patchstream.py b/t
One test still uses its own function for capturing output. Modify it to
use the standard one in test_util
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_t
This fixes all but the ones about too many variables/statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 76 +--
1 file changed, 58 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_test.py b/tools/patman
The current instructions are out-of-date. Fix them.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/README | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/patman/README b/tools/patman/README
index 52b2cf70bd0..7ede1068ee1 100644
--- a/tools/p
Fix up various indentation and other minor things to make pylint3 happier.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/patman/func_test.py | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/tools/patman/func_test.py b/tool
This operation was unfortunately broken by a recent change. It is now
necessary to use -i in addition to -n, if there are errors or warnings in
the patches.
Correct this by always showing the summary information.
Fixes: f3653759758 ("patman: Move main code out to a control module")
Signed-off-by:
29 matches
Mail list logo
