Re: [PATCH 3/3] Add Docker IP to whitelist for django-debug-toolbar

2016-08-08 Thread Andrew Donnellan
On 09/08/16 14:38, Daniel Axtens wrote: Yay for debugging with Docker. Signed-off-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Austr

Re: [PATCH v2 5/6] Allow use of Docker for development

2016-08-08 Thread Andrew Donnellan
ql: [Warning] Using a password on the command line interface can be insecure. db_1 | db_1 | /usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/* db_1 | db_1 | db_1 | MySQL init process done. Ready for start up. db_1 | Perhaps 5 seconds isn't enough? -- Andr

Re: [PATCH v2 5/6] Allow use of Docker for development

2016-08-04 Thread Andrew Donnellan
ash +elif [ "$1" == "--quick-test" ]; then +export PW_SKIP_BROWSER_TESTS=yes +python3 manage.py test +elif [ "$1" == "--test" ]; then +xvfb-run --server-args='-screen 0, 1024x768x16' python3 manage.py test +else # run whatever CMD is set to +$@ +fi -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v2 2/6] Fix test_login in test_user_browser.py

2016-08-04 Thread Andrew Donnellan
. Signed-off-by: Daniel Axtens <d...@axtens.net> All looks good. Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited _

Re: [PATCH v2 4/6] Put test db host and port into env variables.

2016-08-04 Thread Andrew Donnellan
On 04/08/16 16:10, Daniel Axtens wrote: This is preparation for a Docker-based dev environment. Signed-off-by: Daniel Axtens <d...@axtens.net> A good move generally. Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs,

Re: [PATCH 02/10] models: Add 'Series' model and related models

2016-07-18 Thread Andrew Donnellan
int. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> diff --git a/patchwork/rest_serializers.py b/patchwork/rest_serializers.py index af6b1b7..be55ad1 100644 --- a/patchwork/rest_serializers.py +++ b/patchwork/rest_serializers.py @@ -84,7 +84,7 @@ class PatchSe

<    1   2   3