I can ping ozlabs.org, but pwclient/xmlrpc and HTTP to
http://patchwork.ozlabs.org/ just wait indefinitely.
Brian
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On Fri, Oct 16, 2015 at 06:09:46PM +, Finucane, Stephen wrote:
> > One more ping? The context changed slightly but it still applies to my
> > tree OK. I can resend if needed.
> >
> > Thanks,
> > Brian
>
> LGTM
>
> Acked-by: Stephen Finucane
Ping :)
_
On Mon, Oct 19, 2015 at 01:56:35PM -0400, Mike Frysinger wrote:
> On 19 Oct 2015 09:57, Bernhard Reutner-Fischer wrote:
> > On October 17, 2015 4:25:54 AM GMT+02:00, Mike Frysinger wrote:
> > >On 16 Oct 2015 16:39, Brian Norris wrote:
> > >> commit_str = a
On Tue, Oct 20, 2015 at 11:39:02PM +, Finucane, Stephen wrote:
> > On Fri, Oct 16, 2015 at 11:00:22PM +0100, Stephen Finucane wrote:
[...]
> > > +[Unreleased]:
> > https://github.com/getpatchwork/patchwork/compare/v1.0.0...HEAD
> > > +[1.0.0]:
> > https://github.com/getpatchwork/patchwork/compa
Hi Stephen,
You asked for review, and there are a few pieces I'm qualified to
comment on :)
On Fri, Oct 16, 2015 at 11:00:22PM +0100, Stephen Finucane wrote:
> The CHANGELOG document should describe the high level changes of the
> project. This will provide a human-readable way for people to eval
...]]
pwclient update: error: Declining update with COMMIT-REF on multiple IDs
Signed-off-by: Brian Norris
---
v2: new in this series, per Mike's suggestion
patchwork/bin/pwclient | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/patchwork/bin/pwc
JECT] [ID [ID ...]]
positional arguments:
ID Patch ID
optional arguments:
--help show this help message and exit
-h HASH Lookup by patch hash
-p PROJECT Lookup patch in project
Signed-off-by: Brian Norris
---
v2: unchanged
patchwork/bin/pwclient | 67 +++
Just use dict.items(), since there are few fields and we don't really
care about the extra copying.
Signed-off-by: Brian Norris
Reviewed-by: Mike Frysinger
---
v2: unchanged
patchwork/bin/pwclient | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/patchwork/bin/pwcli
Previously, we required the -s flag for 'pwclient update'. But since we
allow updating up to 2 different fields ('archived' and 'state'), drop
the required flag, and just enforce that the user must provide -a, -s,
or both.
Signed-off-by: Brian Norris
---
v2:
* use
JECT] [ID [ID ...]]
positional arguments:
ID Patch ID
optional arguments:
--help show this help message and exit
-h HASH Lookup by patch hash
-p PROJECT Lookup patch in project
Signed-off-by: Brian Norris
---
patchwork/bin/pwclient | 67 +++-
Previously, we required the -s flag for 'pwclient update'. But since we
allow updating up to 2 different fields ('archived' and 'state'), drop
the required flag, and just enforce that the user must provide -a, -s,
or both.
Signed-off-by: Brian Norris
---
patchw
Just use dict.items(), since there are few fields and we don't really
care about the extra copying.
Signed-off-by: Brian Norris
---
patchwork/bin/pwclient | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/patchwork/bin/pwclient b/patchwork/bin/pwclient
index d2b95e5
On Fri, Oct 16, 2015 at 10:49:04PM +, Finucane, Stephen wrote:
> > (... and I see it was merged already. Cool.)
>
> I had reviewed (and have also been using) the patches 1[1] and 3[2] in
> the series since the first time they were sent. Had the same trivial
> comment about the second one but I
green on Python 2/3
compatibility. I've been runnning this (plus other patches) since you
first sent it out.
Acked-by: Brian Norris
There's still a little more low-hanging fruit for Python 3 compatbility
(I have a few mashed up patches for that still), but this is a good
start.
(... and I
tually works as intended.
>
> We also need to fix up a few latent print statements to make it work.
>
> Signed-off-by: Mike Frysinger
I've been running with a patch very similar to this for a while.
Acked-by: Brian Norris
Though a trivial comment below...
>
7;t mention the config file, so it can be
> a bit confusing what pwclient is complaining about when running.
>
> Signed-off-by: Mike Frysinger
Acked-by: Brian Norris
> ---
> patchwork/bin/pwclient | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff -
+ Mike
On Fri, Oct 16, 2015 at 06:11:52PM +, Finucane, Stephen wrote:
> > Ping on this series? There's some other oustanding mildly conflicting
> > patches for pwclient too (python3 support, from Mike Frysinger) too. I
> > can resend whatever you'd like, or rebase if you take other patches
> >
Hi Damien,
On Fri, Oct 16, 2015 at 01:43:04PM +0100, Damien Lespiau wrote:
> On Mon, Oct 12, 2015 at 01:54:24PM -0700, Brian Norris wrote:
> > Occasionally, I'll run across patches from the linux-mtd mailing list
> > that never show up on the ozlabs.org Patchwork instance. I d
Ping on this series? There's some other oustanding mildly conflicting
patches for pwclient too (python3 support, from Mike Frysinger) too. I
can resend whatever you'd like, or rebase if you take other patches
first.
Regards,
Brian
On Wed, May 20, 2015 at 11:36:01PM -0700, Brian No
One more ping? The context changed slightly but it still applies to my
tree OK. I can resend if needed.
Thanks,
Brian
On Wed, May 20, 2015 at 11:29:29PM -0700, Brian Norris wrote:
> On Sat, Nov 22, 2014 at 10:30:06PM -0800, Brian Norris wrote:
> > Any authenticated user should be able
Occasionally, I'll run across patches from the linux-mtd mailing list
that never show up on the ozlabs.org Patchwork instance. I don't
really have much visibility into this problem, so I wanted to reach
out here.
For one example: the patch shows up at the mailing list [1], but not
here on Patchwor
On Thu, May 21, 2015 at 03:27:04AM -0400, Mike Frysinger wrote:
> On 21 May 2015 00:06, Brian Norris wrote:
> > but anyway, after merging these and testing your changes on my system I
> > still see some major problems. I don't know much about Python 3, but you
> >
rgery, and is best left to another
> commit after this.
>
> Signed-off-by: Mike Frysinger
Reviewed-by: Brian Norris
With the following extra patch, this works OK for a few different
commands.
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 24
JECT] [ID [ID ...]]
positional arguments:
ID Patch ID
optional arguments:
--help show this help message and exit
-h HASH Lookup by patch hash
-p PROJECT Lookup patch in project
Signed-off-by: Brian Norris
---
IMO, this is altogether nicer. I've been using this
The 'version' argument is only necessary if we want to show version
information (and we do not).
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwcl
Previously, we required the -s flag for 'pwclient update'. But since we
allow updating up to 2 different fields ('archived' and 'state'), drop
the required flag, and just enforce that the user must provide -a, -s,
or both.
Signed-off-by: Brian Norris
---
Su
On Sat, Nov 22, 2014 at 10:30:06PM -0800, Brian Norris wrote:
> Any authenticated user should be able to change the properties of their
> own patches from the list view. They can already do so from the patch
> view and from pwclient.
>
> Now, authenticated users can perfor
Hi Jeremy,
On Sun, Mar 22, 2015 at 09:23:19PM +0800, Jeremy Kerr wrote:
> Hi Brian,
>
> >Signed-off-by: Brian Norris
>
> Thanks, applied.
Thanks! Are you going to update your public repo? I don't see anything
new at:
git://ozlabs.org/home/jk/git/patchwork
>
On Thu, Mar 12, 2015 at 05:32:22PM +0200, Jani Nikula wrote:
> On Thu, 12 Mar 2015, Brian Norris wrote:
> > On Thu, Mar 12, 2015 at 04:33:27PM +0200, Jani Nikula wrote:
> >> Add -a, --archive and -u, --unarchive options to update subcommand to
> >> allow archiving
On Thu, Mar 12, 2015 at 04:33:27PM +0200, Jani Nikula wrote:
> Add -a, --archive and -u, --unarchive options to update subcommand to
> allow archiving and unarchiving the patches.
>
> Signed-off-by: Jani Nikula
I already submitted a patch for this:
http://patchwork.ozlabs.org/patch/413357/
U
+ Yann for real
On Tue, Jan 13, 2015 at 10:40 PM, Bryan Hundven wrote:
> Bryce,
>
> On Thu, Jan 8, 2015 at 10:45 PM, Bryce Harrington
> wrote:
>> On Thu, Jan 08, 2015 at 07:54:41PM -0800, Bryan Hundven wrote:
>>> Hello list,
>>>
>>> While applying patches to my project with pwclient, I got thi
+ patchwork devs
On Mon, Dec 15, 2014 at 12:15:35PM +0100, Thomas Gleixner wrote:
> On Sat, 13 Dec 2014, One Thousand Gnomes wrote:
> > Is it the year for a Google summer of code project or similar to turn
> > patchwork into a proper patch management tool (one that collects the
> > patches, provid
On Mon, Nov 24, 2014 at 05:35:11PM +, Damien Lespiau wrote:
> I'd like to be able to assign reviewers to patches. That seems very
> close to what a delegate is today. Would anyone have objections if I
> just use Delegate as Reviewer?
I'm honestly not sure what Delegate is intended for. It seem
On Mon, Nov 24, 2014 at 4:12 PM, Brian Norris
wrote:
> On Mon, Nov 24, 2014 at 11:46:34PM +, Keller, Jacob E wrote:
>> Regarding argparse: You can do it by making both args optional and then
>> complaint if one isn't set afterwards.
>>
>> I never found
can write up the above solution sometime. Feel
free to take this patch as-is and I'll patch on top, barring any other
complaints about this patch series.
> Original message
> From: Brian Norris
> Date:11/22/2014 9:50 PM (GMT-08:00)
> To: patchwork@lists.ozlabs.o
On Sun, Nov 23, 2014 at 09:34:34AM +0100, Wolfram Sang wrote:
> displaying this patch is broken in the web interface:
>
> http://patchwork.ozlabs.org/patch/413335/
>
> Only one hunk is displayed as a patch, the other hunk as a comment.
>
> Would be great if somebody could have a look.
The patch
ultiple patches at a time (e.g., after
'select-all' on a bundle, or after selecting a few patches
individually). We'll print an error message to the page for any patches
which can't be updated (e.g., due to ownership).
This fixes a usability issue that has been reported a few times.
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 1 -
1 file changed, 1 deletion(-)
diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index 38d604e6173d..70d4f8293272 100755
--- a/apps/patchwork/bin/pwclient
+++ b/apps/patchwork/bin/pwclient
@@ -607,7 +607,6
ed), otherwise you'll
just get an empty list.
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index 70d4f8293272..0a477c26aa61 100755
--
Signed-off-by: Brian Norris
---
apps/patchwork/views/xmlrpc.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py
index b41ba0d2338d..1c4aa7d9e2c5 100644
--- a/apps/patchwork/views/xmlrpc.py
+++ b/apps/patchwork/views/xmlrpc.py
Hi,
I'm not too familiar with Django, but as of version 1.4, it looks like
the ADMIN_MEDIA_PREFIX configuration variable was dropped in favor of
STATIC_URL. So settings.py doesn't work out-of-the-box any more. I've
hacked around that in my own setup, but I'm not confident enough at the
moment to p
configurations, we should allow pwclient to specify the
project for these commands.
This adds the '-p PROJECT' option to:
* apply
* git-am
* info
* view
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 4
1 file changed, 4 insertions(+)
diff --git a/apps/patchwork/bin/pwcli
it-am, so that git's nice handling of fixup-and-continue workflow can
be used.
Signed-off-by: Brian Norris
---
apps/patchwork/bin/pwclient | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index 483330e5c876..
This will now show up in 'pwclient info'.
Signed-off-by: Brian Norris
---
apps/patchwork/views/xmlrpc.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py
index ca84c94cdc7c..6a561d34742c 100644
--- a/apps/patch
You shouldn't quote ('') the database name. MySQL complains if you do.
Signed-off-by: Brian Norris
---
docs/INSTALL | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/INSTALL b/docs/INSTALL
index d40ddd2e7d07..55662931dd94 100644
--- a/docs/INSTALL
+++
ore tools can use this output
as-is.
Example header:
From patchwork Fri Nov 21 18:24:29 2014
...
Signed-off-by: Brian Norris
---
apps/patchwork/views/xmlrpc.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py
IIUC, these items have all been completed. (The 'bundle' part of
--signoff is not completed, but that is represented in the previous
bullet.)
Signed-off-by: Brian Norris
---
docs/TODO | 4
1 file changed, 4 deletions(-)
diff --git a/docs/TODO b/docs/TODO
index 68832576a3c1..17
On Sat, Nov 08, 2014 at 07:08:18PM +, Damien Lespiau wrote:
> A small introduction first:
>
> I'm part of the i915 driver team and we'd like to use patchwork. However,
> there
> are a few things getting in the way: the bigger item is that patchwork doesn't
> scale very well above a certain th
Hi Doug,
Thanks for the quick response.
On Tue, Sep 23, 2014 at 11:03 AM, Doug Anderson wrote:
> On Tue, Sep 23, 2014 at 10:46 AM, Brian Norris
> wrote:
>> Does Patchwork ever change the name in the 'From' field of a patch?
>> Perhaps based on prior knowledge of
Does Patchwork ever change the name in the 'From' field of a patch?
Perhaps based on prior knowledge of a person's name?
I see that Ezequiel Garcia's last name is spelled "GarcĂa" (with an
accent mark) under "Submitter" on patches like this one:
http://patchwork.ozlabs.org/patch/391517/
And the
On Wed, Jul 23, 2014 at 09:10:08AM +0100, Ian Campbell wrote:
> On Tue, 2014-07-22 at 12:45 -0700, Brian Norris wrote:
>
> > Then some sort of grepping/regex/etc. can get you the patchwork ID from
> > the Message-ID. e.g.:
> >
> > pwclient list -m "$MESSAGEI
On Tue, Jul 22, 2014 at 09:50:51AM -0400, Tom Rini wrote:
> On Wed, Jul 16, 2014 at 07:49:09PM -0700, Brian Norris wrote:
> > On Thu, Jul 17, 2014 at 11:19:42AM +0900, Masahiro Yamada wrote:
> > > Does Patchwork have any good way to change the status
> > > of the whole s
On Tue, Jul 22, 2014 at 11:37:26AM +0900, Masahiro Yamada wrote:
> On Wed, 16 Jul 2014 19:49:09 -0700
> Brian Norris wrote:
> > On Thu, Jul 17, 2014 at 11:19:42AM +0900, Masahiro Yamada wrote:
> > > Does Patchwork have any good way to change the status
> > > of the
On Thu, Jul 17, 2014 at 11:19:42AM +0900, Masahiro Yamada wrote:
> When I change the status of patches,
> I always do it one by one.
>
> But it is painful if the series consists
> of a bunch of patches.
>
> Does Patchwork have any good way to change the status
> of the whole series?
You can use
Hi Jeremy,
On Mon, Jul 14, 2014 at 10:57:38AM +0800, Jeremy Kerr wrote:
> > Actually, I think the rev-parse serves as a little extra parameter
> > checking. Unless someone can pin a good reason one way or the other,
> > I'll stick with my original patch as I sent it. And I've been testing
> > that
On second (third?) thought...
On Thu, Jul 3, 2014 at 5:56 PM, Brian Norris
wrote:
> On Thu, Jul 3, 2014 at 5:49 PM, Jeremy Kerr wrote:
> ...
>>> @@ -39,7 +45,8 @@ set_patch_state()
>>> update_patches()
>>> {
>>> local cnt; cnt=0
>>> -
Looking at my own patch again...
On Thu, Jul 3, 2014 at 5:49 PM, Jeremy Kerr wrote:
...
>> Signed-off-by: Brian Norris
>> ---
>> tools/post-receive.hook | 9 -
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/post-re
patch update step.
This could be used, for example, to set:
EXCLUDE="refs/heads/upstream"
Then when you're ready to merge in new upstream code, you first update
the 'upstream' branch before pushing your own.
Signed-off-by: Brian Norris
---
tools/post-receive.hook |
Hi,
It looks like patchwork hashes are based purely on the contents of the
diff, without accounting for any metadata like email subject (including
version markers, like "PATCH v2") -- which is completely understandable.
But this means that the hash is not unique.
This becomes an issue for me when
Hi Pekon,
On Fri, Apr 18, 2014 at 09:15:03AM +, Pekon Gupta wrote:
> I was just wondering if there is a script which can automatically search the
> git tree and update state of patch on patchwork [1].
There is, sort of. Jeremy Kerr presented a few things at Linux Plumbers
a while back, and it
These tags aren't matched appropriately.
There may well be others, but I caught these by a mix of eyes and
Firefox's source viewer.
Signed-off-by: Brian Norris
---
Didn't test.
templates/patchwork/patch.html | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-
Hi,
I'm a new maintainer for the Linux-MTD subsystem, and I'm interested
in using the ozlabs patchwork system. How can I get permission to
modify patch statuses? I currently can only update my own patches.
Thanks,
Brian
___
Patchwork mailing list
Patchw
Peter Korsgaard sunsite.dk> writes:
> Since this morning, pwclient errors out with something like:
>
> ./pwclient list
> Traceback (most recent call last):
...
> xmlrpclib.Fault: :'WSGIRequest' object has no
> attribute 'raw_post_data'">
>
> Did something change?
I just tried to use pwclient fo
63 matches
Mail list logo