Re: [PATCH] uwsgi: Add python plugin

On 15 Jul 15:42, Russell Currey wrote: > Given the documentation suggests using Ubuntu, and any Debian derivative > requires manually specifying plugins in uwsgi, add the python27 plugin to > the example uwsgi settings file. > > Signed-off-by: Russell Currey Good catch.

Re: [PATCH 00/25] Rework tests

On 30 Jun 10:38, Finucane, Stephen wrote: > On 29 Jun 12:12, Andy Doan wrote: > > On 06/23/2016 04:53 PM, Stephen Finucane wrote: > > >There are a couple of issues with the tests that need resolving. > > > > > >* The tests make extensive use of the models, as on

Re: [PATCH 00/25] Rework tests

On 29 Jun 12:12, Andy Doan wrote: > On 06/23/2016 04:53 PM, Stephen Finucane wrote: > >There are a couple of issues with the tests that need resolving. > > > >* The tests make extensive use of the models, as one would expect. > > However, how these models are created varies significantly. In a

Re: [PATCH 5/5] templates: Display '[owner]/[context]' for checks

On 27 Jun 14:01, Andy Doan wrote: > On 06/24/2016 11:28 AM, Stephen Finucane wrote: > >This is useful for highlighting ownership of a check. > > > >Signed-off-by: Stephen Finucane > > Reviewed-by: Andy Doan ...and merged.

Re: [PATCH 3/5] models: Return QuerySet from 'Patch.checks'

On 24 Jun 17:28, Stephen Finucane wrote: > Previously this returned a list. However, a QuerySet is more flexible > and is required to provide a generic check endpoint at some point in > the future. > > Signed-off-by: Stephen Finucane > Reviewed-by: Andy Doan

Re: [PATCH 4/5] models: Don't group checks with different owners

On 24 Jun 17:28, Stephen Finucane wrote: > This prevents CIs from overriding the results of another CI by using > the same context. > > Signed-off-by: Stephen Finucane > Reviewed-by: Andy Doan Merged.

Re: parsemail.sh failed

On 28 Jun 14:33, WEN Pingbo wrote: > Thanks, Finucane > > The Django 1.8.13 works, previous version I used is Django 1.9.7. Good to hear. I'm working on a fix and should have this released in the next few weeks. Let me know if you have any issues in the interim. Stephen

Re: [PATCH v6 00/10] REST API support

On 16 Jun 16:13, Andy Doan wrote: > This patchset is inspired by the work done by Damien Lespiau. It creates > a REST API based on the original spec RFC'd by Stephen Finucane. The > only thing I know of that's missing from the patch set are bundles. I > think over time the Series support will make

Re: [PATCH v6 05/10] REST: Add Persons to the API

On 16 Jun 16:13, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Reviewed-by: Stephen Finucane

Re: [PATCH v6 07/10] REST: Add Patch Checks to the API

On 16 Jun 16:13, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects. >

Re: [PATCH v6 04/10] REST: Add Users to the API

On 16 Jun 16:13, Andy Doan wrote: > This exports user objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Reviewed-by: Stephen Finucane ...after accounting for the

Re: [PATCH 00/10] Add series support

On 16 Jun 16:42, Russell Currey wrote: > On Thu, 2016-06-16 at 09:21 +1000, Andrew Donnellan wrote: > > On 15/06/16 19:07, Finucane, Stephen wrote: > > > > > > The best option we might have, if per-series reporting is really > > > necessary, is to allow Check

Re: [PATCH 1/5] models: Use non-null slugs for 'Check.name'

On 24 Jun 17:28, Stephen Finucane wrote: > The schema for 'Check' defines 'Check.name' as a 'CharField'. This is > less than ideal as names with spaces and special characters can't be > represented cleanly in URLs etc. We should use 'SlugField' instead. > > Signed-off-by: Stephen Finucane

Re: [PATCH 07/10] templates: Integrate series support

On 23 Jun 13:26, Andy Doan wrote: > On 06/13/2016 05:41 AM, Stephen Finucane wrote: > >Integrate support for series in the web UI. This is rather > >straightforward, the only significant change being the addition of a > >filter for series filtering. > > > >Signed-off-by: Stephen Finucane

Re: [PATCH 05/10] parsemail: Handle series sent "in-reply-to"

On 23 Jun 13:24, Andy Doan wrote: > On 06/13/2016 05:41 AM, Stephen Finucane wrote: > >Take a series, "v2", sent as a reply to another, "v1", like so: > > > > [PATCH 0/3] A cover letter > > [PATCH 1/3] The first patch > > ... > > [PATCH v2 0/3] A cover letter > >

Re: [PATCH 04/10] parsemail: Handle 'xxx (v2)' style messages

On 23 Jun 13:24, Andy Doan wrote: > On 06/13/2016 05:41 AM, Stephen Finucane wrote: > >Some emails are received in the above format. Might as well support > >them. > > > >Signed-off-by: Stephen Finucane > > Reviewed-by: Andy Doan > > >--- > >

Re: [PATCH 03/10] parsemail: Add series parsing

On 23 Jun 13:23, Andy Doan wrote: > On 06/13/2016 05:41 AM, Stephen Finucane wrote: > >It is now possible to parse and store series, so do just that. > >The parsing at the moment is based on both RFC822 headers and > >subject lines. > > > >Signed-off-by: Stephen Finucane

Re: [PATCH v6 03/10] REST: Add Projects to the API

On 16 Jun 16:13, Andy Doan wrote: > This exports projects via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > Signed-off-by: Andy

Re: [PATCH v6 06/10] REST: Add Patches to the API

On 16 Jun 16:13, Andy Doan wrote: > This exposes patches via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > NOTE: Patch.save was

Re: [PATCH v5 00/10] REST API support

On 09 Jun 17:08, Andy Doan wrote: > On 06/02/2016 09:26 AM, Finucane, Stephen wrote: > >On 26 May 20:12, Andy Doan wrote: > >>This patchset is inspired by the work done by Damien Lespiau. It creates > >>a REST API based on the original spec RFC'd by Stephen Finucane

Re: [PATCH v5 00/10] REST API support

On 26 May 20:12, Andy Doan wrote: > This patchset is inspired by the work done by Damien Lespiau. It creates > a REST API based on the original spec RFC'd by Stephen Finucane. The > only thing I know of that's missing from the patch set are bundles. I > think over time the Series support will make

Re: [PATCH v5 06/10] REST: Add Patches to the API

On 26 May 20:12, Andy Doan wrote: > This exposes patches via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > NOTE: Patch.save was

Re: [PATCH v5 05/10] REST: Add Users to the API

On 26 May 20:12, Andy Doan wrote: > This exports user objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan There's some dead code and I'd personally like to rename a field, but I'm happy to sign

Re: [PATCH v5 05/10] REST: Add Users to the API

On 26 May 20:12, Andy Doan wrote: > This exports user objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Pretty sure I sent this reply already, but I don't see it in my sent folder... I'm OK

Re: [PATCH v5 03/10] REST: Add Projects to the API

On 02 Jun 11:45, Finucane, Stephen wrote: > On 26 May 20:12, Andy Doan wrote: > > This exports projects via the REST API. > > > > Security Constraints: > > * Anyone (logged in or not) can read all objects. > > * No one can create/delete objects. > > * Pr

Re: [PATCH v5 04/10] REST: Add Persons to the API

On 26 May 20:12, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan One item below, which I can fix myself if I apply as is not blocking. Reviewed-by:

Re: [PATCH v5 03/10] REST: Add Projects to the API

On 26 May 20:12, Andy Doan wrote: > This exports projects via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > Signed-off-by: Andy

Re: [PATCH v4 09/10] REST API: expose patch.checks

On 20 May 14:17, Andy Doan wrote: > Signed-off-by: Andy Doan Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v4 07/10] REST: Add Patch Checks to the API

On 20 May 14:17, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects. >

Re: [PATCH v4 05/10] REST: Add Users to the API

On 20 May 14:17, Andy Doan wrote: > This exports user objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan This needs more data to be useful, IMO. > --- > patchwork/rest_serializers.py| 8

Re: [PATCH v4 04/10] REST: Add Persons to the API

On 20 May 14:17, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Reviewed-by: Stephen Finucane

RE: [PATCH v3 06/10] REST: Add Patch Checks to the API

> On 19 May 10:26, Finucane, Stephen wrote: > > On 18 May 22:30, Andy Doan wrote: > > > This exports patch checks via the REST API. > > > > > > The drf-nested-routers package is used to handle the fact Checks are > > > nested under a Patch. > > &g

Re: [PATCH v3 06/10] REST: Add Patch Checks to the API

On 19 May 10:26, Finucane, Stephen wrote: > On 18 May 22:30, Andy Doan wrote: > > This exports patch checks via the REST API. > > > > The drf-nested-routers package is used to handle the fact Checks are > > nested under a Patch. > > > > Security Constraint

Re: [PATCH v3 10/10] REST: Allow projects to be retrieved by linkname

On 18 May 22:31, Andy Doan wrote: > Building a user-friendly CLI becomes difficult when project-ids are > required. It also makes it almost impossible to work with the current > format of the .pwclientrc file. > > Signed-off-by: Andy Doan Reviewed-by: Stephen Finucane

Re: [PATCH v3 06/10] REST: Add Patch Checks to the API

On 18 May 22:30, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects. >

Re: [PATCH v3 05/10] REST: Add Patches to the API

On 18 May 22:30, Andy Doan wrote: > This exposes patches via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > NOTE: Patch.save was

Re: [PATCH v3 04/10] REST: Add Persons to the API

On 18 May 22:30, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users Question: we currently expose all users from 'api.py' for use by the in Selectize auto-complete widgets in the patch list page. I get the

Re: [PATCHv2 10/10] REST: Allow projects to be retrieved by linkname

On 18 May 22:25, Andy Doan wrote: > On 05/17/2016 08:33 AM, Finucane, Stephen wrote: > >On 10 May 17:39, Andy Doan wrote: > >>Building a user-friendly CLI becomes difficult when project-ids are > >>required. It also makes it almost impossible to work with the current &g

Re: [PATCHv2 02/10] REST: Add base configuration hooks for a REST API

On 17 May 13:17, Finucane, Stephen wrote: > On 10 May 17:39, Andy Doan wrote: > > This adds the ability to expose a REST API based on the Django REST > > framework project. Since this project isn't packaged in most current > > distributions, we ensure that its both install

Re: sort order lost when updating patches

On 16 May 16:03, Bjorn Helgaas wrote: > On Sat, May 14, 2016 at 7:21 AM, Len Brown wrote: > > On Wed, May 11, 2016 at 2:36 PM, Bjorn Helgaas wrote: > >> On Tue, Apr 5, 2016 at 11:27 AM, Bjorn Helgaas wrote: > >>> This is on

Re: [PATCHv2 09/10] REST: Add query parameters to filter patches by

On 10 May 17:39, Andy Doan wrote: > This adds generic filtering support to the PatchworkViewSet as well as > useful filtering options for listing patches. > > DRF has some filter capabilities, but they can really slow down the web > interface for large data sets and are a little complex. This

Re: [RFC 00/11] REST API support

On 10 May 17:30, Andy Doan wrote: > On 05/09/2016 09:16 AM, Finucane, Stephen wrote: > >On 15 Apr 13:23, Andy Doan wrote: > >>This patchset is inspired by the work done by Damien Lespiau. It creates > >>a REST API based on the original spec RFC'd by Stephen Finucane

Re: [RFC 07/11] REST: Add Patch Checks to the API

On 12 May 14:04, Andy Doan wrote: > On 05/11/2016 03:57 AM, Finucane, Stephen wrote: > >On 10 May 17:30, Andy Doan wrote: > >>On 05/09/2016 08:58 AM, Finucane, Stephen wrote: > >>>On 15 Apr 13:24, Andy Doan wrote: > > >>>>+patches_router = Nest

Re: [PATCHv2 10/10] REST: Allow projects to be retrieved by linkname

On 10 May 17:39, Andy Doan wrote: > Building a user-friendly CLI becomes difficult when project-ids are > required. It also makes it almost impossible to work with the current > format of the .pwclientrc file. > > Signed-off-by: Andy Doan Some comments below but nothing

Re: [PATCHv2 06/10] REST: Add Patch Checks to the API

On 17 May 14:14, Finucane, Stephen wrote: > On 10 May 17:39, Andy Doan wrote: > > This exports patch checks via the REST API. > > > > The drf-nested-routers package is used to handle the fact Checks are > > nested under a Patch. > > > > Security Constraint

Re: [PATCHv2 05/10] REST: Add Patches to the API

On 17 May 14:08, Finucane, Stephen wrote: > On 10 May 17:39, Andy Doan wrote: > > This exports patches via the REST API. > > supernit: s/exports/exposes :) > > > Security Constraints: > > * Anyone (logged in or not) can read all objects. > > * No one can c

Re: [PATCHv2 08/10] REST API: make patch.state a string rather than int

On 10 May 17:39, Andy Doan wrote: > The int value isn't very useful and the goal is to move this to an enum > over time. > > Signed-off-by: Andy Doan Some questions over performance below. Stephen > --- > patchwork/rest_serializers.py| 21 - >

Re: [PATCHv2 07/10] REST: Add Patch.mbox_url

On 10 May 17:39, Andy Doan wrote: > Provide a URL to the raw patch. This removes previous functionality > added to create_model_serializer thats no longer needed. What functionality is removed? Are you referencing the previous patch? If so, don't bother :) > Signed-off-by: Andy Doan

Re: [PATCHv2 06/10] REST: Add Patch Checks to the API

On 10 May 17:39, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects.

Re: [PATCHv2 04/10] REST: Add Persons to the API

On 10 May 17:39, Andy Doan wrote: > This exports person objects via the REST API. > > Security Constraints: > * The API is read-only to authenticated users > > Signed-off-by: Andy Doan Still unsure about including 'person.user.id'. See comment below. Stephen > --- >

Re: [PATCHv2 03/10] REST: Add Projects to the API

On 10 May 17:39, Andy Doan wrote: > This exports projects via the REST API. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can create/delete objects. > * Project maintainers are allowed to update (ie "patch" >attributes) > > Signed-off-by: Andy

Re: [PATCHv2 02/10] REST: Add base configuration hooks for a REST API

On 10 May 17:39, Andy Doan wrote: > This adds the ability to expose a REST API based on the Django REST > framework project. Since this project isn't packaged in most current > distributions, we ensure that its both installed and enabled before > trying to use it. > > Signed-off-by: Andy Doan

Re: [RFC 07/11] REST: Add Patch Checks to the API

On 10 May 17:30, Andy Doan wrote: > On 05/09/2016 08:58 AM, Finucane, Stephen wrote: > >On 15 Apr 13:24, Andy Doan wrote: > > >>+ > >>+def test_create(self): > >>+"""Ensure creations can be performed by user of pa

Re: [RFC 09/11] REST: Add query parameters to filter patches by

On 15 Apr 13:24, Andy Doan wrote: > This adds generic filtering support to the PatchworkViewSet as well as > useful filtering options for listing patches. > > DRF has some filter capabilities, but they can really slow down the web > interface for large data sets and are a little complex. This

Re: [RFC 07/11] REST: Add Patch Checks to the API

On 15 Apr 13:24, Andy Doan wrote: > This exports patch checks via the REST API. > > The drf-nested-routers package is used to handle the fact Checks are > nested under a Patch. > > Security Constraints: > * Anyone (logged in or not) can read all objects. > * No one can update/delete objects. >

Re: [RFC 08/11] REST: Add Patch mbox to the API

On 15 Apr 13:24, Andy Doan wrote: > This allows a user to download the Patch in the MBOX format directly > from the API. > > Security Constraints: > * Read-only to everyone I don't know what the spec says, but I don't think this endpoint is necessary. We already have a way to get diffs and

Re: [RFC 02/11] REST: Add base configuration hooks for a REST API

On 09 May 14:15, Finucane, Stephen wrote: > On 15 Apr 13:23, Andy Doan wrote: > > This adds the ability to expose a REST API based on the Django REST > > framework project. Since this project isn't packaged in most current > > distributions, we ensure that its both install

Re: [RFC 04/11] REST: Introduce some helper code

On 15 Apr 13:24, Andy Doan wrote: > DRF lends its self to a lot of repetitive code like: > > Serializer: >Meta: > model = Foo > > ViewSet: > queryset = Foo.objects > > > This reduces the amount of boiler plate code needed for most of our > endpoints so that its easier to audit.

Re: [RFC 02/11] REST: Add base configuration hooks for a REST API

On 15 Apr 13:23, Andy Doan wrote: > This adds the ability to expose a REST API based on the Django REST > framework project. Since this project isn't packaged in most current > distributions, we ensure that its both installed and enabled before > trying to use it. > > Signed-off-by: Andy Doan

Re: [PATCH 2/2] post-receive: Use correct default installation path

On 06 May 14:36, Sven Eckelmann wrote: > The documentation recommends to use /opt/patchwork instead of > /srv/patchwork since version 1.1. This change should be reflected in the > PWDIR variable of the post-receive hook. > > Signed-off-by: Sven Eckelmann Nice catch.

Re: [PATCH 1/2] patchwork/templates: Fix path to delete button image

On 06 May 14:36, Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann Let's merge this as it does in fact resolve a bug. However, a longer term fix might be to remove these images in favour of glyphicons, as seen in 'a8c5bf6'. If you could do this, I'd be very grateful.

Re: [PATCH 4/6] tests: Fix spelling mistakes and typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 5/6] pwclient: Fix typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 6/6] parsemail: Fix typo

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 4/6] tests: Fix spelling mistakes and typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 5/6] pwclient: Fix typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 6/6] parsemail: Fix typo

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 3/6] templates: Fix spelling mistakes and typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 1/6] docs: Fix spelling mistakes and typos

On 02 May 10:08, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Merged. Thanks for the change, and sorry this took so long to get to - I've been away on business travel recently. Stephen ___ Patchwork mailing list

Re: [PATCH] pep8: Resolve issues in settings file

On 08 Apr 16:26, Stephen Finucane wrote: > Introduced in '2822854'. > > Signed-off-by: Stephen Finucane Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v2 09/11] parsemail: Add cover letter parsing

On 08 Apr 13:07, Andy Doan wrote: > On 04/01/2016 09:57 AM, Stephen Finucane wrote: > >Add support for both cover letters and comments on cover letters. This > >works using the following heuristics: > > > >* The message contains a '[0/n]' marker tag in the subject > >* The message is the root

Re: [RFC 1/3] models: Convert functions to properties

On 08 Apr 14:50, Andy Doan wrote: > On 04/01/2016 11:14 AM, Stephen Finucane wrote: > >A number of models contain functions that are, semantically speaking, > >actually properties. Mark them as such. > > > >This also includes a fix for a missing python_2_unicode_compatible > >decorator > > I'm

Re: [RFC 2/3] models: Add series-related properties to models

On 08 Apr 14:50, Andy Doan wrote: > On 04/01/2016 11:14 AM, Stephen Finucane wrote: > >The properties will be used to build series from patches in > >a follow-on patch. > > > >TODO add missing tests > > > >Signed-off-by: Doug Anderson > > >+@staticmethod > >+def

Re: [PATCH v2] settings: Remove hard coded login url value

On 08 Apr 14:39, Stephen Finucane wrote: > From: Michael Wood > > Use the url name for the login page rather than a hard coded value > this means that if you have patchwork in a prefix it will redirect > to the correct location without any additional configuration. > >

Re: [PATCH] tests: Fix issue with user profile page test

On 08 Apr 14:37, Stephen Finucane wrote: > The title of the user profile page was changed in 'b3d1917', but the > test wasn't updated to reflect this. Fix this. > > Signed-off-by: Stephen Finucane Merged. ___ Patchwork

Re: [PATCH v4 3/3] models: Add Cover Letter support

On 25 Mar 17:29, Stephen Finucane wrote: > Cover letters contain useful information that should not be discarded. > Store them. > > This is a prerequisite of series support. > > Signed-off-by: Stephen Finucane Merged. ___

Re: [PATCH v4 1/3] utils: Rework how notifications are selected

On 25 Mar 17:29, Stephen Finucane wrote: > The current method of filtering valid patches from invalid ones is > effective, but incompatible with forthcoming rework that splits > the 'Patch' model into two models. Rework this, removing the > soon-to-be non-existant 'User.patch' reference. > >

Re: [PATCH v4 2/3] models: Split Patch into two models

On 25 Mar 17:29, Stephen Finucane wrote: > There are a lot of similarities between cover letters and patches: so > many, in fact, that it would be helpful to occasionally treat them as > the same thing. Achieve this by extracting out the fields that would be > shared between a Patch and a

Re: [PATCH 9/9] ui: Rework the project list page

On 30 Mar 22:04, Stephen Finucane wrote: > Make a number of changes to the UI page, including: > > * Show four items per row, instead of three > * Remove the minimum padding of each element in favour of the clearfix > * Show the web URL and web SCM values buttons in the bottom of each > project

Re: [PATCH 8/9] ui: Add user bundle link into the dropdown menu

On 30 Mar 22:04, Stephen Finucane wrote: > Since the link to TODOs (reviews pending) can already be seen there, > it makes sense to link to bundles also. > > A divider is added to logically group these elements. > > Signed-off-by: Stephen Finucane Merged.

Re: [PATCH 7/9] ui: Redirect to '/' after logout

On 30 Mar 22:04, Stephen Finucane wrote: > It's already obvious that the user has logged out, so don't bother > displaying a message saying as much. Redirect to the home page instead. > > Signed-off-by: Stephen Finucane Merged.

Re: [PATCH 5/9] ui: Cleanup the navbar "brand"

On 30 Mar 22:04, Stephen Finucane wrote: > The text shown in the top-left corner of a navbar, known as the "brand" > in Bootstrap parlance, normally brings you to the homepage. However, > when viewing patches or details about a project this name of this > project is included in this link. This

Re: [PATCH 6/9] ui: Update page titles

On 30 Mar 22:04, Stephen Finucane wrote: > Since the page title is displayed in the navbar, they must be limited > length and contain little to no special formatting. Do this. > > Signed-off-by: Stephen Finucane Merged. ___

Re: [PATCH 1/9] settings: Help caching with content-aware static file names

On 30 Mar 22:04, Stephen Finucane wrote: > From: Damien Lespiau > > If we always serve the "style.css" file, even when its content changes, > we run into the situation where the browser (or any HTTP aware middle > man) will cache the file and not download a newer

Re: [PATCH 2/9] ui: Higher density of patches

On 30 Mar 22:04, Stephen Finucane wrote: > THe Bootstrap'ification of Patchwork signficantly reduced the > information density of the patch list page, but this results in less > patches per page. Resolve this by reducing the padding on each row. > > Signed-off-by: Stephen Finucane

Re: [PATCH 3/9] ui: Center-align the checkboxes

On 30 Mar 22:04, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 2/2] xmlrpc: Treat negative max_count as meaning "return last N results"

On 31 Mar 15:08, Damien Lespiau wrote: > On Fri, Feb 05, 2016 at 05:21:20PM +, Stephen Finucane wrote: > > @@ -602,6 +607,8 @@ def patch_list(filt=None): > > > > if max_count > 0: > > return list(map(patch_to_dict, patches[:max_count])) > > +elif max_count < 0:

Re: [PATCH 1/2] wsgi: Move wsgi file to expected location

On 31 Mar 15:50, Damien Lespiau wrote: > On Fri, Feb 05, 2016 at 05:35:37PM +, Stephen Finucane wrote: > > Django places a wsgi.py file in the root of each application's > > directory. Do this, adding a symlink to preserve existing > > operation for users. > > Even if the commit message

Re: [PATCH 4/4] tools: Use 'Patchwork' consistently

On 25 Mar 21:33, Stephen Finucane wrote: > The docs referred to both 'patchwork' and 'Patchwork'. Use the title > case variant consistently. > > Signed-off-by: Stephen Finucane Merged. ___ Patchwork mailing list

Re: [PATCH 3/4] docs: Refer to 'Patchwork' consistently

On 25 Mar 21:33, Stephen Finucane wrote: > The docs referred to both 'patchwork' and 'Patchwork'. Use the title > case variant consistently. > > Signed-off-by: Stephen Finucane Merged. ___ Patchwork mailing list

Re: [PATCH 2/4] templates: Use 'Patchwork' consistently

On 25 Mar 21:33, Stephen Finucane wrote: > The templates referred to both 'patchwork' and 'Patchwork'. Use the > title case variant consistently. > > Signed-off-by: Stephen Finucane Merged. ___ Patchwork mailing list

Re: [PATCH v2 1/6] models: Add missing unicode decorator

On 25 Mar 17:27, Stephen Finucane wrote: > This is required for Python 3 compatibility. > > Signed-off-by: Stephen Finucane Merged this patch, though I'm going to wait a little longer for the remainder. Stephen ___

Re: [PATCH 1/4] README: Correct some typos

On 25 Mar 21:33, Stephen Finucane wrote: > - The two presentation links were backwards > - The quickstart section's code blocks weren't indented correctly > > Signed-off-by: Stephen Finucane Merged this patch, though I'm going to wait a little longer for the

Feedback on recent Patchwork update

David Miller recently posted a comprehensive review [1] of the latest version of Patchwork available on 'ozlabs.org' [2], and it's been a bit of an eye opener*. This instance of Patchwork has gone from v0.9.0 to v1.1.0, and the major version increase is mostly a reflection on the scale of a UI

Re: [PATCH] parsemail: Fix return value for find_content error case

On 28 Mar 11:31, Jeremy Kerr wrote: > If we fail to decode a message payload, we'll fail with the following: > > Traceback (most recent call last): > File "./patchwork/bin/parsemail.py", line 563, in > sys.exit(main(sys.argv)) > File "./patchwork/bin/parsemail.py", line 553, in

Re: [PATCH 3/4] Update permissions on grant-all scripts

On 27 Mar 12:53, Jeremy Kerr wrote: > We need access to Check & Delegationrule. > > Signed-off-by: Jeremy Kerr Acked-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH 4/4] templates: don't emit tags for empty URLs, allow both web_url & webscm_url

On 27 Mar 12:53, Jeremy Kerr wrote: > Rather than always outputting one of web_url or webscm_url, only output > when these are present. This prevents us from emitting empty links if > both are missing. > > Signed-off-by: Jeremy Kerr Merged. I'm going to class this as a bug also

Re: [PATCH 3/4] Update permissions on grant-all scripts

On 27 Mar 12:53, Jeremy Kerr wrote: > We need access to Check & Delegationrule. > > Signed-off-by: Jeremy Kerr Merged and backported. Stephen PS: Must investigate if these permissions are something we could offload to the migrations engine at some point.

Re: [PATCH 2/4] parsemail: Fix default value of verbosity argument

On 27 Mar 12:53, Jeremy Kerr wrote: > With the current parsemail.py, the default value for the verbosity > argument does not exist in the VERBOSITY_LEVELS dict, so we get: > > Traceback (most recent call last): > File "./patchwork/bin/parsemail.py", line 569, in >

Re: [PATCH 1/4] parsemail.sh: Always return a zero exit status

On 27 Mar 12:53, Jeremy Kerr wrote: > This reverts changes to parsemail.sh introduced by > cbe992d84fba57831d44afb3a21cdf83454018b2. > > When parsemail is used as a delivery command from a mail server like > postfix (as it is intended to be), a non-zero exit code will cause a > bounce message to

  1   2   3   4   >