Re: [PATCH v4 0/4] Store the 'actor' responsible for events

On Sun, Dec 1, 2019 at 1:11 PM Stephen Finucane wrote: > Thanks for the quick turnaround on this. I squashed patches 3 and 4, > added a release note, fixed a minor issue with the schema documentation > and pushed everything. It will form part of Patchwork v2.2 which I'm > hoping to get out this

[PATCH v4 1/4] models.Event: Add the user responsible for the event

This allows using the events as a kind of audit log, to see how a patch came to its current state/delegate. Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Reviewed-by: Stephen Finucane --- patchwork/migrations/0037_event_actor.py | 21 + patchwork/models.py

[PATCH v4 0/4] Store the 'actor' responsible for events

up the actor in patch-created, patch-completed, and series-completed events (as there are triggered by emails). - Add patch #4 to allow filtering events by actor. Have fun! ...Johan Johan Herland (4): models.Event: Add the user responsible for the event Include the responsible actor

[PATCH v4 2/4] Include the responsible actor in applicable events

leave the actor as None/NULL. The same argumen also applies to the cover-created and series-created events. Closes: #73 Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- patchwork/models.py| 6 +- patchwork/signals.py | 3 +++ patchwork/tests/test_events.py | 7

[PATCH v4 3/4] /api/events: Add 'actor' field to generated JSON

Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Acked-by: Daniel Axtens --- docs/api/schemas/latest/patchwork.yaml | 6 ++ docs/api/schemas/patchwork.j2 | 8 docs/api/schemas/v1.2/patchwork.yaml | 6 ++ docs/usage/overview.rst| 3

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

On Thu, Nov 14, 2019 at 6:31 AM Andrew Donnellan wrote: > On 17/10/19 9:44 am, Johan Herland wrote: > > We want to use the events as an audit log. An important part of this is > > recording _who_ made the changes that the events represent. > > > > To accomplish this,

Re: [PATCH v3 0/3] Store the 'actor' responsible for events

On Fri, Oct 18, 2019 at 8:29 AM Daniel Axtens wrote: > Johan Herland writes: > > > The V4L project (https://patchwork.linuxtv.org) uses patch states and > > delegates extensively to track progress. We want an audit log to keep > > track of the changes made to these patch

[PATCH v3 0/3] Store the 'actor' responsible for events

: - Update docs/usage/overview.rst - Acked-by: Daniel Have fun! ...Johan Johan Herland (3): models.Event: Add the user responsible for the event Include the responsible actor in applicable events /api/events: Add 'actor' field to generated JSON docs/api/schemas/latest/patchwork.yaml

[PATCH v3 3/3] /api/events: Add 'actor' field to generated JSON

Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Acked-by: Daniel Axtens --- docs/api/schemas/latest/patchwork.yaml | 6 ++ docs/api/schemas/patchwork.j2 | 8 docs/api/schemas/v1.2/patchwork.yaml | 6 ++ docs/usage/overview.rst| 3

[PATCH v3 2/3] Include the responsible actor in applicable events

as such, so we simply leave the actor as None/NULL. Closes: #73 Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- patchwork/models.py| 6 +- patchwork/signals.py | 10 -- patchwork/tests/test_events.py | 7 +++ 3 files changed, 20 insertions(+), 3

Re: [PATCH v2 3/3] /api/events: Add 'actor' field to generated JSON

On Wed, Oct 9, 2019 at 7:59 AM Daniel Axtens wrote: > Johan Herland writes: > > Cc: Mauro Carvalho Chehab > > Signed-off-by: Johan Herland > > --- > > docs/api/schemas/latest/patchwork.yaml | 6 ++ > > docs/api/schemas/patchwork.j2 | 8 ++

Re: [PATCH v2 2/3] Include the responsible actor in applicable events

On Wed, Oct 9, 2019 at 8:04 AM Daniel Axtens wrote: > Johan Herland writes: > > We want to use the events as an audit log. An important part of this is > > recording _who_ made the changes that the events represent. > > > > To accomplish this, we need to know the curr

[PATCH v2 1/3] models.Event: Add the user responsible for the event

This allows using the events as a kind of audit log, to see how a patch came to its current state/delegate. Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Reviewed-by: Stephen Finucane --- patchwork/migrations/0037_event_actor.py | 21 + patchwork/models.py

[PATCH v2 0/3] Store the 'actor' responsible for events

'actor' set. There is still an open discussion as to whether the strategy used in patch #2 to determine the actor and forward it to the event creation, is the way we want to go. Have fun! ...Johan Johan Herland (3): models.Event: Add the user responsible for the event Include

[PATCH v2 3/3] /api/events: Add 'actor' field to generated JSON

Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- docs/api/schemas/latest/patchwork.yaml | 6 ++ docs/api/schemas/patchwork.j2 | 8 docs/api/schemas/v1.2/patchwork.yaml | 6 ++ patchwork/api/event.py | 10 +++--- patchwork/tests/api

[PATCH v2 2/3] Include the responsible actor in applicable events

as such, so we simply leave the actor as None/NULL. Closes: #73 Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- patchwork/models.py| 6 +- patchwork/signals.py | 10 -- patchwork/tests/test_events.py | 7 +++ 3 files changed, 20 insertions(+), 3

Re: [PATCH 3/3] /api/events: Add 'user' field to generated JSON

On Mon, Oct 7, 2019 at 5:55 PM Stephen Finucane wrote: > On Mon, 2019-10-07 at 00:57 +0200, Johan Herland wrote: > > Cc: Mauro Carvalho Chehab > > Signed-off-by: Johan Herland > > This looks pretty good and should stay almost the same even if earlier > patches in the s

Re: [PATCH 2/3] Include the responsible user in patch-related events

On Mon, Oct 7, 2019 at 6:06 PM Stephen Finucane wrote: > On Mon, 2019-10-07 at 00:57 +0200, Johan Herland wrote: > > We want to use the events as an audit log of patch state/delegate > > changes. An important part of this is recording _who_ changed the > > patch state/de

Re: [PATCH 1/3] models.Event: Add the user responsible for the event

On Mon, Oct 7, 2019 at 5:57 PM Stephen Finucane wrote: > On Mon, 2019-10-07 at 00:57 +0200, Johan Herland wrote: > > This allows using the events as a kind of audit log, to see how a > > patch came to its current state/delegate. > > > > Cc: Mauro Carvalho Chehab >

[PATCH 2/3] Include the responsible user in patch-related events

, and is the simplest place to put this information, so we simply add an ._edited_by attribute (which fortunately is not detected as a persistent database field by Django). Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- patchwork/models.py| 6 +- patchwork/signals.py

[PATCH 1/3] models.Event: Add the user responsible for the event

This allows using the events as a kind of audit log, to see how a patch came to its current state/delegate. Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland --- patchwork/migrations/0037_event_user.py | 23 +++ patchwork/models.py | 4 2

[PATCH 0/3] Store the user responsible for patch-related events

the Event.user field is left as null/None. Finally, the new Event.user field is exposed in the events view of the REST API. (First time submitter to this project, so please tell me if I overlooked something.) Have fun! ...Johan Johan Herland (3): models.Event: Add the user responsible for the event