Re: [PATCH v4 0/7] Add support for series dependencies

2025-03-11 Thread Stephen Finucane
On Sat, 2025-03-08 at 11:51 +, Stephen Finucane wrote: > On Thu, 2025-01-30 at 14:56 -0500, Adam Hassick wrote: > > This patch series adds support for series dependencies. A series > > dependency may be declared by another series when that series alone will > > not apply,

Re: [PATCH v3 2/7] api: Add fields to series detail view

2025-03-08 Thread Stephen Finucane
On Fri, 2024-11-15 at 15:40 -0500, Adam Hassick wrote: > Adds the "dependencies" and "dependents" fields to the series detail > view. > > Signed-off-by: Adam Hassick Reviewed-by: Stephen Finucane ___ Patchwork mailing

Re: [PATCH v4 0/7] Add support for series dependencies

2025-03-08 Thread Stephen Finucane
On Thu, 2025-01-30 at 14:56 -0500, Adam Hassick wrote: > This patch series adds support for series dependencies. A series > dependency may be declared by another series when that series alone will > not apply, compile, or otherwise function properly without the dependent > series. > > Including th

Re: [PATCH v4 6/7] docs: Add generated API schemas

2025-03-08 Thread Stephen Finucane
On Thu, 2025-01-30 at 14:56 -0500, Adam Hassick wrote: > Signed-off-by: Adam Hassick I've some tweaks made here to handle the parse_dependencies -> show_dependencies change, but otherwise LGTM. Reviewed-by: Stephen Finucane > --- > docs/api/schemas/latest/patchwork.yaml |

Re: [PATCH v4 7/7] release-notes: Add release note

2025-03-08 Thread Stephen Finucane
On Thu, 2025-01-30 at 14:56 -0500, Adam Hassick wrote: > Signed-off-by: Adam Hassick I've some tweaks made here to handle the parse_dependencies -> show_dependencies change, but otherwise LGTM. Reviewed-by: Stephen Finucane > --- > ...-series-dependencies-669645858

Re: [PATCH v4 5/7] docs: Add feature info and increment API version

2025-03-08 Thread Stephen Finucane
tation to reflect the version change. > > * Add blurb documenting the "Depends-on" tag to the usage overview. > > > > Signed-off-by: Adam Hassick I've some tweaks made here to handle the parse_dependencies -> show_dependencies change, but otherwise LGTM. Reviewed-by:

Re: [PATCH v3 1/7] models: Add field for series dependencies

2025-03-08 Thread Stephen Finucane
On Fri, 2024-11-15 at 15:40 -0500, Adam Hassick wrote: > Adds a ManyToMany field to represent a dependency relationship between > patch series and a helper method to add dependencies. > > Signed-off-by: Adam Hassick Reviewed-by: Step

Re: [PATCH v4 3/7] parser: Parse "Depends-on" tags in emails

2025-03-08 Thread Stephen Finucane
assick With two notes below. Reviewed-by: Stephen Finucane > --- > patchwork/parser.py | 92 - > 1 file changed, 91 insertions(+), 1 deletion(-) > > diff --git a/patchwork/parser.py b/patchwork/parser.py > index 09a53a0..4b

Re: [PATCH v4 2/7] api: Add fields to series detail view

2025-03-08 Thread Stephen Finucane
On Thu, 2025-01-30 at 14:56 -0500, Adam Hassick wrote: > * Add the "dependencies" and "dependents" fields to the series detail > view. > * Add "parse_dependencies" to the project detail view. > > Signed-off-by: Adam Hassick With one

Re: [PATCH v3 1/7] models: Add field for series dependencies

2025-03-08 Thread Stephen Finucane
On Sat, 2025-03-08 at 10:37 +, Stephen Finucane wrote: > On Fri, 2024-11-15 at 15:40 -0500, Adam Hassick wrote: > > Adds a ManyToMany field to represent a dependency relationship between > > patch series and a helper method to add dependencies. > > > >

Re: [PATCH v4 1/7] models: Add fields for series dependencies

2025-03-08 Thread Stephen Finucane
k Reviewed-by: Stephen Finucane ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v3 0/7] Add support for series dependencies

2025-01-29 Thread Stephen Finucane
On Wed, 2025-01-29 at 09:44 -0500, Adam Hassick wrote: > On Wed, Jan 29, 2025 at 7:14 AM Stephen Finucane wrote: > > > > On Tue, 2025-01-28 at 10:05 -0500, Adam Hassick wrote: > > > On Mon, Jan 27, 2025 at 2:16 PM Patrick Robb wrote: > > > > > > >

Re: [PATCH v3 0/7] Add support for series dependencies

2025-01-29 Thread Stephen Finucane
oals of the > project. Can we make this a field of the project so that it can be enabled on a per- project (rather than per-deployment) basis? That also allows us to expose it via the '/projects' REST API. Cheers, Stephen > > > Thanks. -Patrick > > > > On Mo

Re: [PATCH v3 0/7] Add support for series dependencies

2025-01-27 Thread Stephen Finucane
On Thu, 2025-01-16 at 10:18 -0500, Adam Hassick wrote: > Hi Stephen, > > Is there any chance you could review this soon? It has been a while > since submission. Hi Adam, I have seen this and am not ignoring you: I just haven't gotten to it yet 🙈️. I was struck down with the flu over Christmas br

Re: [PATCH v4 5/5] patch-list: add inline dropdown for delegate and state one-off changes

2024-11-01 Thread Stephen Finucane
On Mon, 2021-08-23 at 18:28 +, Raxel Gutierrez wrote: > Add dropdown for the cell values of the Delegate and State columns for > each individual patch to make one-off changes to patches. The dropdowns > are only viewable if the user has patch edit permissions. > > Change the generic_list metho

Re: [PATCH v2 0/7] Add support for series dependencies

2024-11-01 Thread Stephen Finucane
: https://github.com/getpatchwork/patchwork/pull/589 However, as Hero notes there, it won't be massively useful as-is right now due to a lack of a series state field. Still, at least we've a path forward for this later. Cheers, Stephen > > Regards, > Adam > > On Thu, Oct 31, 2

Re: [PATCH v4 4/5] patch-list: style modification forms as an action bar

2024-11-01 Thread Stephen Finucane
ur.com/UtNJXuf.png > > Signed-off-by: Raxel Gutierrez Again, quite a few conflicts here but hopefully resolved now though. Reviewed-by: Stephen Finucane ...and applied. Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://l

Re: [PATCH v4 3/5] patch-list: move and refactor patch-forms

2024-11-01 Thread Stephen Finucane
ndle form validation for both pages. > > Signed-off-by: Raxel Gutierrez Lots of conflicts here. All hopefully resolved now though. Reviewed-by: Stephen Finucane and applied. Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v4 2/5] patch-list: move js code to separate file

2024-11-01 Thread Stephen Finucane
merge conflicts. Reviewed-by: Stephen Finucane ...and applied Stephen > --- > htdocs/README.rst | 6 ++ > htdocs/js/patch-list.js | 12 > .../patchwork/partials/patch-list.html| 19 --

Re: [PATCH v4 1/5] patch-list: clean up patch-list page

2024-11-01 Thread Stephen Finucane
this shortly. Reviewed-by: Stephen Finucane Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 1/2] tools: add arguments for home directory and tag in a dockerfile

2024-11-01 Thread Stephen Finucane
and running docker-compose from there? That would confirm if its file permission issue related to running from your home directory. Also, are you using docker-tools or Docker for Mac? Have you tried podman? Hope this helps, Stephen > > > On 31 Oct 2024, at 21:56, Stephen Finucane wr

Patchwork v3.2.1 Available

2024-10-31 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v3.2.1. This release is part of the "Iridescent" release series: https://github.com/getpatchwork/patchwork/releases/tag/v3.2.1 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking!

Re: [PATCH] css: make diff colors more accessible

2024-10-31 Thread Stephen Finucane
On Wed, 2022-10-05 at 16:24 +0200, Robin Jarry wrote: > The colors used to display patch diffs are confusing. The context color > is very similar to the added line color and the contrast between added > and removed lines is very low. > > Originally, the choice of purple/blue (instead of the more c

Re: [PATCH v2 4/7] tests: Add tests for new functionality

2024-10-31 Thread Stephen Finucane
On Tue, 2024-07-30 at 17:05 -0400, Adam Hassick wrote: > v1: > * Add tests for the API and parser changes. > * Add new test mbox files. > * Add new patch series tests. > > Signed-off-by: Adam Hassick I'm happy with this now. Reviewed-by: Stephen Finucane >

Re: [PATCH v2 0/7] Add support for series dependencies

2024-10-31 Thread Stephen Finucane
On Thu, 2024-08-29 at 10:54 -0400, Adam Hassick wrote: > Stephen, > > Is there anything I need to do before this patch can be reviewed? It > has been a while, I just want to make sure that I am not blocking this > in any way. Apologies for the delay on this but my time is limited recently :( I t

Re: [PATCH v2 5/7] docs: Increment API version

2024-10-31 Thread Stephen Finucane
Fine by me. Reviewed-by: Stephen Finucane > --- > docs/api/rest/index.rst | 42 +++- > docs/api/rest/schemas/v1.3.rst | 4 +-- > docs/api/rest/schemas/v1.4.rst | 5 > docs/api/schemas/generate-schemas.py | 4 +-- >

Re: [PATCH v2 7/7] release-notes: Add release note

2024-10-31 Thread Stephen Finucane
On Tue, 2024-07-30 at 17:05 -0400, Adam Hassick wrote: > Signed-off-by: Adam Hassick All good here. Reviewed-by: Stephen Finucane > --- > ...d-series-dependencies-6696458586e795c7.yaml | 18 ++ > 1 file changed, 18 insertions(+) > create mode 100644 > rele

Re: [PATCH v2 6/7] docs: Add generated API schemas

2024-10-31 Thread Stephen Finucane
On Tue, 2024-07-30 at 17:05 -0400, Adam Hassick wrote: > Signed-off-by: Adam Hassick I skipped over this, but I assume it's correct and will regenerate myself before merge. Oh, the wonders of keeping generated code in git... Reviewed-by: Stephen

Re: [PATCH v2 3/7] parser: Parse "Depends-on" tags in emails

2024-10-31 Thread Stephen Finucane
On Tue, 2024-07-30 at 17:05 -0400, Adam Hassick wrote: > Add a new function to parse "Depends-on" tags to the parser. The value > may either be the message ID of a patch or cover letter email already > received by Patchwork, or the web URL of a patch or series. When this > tag is found, the parser

Re: [PATCH v2 2/7] api: Add fields to series detail view

2024-10-31 Thread Stephen Finucane
cial perspective this looks good. Reviewed-by: Stephen Finucane > --- > patchwork/api/series.py | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/patchwork/api/series.py b/patchwork/api/series.py > index b88ed1f..2b23e48 100644

Re: [PATCH v2 1/7] models: Add field for series dependencies

2024-10-31 Thread Stephen Finucane
On Tue, 2024-07-30 at 17:05 -0400, Adam Hassick wrote: > Adds a ManyToMany field to represent a dependency relationship between > patch series and a helper method to add dependencies. > > Signed-off-by: Adam Hassick Looks good to me. Reviewed-by: Stephen Finucane > --- &g

Re: [PATCH] templates/submission: Fix alignment of commit message

2024-10-31 Thread Stephen Finucane
On Wed, 2024-10-23 at 21:05 +0200, Thomas Monjalon wrote: > Hello, this patch is fixing a bug. > Can it be merged please? Sorry, Thomas. Wanted to get 3.2.0 out the door as-is just to free up the pipeline so Hero and I can work through the many reviews sitting and waiting. Reviewed-by: S

Re: [PATCH 2/2] docs: add note on deployment of patchwork on mac

2024-10-31 Thread Stephen Finucane
On Tue, 2024-10-29 at 19:09 +, Herakliusz Lipiec wrote: > Add notes on deplotment of Docker image for patchwork testing > usnng docker-compose on MacOs. Also adding a note on using > TAG variable to alter dockerfile image tag. > > Signed-off-by: Herakliusz Lipiec > --- > docs/development/ins

Re: [PATCH 1/2] tools: add arguments for home directory and tag in a dockerfile

2024-10-31 Thread Stephen Finucane
On Tue, 2024-10-29 at 19:09 +, Herakliusz Lipiec wrote: > Currently to change the home directory for docker image it has > to be changed in many places. Dockerfile allows for use of > arguments and env variables, by using those now it can be changed > by passing arguments to docker-compose. Als

Patchwork v3.2.0 Available

2024-10-23 Thread Stephen Finucane
We're delighted to announce the release of Patchwork v3.2.0 ("Iridescent"): https://github.com/getpatchwork/patchwork/releases/tag/v3.2.0 The v3.2.0 release is another smaller releases. For full information on the options available, you should look at the full release notes in detail. The below a

Re: [PATCH v1 3/9] parser: Parse "Depends-on" tags in emails

2024-07-18 Thread Stephen Finucane
On Fri, 2024-07-12 at 15:28 -0400, Adam Hassick wrote: > On Fri, Jul 12, 2024 at 12:02 PM Stephen Finucane wrote: > > > > On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > > > Add a new function to parse "Depends-on" tags to the parser. The value >

Re: [PATCH v1 9/9] release-notes: Add release notes

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Signed-off-by: Adam Hassick Again, potentially needs updates based on the depends-on discussions. Also, there's a small typo. Address both and I'm good. > --- > ...-series-dependencies-6696458586e795c7.yaml | 20 +++ > 1 f

Re: [PATCH v1 8/9] tests: Add tests for new functionality

2024-07-12 Thread Stephen Finucane
of the 'Depends-on' format discussion but otherwise LGTM. Reviewed-by: Stephen Finucane > --- > patchwork/tests/api/test_series.py| 33 ++- > .../tests/series/dependency-base-patch.mbox | 102 +++ > .../series/dependency-multi-2.mbox.template |

Re: [PATCH v1 7/9] migrations: Add migration for new field

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Signed-off-by: Adam Hassick This needs to be squashed into the change that actually adds the fields to keep things bisectable. One other nit below but change itself looks fine otherwise. > --- > .../migrations/0047_series_dependencies.py

Re: [PATCH v1 5/9] urls: Increment API version

2024-07-12 Thread Stephen Finucane
e so big)? Otherwise this LGTM. Reviewed-by: Stephen Finucane > --- > patchwork/urls.py | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/patchwork/urls.py b/patchwork/urls.py > index ecd3668..11cd8e7 100644 > --- a/patchwork/urls

Re: [PATCH v1 4/9] settings: Add flag to toggle "Depends-on" parsing

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Some operators of Patchwork instances may not want to allow series > dependencies. By providing this setting, these operators may disable > this behavior on their instance. > > Signed-off-by: Adam Hassick Not sure what happened here but th

Re: [PATCH v1 4/9] settings: Add flag disable "Depends-on" parsing

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Some operators of Patchwork instances may not want to allow series > dependencies. By providing this setting, these operators may disable > this behavior on their instance. > > Signed-off-by: Adam Hassick This is only one of three feature

Re: [PATCH v1 3/9] parser: Parse "Depends-on" tags in emails

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Add a new function to parse "Depends-on" tags to the parser. The value > may either be a "reference" to a patch or series object or the web URL > to the object. For example, a reference may look like "patch-1234" or > "series-5678". When this

Re: [PATCH v1 2/9] models: Add field for series dependencies

2024-07-12 Thread Stephen Finucane
On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote: > Add a ManyToMany field to represent a dependency relationship between > patch series. > > Signed-off-by: Adam Hassick Two comments below but LGTM. Reviewed-by: Stephen Finucane > --- > patchwork/models.py | 17

Re: [PATCH v1 1/9] api: Add fields to series detail view

2024-07-12 Thread Stephen Finucane
s merged. I also haven't assessed the performance of this yet but that's DB-specific. From a pure API perspective though, this looks good so far. Reviewed-by: Stephen Finucane > --- > patchwork/api/series.py | 26 -- > 1 file changed, 24 insertions(+), 2

[PATCH] models: Add covering index for Patch.hash

2024-01-24 Thread Stephen Finucane
Signed-off-by: Stephen Finucane Closes: #579 Cc: Mauro Carvalho Chehab --- .../migrations/0047_add_database_indexes.py| 18 ++ patchwork/models.py| 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 patchwork/migrations

Re: [Patchwork-maintainers] patchwork.ozlabs.org downtime for maintenance - 15/16 August

2024-01-22 Thread Stephen Finucane
On Mon, 2024-01-22 at 15:52 +0800, Jeremy Kerr wrote: > Hi all, > > I'll try and get to that over the weekend. > > Looks like the heaviest database load is due to API request to the > global patches view, which is a bit of an odd use-case; that all > appears to be mostly spider traffic. Just as a

[PATCH] Correctly append tags on patches without commit details

2023-01-24 Thread Stephen Finucane
tead using 're.MULTILINE' and matching on '^' and '$' for newlines instead of '\n'. Signed-off-by: Stephen Finucane Closes: #516 Cc: siddh...@gotplt.org --- patchwork/tests/views/test_utils.py | 23 +++ patchwork/views/utils.py

Patchwork v3.1.1 Available

2022-09-30 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v3.1.1. This release is part of the "Hessian" release series: https://github.com/getpatchwork/patchwork/releases/tag/v3.1.1 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking! --

Patchwork v3.0.6 Available

2022-09-30 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v3.0.6. This release is part of the "Grosgrain" release series: https://github.com/getpatchwork/patchwork/releases/tag/v3.0.6 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking!

Re: [PATCH 01/10] tests: Change from expectedFailure to skip

2022-09-30 Thread Stephen Finucane
On Fri, 2022-09-30 at 17:19 +0100, Stephen Finucane wrote: > Python 3.10 recognises unexpected passes as failures now. > > Signed-off-by: Stephen Finucane I added some release notes and merged this whole series. Stephen ___ Patchwork mai

Re: [PATCH 10/10] urls: Encode slashes in message IDs

2022-09-30 Thread Stephen Finucane
On Fri, 2022-09-30 at 17:19 +0100, Stephen Finucane wrote: > We were attempting to work around the fact that message IDs could > contain slashes which in some cases broke our ability to generate > meaningful URLs. Rather than doing this, insist that users encode these > slashes so

[PATCH 10/10] urls: Encode slashes in message IDs

2022-09-30 Thread Stephen Finucane
the URL. This is a slightly breaking change, but the current behavior is already broken (see the linked bug) so this seems reasonable. Signed-off-by: Stephen Finucane Closes: #433 Cc: d...@axtens.net Cc: siddh...@gotplt.org --- notes/issue-433-5f048abbe3789556.yaml | 19

[PATCH 09/10] REST: Add missing 'url' parameter for comments

2022-09-30 Thread Stephen Finucane
This should be present on all resources. Signed-off-by: Stephen Finucane Fixes: 88f56051 ("api: add comments detail endpoint") --- docs/api/schemas/latest/patchwork.yaml | 5 + docs/api/schemas/patchwork.j2 | 9 + docs/api/schemas/v1.0/patchwork.yaml | 5 -

[PATCH 06/10] REST: Fix issues with comment-related events

2022-09-30 Thread Stephen Finucane
When we introduced this functionality, we missed the fact that these resources use nested-style URLs that need to be specially handled. Fix this now. Signed-off-by: Stephen Finucane Fixes: e3d8f7548 ("REST: Add 'patch-comment-created', 'cover-comment-created' events&quo

[PATCH 08/10] models: Cache 'list_archive_url' property

2022-09-30 Thread Stephen Finucane
We really need to get rid of this from the embedded view. It's way too slow. For now, we just cache it and leave a note for future us. Signed-off-by: Stephen Finucane --- patchwork/api/embedded.py | 12 patchwork/models.py | 6 +++--- 2 files changed, 15 insertions(

[PATCH 07/10] REST: De-duplicate handling of nested resource URLs

2022-09-30 Thread Stephen Finucane
These were all doing the same thing. Make things more generic. We also speed up test (inadvertently) by using the 'patch_id' attribute of the 'Check' model rather than 'patch.id', thus avoiding the JOIN. Signed-off-by: Stephen Finucane --- patchwor

[PATCH 04/10] requirements: Bump Django to 3.2.x, djangorestframework to 4.16.0

2022-09-30 Thread Stephen Finucane
ated in fixing either of these. For the former, we must do as we're told and use the form object directly. For the latter, we need to configure our own form renderer so we can continue using the table form renderer for now. Signed-off-by: Stephen Finucane --- patchwork/forms.py

[PATCH 05/10] manage: Check Django version on startup

2022-09-30 Thread Stephen Finucane
This was recently reported as an issue. Add a simple check to ensure people update their dependencies as expected. Signed-off-by: Stephen Finucane Cc: Siddhesh Poyarekar Cc: DJ Delorie Cc: Carlos O'Donell --- manage.py | 5 + 1 file changed, 5 insertions(+) diff --git mana

[PATCH 03/10] tox: Output test times, more verbose output

2022-09-30 Thread Stephen Finucane
Just a bit more useful for CI logs Signed-off-by: Stephen Finucane --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git tox.ini tox.ini index 0ab0ab84..aa434a72 100644 --- tox.ini +++ tox.ini @@ -24,7 +24,7 @@ passenv = DATABASE_TYPE DATABASE_USER DATABASE_PASSWORD

[PATCH 01/10] tests: Change from expectedFailure to skip

2022-09-30 Thread Stephen Finucane
Python 3.10 recognises unexpected passes as failures now. Signed-off-by: Stephen Finucane --- patchwork/tests/test_series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git patchwork/tests/test_series.py patchwork/tests/test_series.py index 8d8c4e14..d3e20e08 100644

[PATCH 02/10] trivial: Remove unnecessary unicode prefixes

2022-09-30 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- docs/conf.py| 6 +++--- patchwork/forms.py | 8 +--- patchwork/tests/test_parser.py | 12 ++-- patchwork/tests/views/test_mail.py | 16 patchwork/tests/views/test_patch.py | 2

[PATCH 1/2] docs: Add references to VSCode Patchwork plugin

2022-09-09 Thread Stephen Finucane
Signed-off-by: Stephen Finucane Cc: Florent Revest --- README.rst | 20 docs/usage/clients.rst | 32 +++- 2 files changed, 47 insertions(+), 5 deletions(-) diff --git README.rst README.rst index 94ae431d..979801fb 100644

[PATCH 2/2] docs: Add info on contributing docs

2022-09-09 Thread Stephen Finucane
Noticed while whipping up a patch to document the new VSCode extension. Signed-off-by: Stephen Finucane --- docs/development/contributing.rst | 40 +++ 1 file changed, 40 insertions(+) diff --git docs/development/contributing.rst docs/development/contributing.rst

Patchwork v3.1.0 Available

2022-07-15 Thread Stephen Finucane
We're delighted to announce the release of Patchwork v3.1.0 ("Hessian"): https://github.com/getpatchwork/patchwork/releases/tag/v3.1.0 The v3.1.0 release is one of the smaller releases. For full information on the options available, you should look at the full release notes in detail. The below a

Re: Stepping down as a Patchwork maintainer

2022-06-29 Thread Stephen Finucane
On Wed, 2022-06-29 at 23:30 +1000, Daniel Axtens wrote: > Hi all, > > I think it's time for me to officially step down from Patchwork > maintainership. > > I've been in a new job for 3 months now, and this company doesn't use > mailing lists for development. So I'm no longer using Patchwork as a

[PATCH] urls: Encode slashes in message IDs

2022-05-11 Thread Stephen Finucane
the URL. This is a slightly breaking change, but the current behavior is already broken (see the linked bug) so this seems reasonable. Signed-off-by: Stephen Finucane Closes: #433 Cc: d...@axtens.net Cc: siddh...@gotplt.org --- patchwork/models.py | 23

Patchwork v3.0.5 Available

2022-05-10 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v3.0.5. This release is part of the "Grosgrain" release series: https://github.com/getpatchwork/patchwork/releases/tag/v3.0.5 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking!

Re: [PATCH 2/n] parser: Ignore CFWS in Message-ID header

2022-05-06 Thread Stephen Finucane
On Fri, 2022-05-06 at 18:49 +0100, Stephen Finucane wrote: > We recently started stripping comments and folding white space from the > In-Reply-To and References headers. Do so also for the Message-ID > header. > > Signed-off-by: Stephen Finucane > Related: #399 > --- &

[PATCH 2/n] parser: Ignore CFWS in Message-ID header

2022-05-06 Thread Stephen Finucane
We recently started stripping comments and folding white space from the In-Reply-To and References headers. Do so also for the Message-ID header. Signed-off-by: Stephen Finucane Related: #399 --- patchwork/parser.py| 43 ++ patchwork/tests

[PATCH] parser: Ignore CFWS in In-Reply-To, References headers

2022-05-06 Thread Stephen Finucane
RFC2822 states that [1] a comment or folding white space is permitted to be inserted before or after a msg-id in in the Message-ID, In-Reply-To or References fields. Allow for this. [1] https://tools.ietf.org/html/rfc2822#section-3.6.4 Signed-off-by: Stephen Finucane Closes: #399 --- patchwork

Re: [PATCH] Align check-get with other commands operating on patch IDs

2022-04-01 Thread Stephen Finucane
Olof Johansson > Signed-off-by: Rob Herring Reviewed-by: Stephen Finucane Thanks. Applied and included in the new 2.1.0 release. Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 2/2] REST: Add 'patch-comment-created', 'cover-comment-created' events

2022-03-29 Thread Stephen Finucane
On Tue, 2022-03-29 at 19:57 +0100, Stephen Finucane wrote: > From: DJ Delorie > > This patch stitches in "comment created" events for patches and cover > letter into the event queue. > > Signed-off-by: DJ Delorie > Signed-off-by: Stephen Finucane > Closes: #

Re: [PATCH 1/2] docs: Don't version events

2022-03-29 Thread Stephen Finucane
On Tue, 2022-03-29 at 19:57 +0100, Stephen Finucane wrote: > We don't actually version the types of events we emit. Doing so would be > possible, but this ship has already sailed (with API version 1.2). > > We also remove some unnecessary line breaks. > > Signed-off-by:

[PATCH 2/2] REST: Add 'patch-comment-created', 'cover-comment-created' events

2022-03-29 Thread Stephen Finucane
From: DJ Delorie This patch stitches in "comment created" events for patches and cover letter into the event queue. Signed-off-by: DJ Delorie Signed-off-by: Stephen Finucane Closes: #424 [stephenfin: Extend to cover letters also. Fix some formatting issues. Add a release note] ---

[PATCH 1/2] docs: Don't version events

2022-03-29 Thread Stephen Finucane
We don't actually version the types of events we emit. Doing so would be possible, but this ship has already sailed (with API version 1.2). We also remove some unnecessary line breaks. Signed-off-by: Stephen Finucane --- docs/api/schemas/latest/patchwork.yaml | 21 +++-- doc

Testing, please ignore

2022-03-24 Thread Stephen Finucane
I've seen reports that the mailing list is rejecting emails. Let's see if that's true for everyone. Please ignore. Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] docker: rebase on vicamo/pyenv

2022-02-22 Thread Stephen Finucane
On Thu, 2021-12-23 at 12:16 +0800, You-Sheng Yang wrote: > Stephen Finucane 於 2021年12月23日 週四 上午6:05寫道: > > > > On Sun, 2021-12-12 at 14:17 +0800, You-Sheng Yang wrote: > > > Rebuild pyenv environments can be time-consuming and irrelevant to this > > > project.

Re: [PATCH] docker: rebase on vicamo/pyenv

2021-12-22 Thread Stephen Finucane
On Sun, 2021-12-12 at 14:17 +0800, You-Sheng Yang wrote: > Rebuild pyenv environments can be time-consuming and irrelevant to this > project. Use a prebuild image to save some time here. > > Signed-off-by: You-Sheng Yang This is a good idea. I've created a similar image at [1] which (I think) wi

Re: [PATCH] docs: pin mistune version due to breakage

2021-12-08 Thread Stephen Finucane
On Mon, 2021-12-06 at 16:42 +0800, You-Sheng Yang wrote: > mistune made a new release which breaks API referenced by Sphinx v4.3.1. > > Closes: #442 > Signed-off-by: You-Sheng Yang Reviewed-by: Stephen Finucane I was hoping to be able to fix the underlying issue myself, but th

Re: [PATCH] patch-list: Link to delegate's assigned patches

2021-11-29 Thread Stephen Finucane
On Mon, 2021-11-22 at 18:20 -0500, Sean Anderson wrote: > This adds a link to all patches currently delegated to a user. This can > be much easier than going through the delegate filter, especially if you > already have a patch delegated to that user. This also replaces username > text with their r

Re: [PATCH v2] ci: add docker-compose tests

2021-11-29 Thread Stephen Finucane
On Sat, 2021-11-27 at 17:40 +0800, You-Sheng Yang wrote: > v2: fix intermittent error. > > Signed-off-by: You-Sheng Yang This is great work. Thank you! I removed the release note since this isn't end- user facing and then applied this to master. Cheers, Stephen _

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-10-27 Thread Stephen Finucane
On Fri, 2021-10-22 at 08:28 -0400, Konstantin Ryabitsev wrote: > On Fri, 20 Aug 2021 at 17:59, Stephen Finucane wrote: > > > We remove fields that shouldn't be seen on old versions of the API. > > > This was done with `pop(field name)`, which will throw an exception &

Patchwork v2.2.6 Available

2021-10-27 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v2.2.6. This release is part of the "Flannel" release series: https://github.com/getpatchwork/patchwork/releases/tag/v2.2.6 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking! --

Patchwork v3.0.4 Available

2021-10-27 Thread Stephen Finucane
We're pleased to announce the release of Patchwork v3.0.4. This release is part of the "Grosgrain" release series: https://github.com/getpatchwork/patchwork/releases/tag/v3.0.4 This release is a PATCH release that focuses on bugfixes. For more details, please see below. Happy patchworking!

[PATCH 6/6] trivial: Stop universally disabling F405 check

2021-09-30 Thread Stephen Finucane
We only need this for one file. Simply filter out the things we want to ignore. Signed-off-by: Stephen Finucane --- patchwork/settings/dev.py | 6 -- tox.ini | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git patchwork/settings/dev.py patchwork/settings

[PATCH 3/6] requirements: Bump Django to 3.2.x, django-filter to 21.1

2021-09-30 Thread Stephen Finucane
ve much of a real-world impact since we still support Django 2.2, an LTS release. Signed-off-by: Stephen Finucane --- patchwork/settings/base.py | 4 patchwork/tests/api/test_event.py| 6 +- patchwork/tests/api/test_patch.py

[PATCH 5/6] requirements: Bump psycopg2-binary, openapi-core

2021-09-30 Thread Stephen Finucane
Once again, openapi-core has moved stuff around internally. Nothing we can't fix though, as it seems the thing moved is no longer necessary. Signed-off-by: Stephen Finucane --- patchwork/tests/api/validator.py | 6 +- requirements-test.txt| 4 ++-- 2 files changed, 3 inser

[PATCH 4/6] tox: Use compatible minor releases

2021-09-30 Thread Stephen Finucane
as we cap newer versions of e.g. django-filter when they're not compatible with older Django versions, we should be good. Signed-off-by: Stephen Finucane --- tox.ini | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git tox.ini tox.ini index 8eab01da..1de53

[PATCH 2/6] requirements: Bump doc requirements

2021-09-30 Thread Stephen Finucane
We were suggesting we supported positively ancient versions of Sphinx and reno in particular. Bump these. Signed-off-by: Stephen Finucane --- docs/requirements.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git docs/requirements.txt docs/requirements.txt index

[PATCH 1/6] Revert "docs: prevent build error by rolling back Sphinx version"

2021-09-30 Thread Stephen Finucane
This reverts commit 65547c8701004f1a2a9ed9d16f1a372f4bd856e4. There is a new release of sphinxcontrib-httpdomain [1] that fixes the issues with Sphinx 4.1.x and later [2] [1] https://github.com/sphinx-contrib/httpdomain/releases/tag/1.8.0 [2] https://github.com/sphinx-contrib/httpdomain/pull/54 --

Re: [PATCH] models: Add Series.is_open

2021-09-23 Thread Stephen Finucane
On Thu, 2021-09-23 at 12:43 +0100, Stephen Finucane wrote: > On Thu, 2021-09-23 at 12:40 +0100, Stephen Finucane wrote: > > On Sun, 2021-09-05 at 11:34 +1000, Daniel Axtens wrote: > > > Stephen Finucane writes: > > > > > > > Start making series more usefu

Re: [PATCH] models: Add Series.is_open

2021-09-23 Thread Stephen Finucane
On Thu, 2021-09-23 at 12:40 +0100, Stephen Finucane wrote: > On Sun, 2021-09-05 at 11:34 +1000, Daniel Axtens wrote: > > Stephen Finucane writes: > > > > > Start making series more useful by tracking whether the state is open, > > > meaning one or more patches ar

Re: [PATCH] models: Add Series.is_open

2021-09-23 Thread Stephen Finucane
On Sun, 2021-09-05 at 11:34 +1000, Daniel Axtens wrote: > Stephen Finucane writes: > > > Start making series more useful by tracking whether the state is open, > > meaning one or more patches are in a state with action_required=True, or > > not. This means that the 

[PATCH] models: Add Series.is_open

2021-09-03 Thread Stephen Finucane
Start making series more useful by tracking whether the state is open, meaning one or more patches are in a state with action_required=True, or not. This means that the 'git-pw series list' command will only list series that are actually actionable. Signed-off-by: Stephen Finucane

[PATCH] README: Add Discord badge

2021-09-03 Thread Stephen Finucane
Add a Discord badge that can be used to connect to the server. Link taken from daxtens' email to the list about the server [1]. [1] https://lists.ozlabs.org/pipermail/patchwork/2021-September/007226.html Signed-off-by: Stephen Finucane Cc: Daniel Axtens --- README.rst | 4 1 file ch

[RFC PATCH v2 10/19] templates: Convert user profile view

2021-09-01 Thread Stephen Finucane
This is our first "full page", in that we have a navbar. A large number of TODOs are left here as we're simply changing templates rather than updating views, but those gaps will be closed in a future change. Signed-off-by: Stephen Finucane --- patchwork/templates/patchwork/login.

[RFC PATCH v2 19/19] templates: Convert registration template

2021-09-01 Thread Stephen Finucane
This is the last of our non submission pages. Next up, the main patch and cover letter list/detail pages. Signed-off-by: Stephen Finucane --- patchwork/forms.py| 7 +- .../templates/patchwork/registration.html | 211 +- patchwork/views/user.py

[RFC PATCH v2 11/19] templates: Enhance profile view further

2021-09-01 Thread Stephen Finucane
Fill in the gaps intentionally missed previously by amalgamating most user-specific views into the user profile view. Signed-off-by: Stephen Finucane --- patchwork/forms.py| 252 ++--- patchwork/templates/patchwork/profile.html| 86

[RFC PATCH v2 18/19] templates: Convert mail settings pages

2021-09-01 Thread Stephen Finucane
GET /mail// POST /mail// Error messages are propagated via the messages framework with all non-field validation errors resulting in a redirect to the homepage. Signed-off-by: Stephen Finucane --- .../templates/patchwork/confirm-error.html| 23 --- .../templates/patchwork/ma

  1   2   3   4   5   6   7   8   9   10   >