Re: [PATCH] parser: recognise git commit consisting only of empty new file

2019-03-07 Thread Stephen Finucane
On Thu, 2019-03-07 at 14:01 +1100, Daniel Axtens wrote: > Stephen Finucane writes: > > > On Thu, 2019-02-28 at 15:29 +1100, Daniel Axtens wrote: > > > Commits with only an empty new file are liable to be missed. > > > The parser state machine doesn't recognise the headers "new > > > file mode"

Re: [PATCH] parser: recognise git commit consisting only of empty new file

2019-03-06 Thread Daniel Axtens
Stephen Finucane writes: > On Thu, 2019-02-28 at 15:29 +1100, Daniel Axtens wrote: >> Commits with only an empty new file are liable to be missed. >> The parser state machine doesn't recognise the headers "new >> file mode" and "index": teach it about them. >> >> Add a test to demonstrate. >>

Re: [PATCH] parser: recognise git commit consisting only of empty new file

2019-03-02 Thread Stephen Finucane
On Thu, 2019-02-28 at 15:29 +1100, Daniel Axtens wrote: > Commits with only an empty new file are liable to be missed. > The parser state machine doesn't recognise the headers "new > file mode" and "index": teach it about them. > > Add a test to demonstrate. > > It's a little bit academic as you

Re: [PATCH] parser: recognise git commit consisting only of empty new file

2019-02-27 Thread Andrew Donnellan
On 28/2/19 3:29 pm, Daniel Axtens wrote: Commits with only an empty new file are liable to be missed. The parser state machine doesn't recognise the headers "new file mode" and "index": teach it about them. Add a test to demonstrate. It's a little bit academic as you don't usually send patches

[PATCH] parser: recognise git commit consisting only of empty new file

2019-02-27 Thread Daniel Axtens
Commits with only an empty new file are liable to be missed. The parser state machine doesn't recognise the headers "new file mode" and "index": teach it about them. Add a test to demonstrate. It's a little bit academic as you don't usually send patches like that but sometimes you do, especially