[PATCH 2/7] REST: Simplify ModelMultiChoiceField

2018-04-11 Thread Stephen Finucane
We're actually going to remove this shortly but the new technique works for both. Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py index 25

Re: [PATCH 2/7] REST: Simplify ModelMultiChoiceField

2018-05-08 Thread Daniel Axtens
Stephen Finucane writes: > We're actually going to remove this shortly but the new technique works > for both. For both what? Apart from that, this patch leaves ModelMultiChoiceField._get_filters() as dead code, but it seems you do something with it later, so that's fine. Regards, Daniel > >

Re: [PATCH 2/7] REST: Simplify ModelMultiChoiceField

2018-05-08 Thread Stephen Finucane
On Wed, 2018-05-09 at 01:23 +1000, Daniel Axtens wrote: > Stephen Finucane writes: > > > We're actually going to remove this shortly but the new technique works > > for both. > > For both what? Works for both the current approach and the approach we adopt in future patches. I think I should ha