Re: [PATCH v2 06/13] REST: Stop using ViewSets

2016-11-24 Thread Stephen Fincane
On Thu, 2016-11-24 at 14:03 +1100, Andrew Donnellan wrote: > On 20/11/16 03:51, Stephen Finucane wrote: > > > > +class ProjectMixin(object): > > + > >  permission_classes = (PatchworkPermission,) > >  serializer_class = ProjectSerializer > > > > -def _handle_linkname(self, pk): > > - 

Re: [PATCH v2 06/13] REST: Stop using ViewSets

2016-11-23 Thread Andrew Donnellan
On 20/11/16 03:51, Stephen Finucane wrote: +class ProjectMixin(object): + permission_classes = (PatchworkPermission,) serializer_class = ProjectSerializer -def _handle_linkname(self, pk): -'''Make it easy for users to list by project-id or linkname''' -qs =

Re: [PATCH v2 06/13] REST: Stop using ViewSets

2016-11-20 Thread Daniel Axtens
Hi Stephen, > These are hacked a lot of to get them to work as we want. Use a more > verbose, but ultimately easier to parse, version. This lets us remove > the dependency of drf-nested-routers, bringing us back down to two main > dependencies. It also lets us remove the AuthenticedReadOnly

[PATCH v2 06/13] REST: Stop using ViewSets

2016-11-19 Thread Stephen Finucane
These are hacked a lot of to get them to work as we want. Use a more verbose, but ultimately easier to parse, version. This lets us remove the dependency of drf-nested-routers, bringing us back down to two main dependencies. It also lets us remove the AuthenticedReadOnly permission class, as the