Re: [PATCH v3 3/3] /api/events: Add 'actor' field to generated JSON

2019-11-30 Thread Stephen Finucane
On Thu, 2019-10-17 at 00:44 +0200, Johan Herland wrote: > Cc: Mauro Carvalho Chehab > Signed-off-by: Johan Herland > Acked-by: Daniel Axtens This looks good to me. Since you're respinning though, have you considered adding the ability to filter events by actor? I don't see it here and I think

Re: [PATCH v3 3/3] /api/events: Add 'actor' field to generated JSON

2019-11-13 Thread Andrew Donnellan
On 17/10/19 9:44 am, Johan Herland wrote: Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Acked-by: Daniel Axtens Looks alright Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH v3 3/3] /api/events: Add 'actor' field to generated JSON

2019-10-16 Thread Johan Herland
Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Acked-by: Daniel Axtens --- docs/api/schemas/latest/patchwork.yaml | 6 ++ docs/api/schemas/patchwork.j2 | 8 docs/api/schemas/v1.2/patchwork.yaml | 6 ++ docs/usage/overview.rst| 3 +++