So I've gone ahead and merged this because I wanted to close it out
before the end of the year. I think the model changes are correct and
the parser changes can be tweaked (or mostly reverted if they're really
wrong). Answers to your questions below.
On Mon, 2019-12-09 at 09:27 +1100, Daniel Axten
Stephen Finucane writes:
> On Sun, 2019-12-08 at 22:14 +1100, Daniel Axtens wrote:
>> Daniel Axtens writes:
>>
>> > > Currently, the 'SeriesReference' object has a unique constraint on the
>> > > two fields it has, 'series', which is a foreign key to 'Series', and
>> > > 'msgid'. This is the wr
On Sun, 2019-12-08 at 22:14 +1100, Daniel Axtens wrote:
> Daniel Axtens writes:
>
> > > Currently, the 'SeriesReference' object has a unique constraint on the
> > > two fields it has, 'series', which is a foreign key to 'Series', and
> > > 'msgid'. This is the wrong constraint. What we actually w
Daniel Axtens writes:
>> Currently, the 'SeriesReference' object has a unique constraint on the
>> two fields it has, 'series', which is a foreign key to 'Series', and
>> 'msgid'. This is the wrong constraint. What we actually want to enforce
>> is that a patch, cover letter or comment is referen
> Currently, the 'SeriesReference' object has a unique constraint on the
> two fields it has, 'series', which is a foreign key to 'Series', and
> 'msgid'. This is the wrong constraint. What we actually want to enforce
> is that a patch, cover letter or comment is referenced by a single
> series, or
I only see patch 1 of apparently 3 patches?
I'm not super keen on the whole retry logic, and I think I have a way to
do this that doesn't require that - give me a few days to try and
polish it up enough to send out.
Regards,
Daniel
Stephen Finucane writes:
> Currently, the 'SeriesReference' o
Currently, the 'SeriesReference' object has a unique constraint on the
two fields it has, 'series', which is a foreign key to 'Series', and
'msgid'. This is the wrong constraint. What we actually want to enforce
is that a patch, cover letter or comment is referenced by a single
series, or rather a
