Re: [PATCH v3 2/3] Include the responsible actor in applicable events

2019-11-30 Thread Stephen Finucane
On Thu, 2019-11-14 at 23:37 +0100, Johan Herland wrote: > On Thu, Nov 14, 2019 at 6:31 AM Andrew Donnellan wrote: > > On 17/10/19 9:44 am, Johan Herland wrote: > > > We want to use the events as an audit log. An important part of this is > > > recording _who_ made the changes that the events repre

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

2019-11-14 Thread Andrew Donnellan
On 15/11/19 9:37 am, Johan Herland wrote:>>> The remaining events (cover-created, series-created) are both triggered by incoming emails, hence have no real actor as such, so we simply leave the actor as None/NULL. How is cover-created different from patch-created? In practice, it turns out th

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

2019-11-14 Thread Johan Herland
On Thu, Nov 14, 2019 at 6:31 AM Andrew Donnellan wrote: > On 17/10/19 9:44 am, Johan Herland wrote: > > We want to use the events as an audit log. An important part of this is > > recording _who_ made the changes that the events represent. > > > > To accomplish this, we need to know the current us

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

2019-11-13 Thread Andrew Donnellan
On 17/10/19 9:44 am, Johan Herland wrote: We want to use the events as an audit log. An important part of this is recording _who_ made the changes that the events represent. To accomplish this, we need to know the current user (aka. request.user) at the point where we create the Event instance.