On Nov 8, 2011, at 11:17 AM, katja wrote:
> On Tue, Nov 8, 2011 at 1:18 PM, katja wrote:
>
>> There is a small but crucial difference in the API between Pd-extended
>> and Pd-double. In Pd-extended, float precision is defined with
>> PD_FLOATSIZE and in Pd-double it is PD_FLOATPRECISION. This m
On Tue, Nov 8, 2011 at 1:18 PM, katja wrote:
> There is a small but crucial difference in the API between Pd-extended
> and Pd-double. In Pd-extended, float precision is defined with
> PD_FLOATSIZE and in Pd-double it is PD_FLOATPRECISION. This must be
> resolved before we can continue developing
Ok, I chatted with IOhannes on #dataflow. He agreed, so I pushed this change
to the pd-extended.git, so tomorrow's builds should have it.
IOhannes, I could find where you posted this patch, perhaps its not on the
patch tracker yet. In any case attached is the updated version:
.hc
implemen
I think the solution is quite easy, PD_FLOATSIZE was introduced in a patch from
IOhannes "implement PD_BIGORSMALL() with unions". This patch is not yet
included by Miller in pure-data.git. I think we should update that patch in
Pd-extended, changing PD_FLOATSIZE to PD_FLOATPRECISION. IOhanne
Today's autobuilds are broken again, still due to my double-precision
commit! Sorry sorry. The real cause lies here:
There is a small but crucial difference in the API between Pd-extended
and Pd-double. In Pd-extended, float precision is defined with
PD_FLOATSIZE and in Pd-double it is PD_FLOATPRE
No big thing, we all break the build sometimes :) Thanks for the quick fix.
As long as you follow up the next day, don't worry too much about breaking the
build. Its only really a problem when we go more than a couple days without
builds. But yes, it is better to not break the build ;)
.hc
Found my mistake, affecting single precision i386 and x86_64 builds.
It is repaired now. I'll refine my procedures to make sure a mistake
like this won't happen again. Apologies for the inconvenience caused
by it.
Katja
___
Pd-dev mailing list
Pd-dev@ie
On Mon, 2011-11-07 at 11:13 +0100, katja wrote:
> Hello,
>
> Yesterday I've committed code to creb and smlib. I have checked that
> all code compiled, even tested every class's functionality before
> committing. Even so, all nightly builds are apparently broken due to
> my commit. I'll now try to
Hello,
Yesterday I've committed code to creb and smlib. I have checked that
all code compiled, even tested every class's functionality before
committing. Even so, all nightly builds are apparently broken due to
my commit. I'll now try to find out what went wrong and repair it.
Katja
