Re: [pdf-devel] Updated unit test for pdf_i64_add

2010-02-24 Thread Jeffrey Walton
+N3huyLaUn9yMwQ/lj4Ndj1g= MIME-Version: 1.0 Received: by 10.204.141.69 with SMTP id l5mr3865126bku.64.1267010028293; Wed, 24 Feb 2010 03:13:48 -0800 (PST) Reply-To: noloa...@gmail.com Date: Wed, 24 Feb 2010 06:13:48 -0500 Message-ID: <605f8e051002240313y626fe709webba88c1799b5...@mail.gmail.com>

Re: [pdf-devel] Updated unit test for pdf_i64_add

2010-02-24 Thread Jeffrey Walton
24 Feb 2010 02:28:59 -0800 (PST) Reply-To: noloa...@gmail.com Date: Wed, 24 Feb 2010 05:28:59 -0500 Message-ID: <605f8e051002240228v26b2eefeu9441c891d960f...@mail.gmail.com> Subject: Tests diff From: Jeffrey Walton To: pdf-devel@gnu.org Content-Type: multipart/mixed

Re: [pdf-devel] Updated unit test for pdf_i64_add

2010-02-24 Thread Jeffrey Walton
Hi Aleksander, > Did you try gzip-ing the file before sending it? I tried tar/bz2. Sadly, the mail server leaves the rejection as a mystery by not offering a reason. Does GNU have an FTP site? Jeff On Wed, Feb 24, 2010 at 5:34 AM, Aleksander Morgado wrote: > Hi Jeff, > >> >> > Could you send

Re: [pdf-devel] Updated unit test for pdf_i64_add

2010-02-24 Thread Jeffrey Walton
Hi Aleksander, > Could you send a diff or bzr merge directive instead of all > these changed files? Unfortunately, I cannot. The mail server is rejecting again. Jeff This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more o

[pdf-devel] Updated unit test for pdf_i64_neg

2010-02-24 Thread Jeffrey Walton
Hi All, This is an updated unit test. The test cases include overflow and detection, and bad params. It was tested with and without PDF_FORCE_BIGNUMS. I did not create the full patch/diff since it can be rejected. * drop pdf_i64_neg.c in torture/unit/base/types/ over top of the existing file Jef

[pdf-devel] Updated unit test for pdf_i64_abs

2010-02-24 Thread Jeffrey Walton
Hi All, This is an updated unit test. The test cases include overflow and detection, and bad params. It was tested with and without PDF_FORCE_BIGNUMS. I did not create the full patch/diff since it can be rejected. * drop pdf_i64_abs.c torture/unit/base/types/ over top of the existing file Jeff /

[pdf-devel] Unit test for pdf_i64_mult_i32

2010-02-24 Thread Jeffrey Walton
Hi All, This is a missing unit test. It was tested with and without PDF_FORCE_BIGNUMS. I did not create the full patch/diff since it can be rejected. * drop pdf_i64_mult_i32.c torture/unit/base/types/ * add a declaration and statement in torture/unit/base/types/tsuites-types.c * add a entry under

[pdf-devel] Unit test for pdf_i64_cmp_i32

2010-02-24 Thread Jeffrey Walton
Hi All, This is a missing unit test. It was tested with and without PDF_FORCE_BIGNUMS. I did not create the full patch/diff since it can be rejected. * drop pdf_i64_cmp_i32.c into torture/unit/base/types/ * add a declaration and statement in torture/unit/base/types/tsuites-types.c * add a entry u

[pdf-devel] Unit test for pdf_i64_add_i32

2010-02-24 Thread Jeffrey Walton
Hi All, This is a missing unit test. It was tested with and without PDF_FORCE_BIGNUMS. I did not create the full patch/diff since it can be rejected. * drop pdf_i64_add_i32.c into torture/unit/base/types/ * add a declaration and statement in torture/unit/base/types/tsuites-types.c * add a entry u

[pdf-devel] Issue with make syntax-check

2010-02-19 Thread Jeffrey Walton
H All, patch_safety_dispatcher.py seems to be hanging on error_exit_success. Below was stopped after about half an hour (the checks before error_exit_success returned immediately). Any ideas? Jeff jeff...@gauss:~/Gnu-Pdf$ make syntax-check GFDL_version GPL_version Wundef_boolean avoid_if_before

Re: [pdf-devel] Selective unit testing

2010-02-19 Thread Jeffrey Walton
Hi Aleksander, > That `srunner_run' function is in SVN check: > svn co https://check.svn.sourceforge.net/svnroot/check check OK. Thanks. I should have paid better attention to "the SVN version..." Jeff On Fri, Feb 19, 2010 at 4:59 AM, Aleksander Morgado wrote: > >> Sorry to ask yet another lame

[pdf-devel] Status of PDF_ERROR versus PDF_EBADDATA

2010-02-19 Thread Jeffrey Walton
Hi All, Nearly all (if not all) of the pdf-types functions return PDF_ERROR if response to a required but missing parameter. For example, pdf_i64_t a, b; pdf_status_t status; pdf_i64_add(NULL, a, b, &status) would return PDF_ERROR even though PDF_EBADDATA specifies bad arguments into

Re: [pdf-devel] Selective unit testing

2010-02-18 Thread Jeffrey Walton
Hi Jose, Sorry to ask yet another lame question > Briefly, now it is possible to specify a selection when > invoking make check. So... > >$ make check FUNCTION=pdf_alloc > ... > > The hacker's guide has been updated to document this new > functionality. 'make check' is failing due to und

Re: [pdf-devel] Base Types API

2010-02-18 Thread Jeffrey Walton
Hi Aleksander, >> Can the functions with an asterisk be removed? If the functions are >> not 'code proliferation' added over time, I will write test cases for >> them. > No, we shouldn't remove them. They may not be used in the base layer, > but they may be used in upper layers. OK. I'll begin on

Re: [pdf-devel] code static analysis

2010-02-17 Thread Jeffrey Walton
Hi All/Aleksander, > Also created a new flyspray task for the remaining ones: > http://www.gnupdf.org/flyspray/index.php?do=details&task_id=110 > The task is quite easy and can be taken by any new contributor. If no one else is interested, I'd be happy to work them. I'm a firm believer in slaying

[pdf-devel] Base Types API

2010-02-17 Thread Jeffrey Walton
Hi All/Jose, Below is a list of functions of interest relating to pdf_i64_t from http://gnupdf.org/Lib:API_Consistency_Report. I believe they make up the public functions exposed by pdf-type.h/pdf-type.c. The items with an asterisk (*) are not used. In general, they are a pdf_i32_t variant of the

[pdf-devel] Re: pdf_i64_quick_assign

2010-02-12 Thread Jeffrey Walton
Hi Aleksander, > I agree in that a name like "pdf_i64_set_i32" would be clearer. > Not in the other things. OK (but don't discount elegance). >> something like pdf_i64_new_i32 might be more useful: > Well, that is something that could also be added, and may be > useful in cases like the one you s

[pdf-devel] Configure and PREFIX

2010-02-10 Thread Jeffrey Walton
Hi All, jeff...@gauss:~/gnu-pdf$ sudo rm -rf /usr/local/lib/*gnupdf* ... ./configure CFLAGS=-g PREFIX=/usr ... make install ... Libraries have been installed in: /usr/local/lib jeff...@gauss:~/gnu-pdf$ ls /usr/local/lib/*gnupdf* /usr/local/lib/libgnupdf.a /usr/local/lib/libgnupdf.so.0 /usr/l

Re: [pdf-devel] gdb breakpoints in scripts?

2010-02-09 Thread Jeffrey Walton
Hi Aleksander (and Jose), > Jose and me tried on weekend to run under GDB all torture > tests, playing with "follow-fork-mode" and "detach-on-fork" > options; but no success. > [SNIP] Thanks for the help. It's nice to see it was not something dumb on my part. > Thus, this is not a good method to

Re: [pdf-devel] PDF_FORCE_BIGNUM

2010-02-06 Thread Jeffrey Walton
Hi Jose, > Its not enough to '#define PDF_FORCE_BIGNUMS' in types.h (apparently, > some modules do not treat pdf_i64_t opaquely, or do not honor > PDF_USE_BUILTIN_64BIT_SUPPORT). > > Which modules are those? We definitely want to fix that. I think this one is now tracked down. pdf-time.c wo

[pdf-devel] pdf_i64_ style?

2010-02-05 Thread Jeffrey Walton
Hi All/Jose, I was looking at the gnupdf.texi file. In the document, pdf_i64_add is shown as (in the documentation for pdf_error): pdf_i64_t dest, addend_1, addend_2; pdf_status_t status; ... status = pdf_i64_add (dest, addend_1, addend_2); In the H and C file, the function is as follows: pdf_i

[pdf-devel] PDF_FORCE_BIGNUM

2010-02-04 Thread Jeffrey Walton
Hi All/Jose, In config.h near line 790, there's the following comment: /* Force the usage of the 64bits bignum implementation even if the system support a suitable native type */ /* #undef PDF_FORCE_BIGNUMS */ I think the comment could be revised to better reflect preprocessor state: /* Force

Re: [pdf-devel] Problems Compiling with PDF_FORCE_BIGNUMS (Unexpected Code Generation?)

2010-02-02 Thread Jeffrey Walton
Hi Aleksander, Thanks for the QC... It's a new day, and I'm fresh, so hopefully no dumb mistakes. Jeff On Tue, Feb 2, 2010 at 3:13 AM, Aleksander Morgado wrote: > Hi Jeff, > >> I believe the problem arises because, in the case of >> PDF_FORCE_BIGNUMS, a struct is being pushed on the stack and a

[pdf-devel] Problems Compiling with PDF_FORCE_BIGNUMS (Unexpected Code Generation?)

2010-02-01 Thread Jeffrey Walton
Hi All, If PDF_FORCE_BIGNUMS is defined, the library's pdf_i64_t is used: struct pdf_i64_s { pdf_i32_t high; pdf_u32_t low; }; typedef struct pdf_i64_s pdf_i64_t; Running 'make check' causes a melt down in a number of modules (shown below). I can control the way many of these functions crash

Re: [pdf-devel] gdb breakpoints in scripts?

2010-02-01 Thread Jeffrey Walton
Hi Aleksander, >> I was able load and run the script under gdb as stated in [1]. I set a >> BP on the function of interest. gdb responded as expected with a file >> and line number (which were correct). >> >> However, when I run the script, the BP is never hit. I do see the >> results of the faile

[pdf-devel] gdb breakpoints in scripts?

2010-02-01 Thread Jeffrey Walton
Hi All/Jose, I was able load and run the script under gdb as stated in [1]. I set a BP on the function of interest. gdb responded as expected with a file and line number (which were correct). However, when I run the script, the BP is never hit. I do see the results of the failed test, so I know t

[pdf-devel] Issue with runtests

2010-01-29 Thread Jeffrey Walton
Hi All, I seem to be having problems running runtests.sh after building. Any ideas where ${srcdir}/runtests is located? I can't seem to find it and the script appears to be blowing up. Jeff jeff...@gauss:~/trunk/torture/unit$ sh ./runtests.sh chmod: cannot access `/torture/testdata/TD4': No

[pdf-devel] Assertions and DEBUG/NDEBUG

2010-01-28 Thread Jeffrey Walton
Hi All, Does the group have a preference on using assertions? I found one thread in the archives that touched on their use, but nothing in the style guide. Jeff