Re: AW: when to rotate text

2008-11-18 Thread Jukka Zitting
Hi, On Tue, Nov 18, 2008 at 5:12 AM, Brian Carrier <[EMAIL PROTECTED]> wrote: > On Nov 17, 2008, at 9:14 PM, Jukka Zitting wrote: >> Is the text-rotation-081117.zip file in PDFBOX-374 ready to be committed? > > Yes. It fixes all of the examples that have been posted and fixes some > previously un

Re: AW: when to rotate text

2008-11-17 Thread Brian Carrier
On Nov 17, 2008, at 9:14 PM, Jukka Zitting wrote: Hi, Andreas and Brian, thanks for the effort! I tried to review your work but unfortunately I'm not a PDF expert and didn't have too much time to focus on this so I couldn't tell what's the current status with your changes. However, unless som

Re: Re: AW: when to rotate text

2008-11-17 Thread Jukka Zitting
Hi, Andreas and Brian, thanks for the effort! I tried to review your work but unfortunately I'm not a PDF expert and didn't have too much time to focus on this so I couldn't tell what's the current status with your changes. However, unless some of our normal committers chimes in, I trust your wor

Re: Re: AW: when to rotate text

2008-11-16 Thread Andreas Lehmkühler
> ... > The effect of this approach is that none of the callers need to know > about rotation and text orientation, just TextPosition. Is this > similar to your approach? As far as remember my code, I guess it is compatible with yours. As I already wrote, I'm out of office for a few days and

Re: AW: when to rotate text

2008-11-14 Thread Brian Carrier
On Nov 14, 2008, at 2:44 AM, <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> wrote: One conclusion seems to be: of course the whole coords-flipping and moving thing in the PDFStreamEngine doesn't rotate the text. We have to find out how the rotation is handled by non-text-elements. After solving t

Re: AW: when to rotate text

2008-11-12 Thread Brian Carrier
On Nov 12, 2008, at 9:47 AM, <[EMAIL PROTECTED]> wrote: I'm trying to find a solution to the text rotation problems that satisfy the current regression tests and that work on some files that I found bugs with. I've a hit a point though where I need insight from people who know more about the