[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-12 Thread Petr Pisar
ppisar closed without merging a pull-request against the project: `perl-FCGI` that you are following. Closed pull-request: `` Conditionalize client tests `` https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list --

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-12 Thread Petr Pisar
ppisar commented on the pull-request: `Conditionalize client tests` that you are following: `` I applied this, slightly modified, patch. It removes the tests which require FCGI::Client on RHEL. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-08 Thread Michal Josef Špaček
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` > FCGI::Client is not a low-cost test dependency though You are right. In this case, we need to rewrite the testing of FCGI::Client. `` To reply, visit the link below

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-07 Thread Yaakov Selkowitz
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` FCGI::Client is not a low-cost test dependency though, through Type::Tiny it pulls in dozens of otherwise unnecessary Perl module packages, some of which are explicitly unwanted in RHEL. Running

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-07 Thread Michal Josef Špaček
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` @yselkowitz Yes 4) it's possible, but in my mind, this is something for integration tests. This is a kind of sw library, where is implemented some network protocol and I think that each this

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-06 Thread Yaakov Selkowitz
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` 4) Merge this, and run the full testsuite in gating instead of during the build, which gives you much more flexibility wrt dependencies: https://docs.fedoraproject.org/en-US/ci/tmt/ `` To reply,

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-05 Thread Michal Josef Špaček
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` @yselkowitz I don't think that's a good approach. CC @jplesnik We want to deliver these tests to RHEL10 (btw: I created these tests). The only issue is the big dependencies of FCGI::Client.

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-05 Thread Yaakov Selkowitz
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` This is part of Fedora being the upstream of CentOS Stream and RHEL. Fedora builds are not affected, they will continue to run all the tests. Only RHEL/ELN builds, where these test dependencies

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-05 Thread Yaakov Selkowitz
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` This is part of Fedora being the upstream of CentOS Stream and RHEL. Fedora builds are not affected, they will continue to run all the tests. Only RHEL/ELN builds, where these test dependencies

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-05 Thread Ralf Corsépius
corsepiu commented on the pull-request: `Conditionalize client tests` that you are following: `` I do not agree neither with this patch nor with the attitude behind it. It has always been Fedora's convention to "test to the max" and not to cripple packages, which are providing self tests.

[rpms/perl-FCGI] PR #2: Conditionalize client tests

2023-06-04 Thread Yaakov Selkowitz
yselkowitz opened a new pull-request against the project: `perl-FCGI` that you are following: `` Conditionalize client tests `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list --